Assets: Add License and Copyright meta-data #105318

Merged
Harley Acheson merged 3 commits from Harley/blender:AssetMeta into blender-v3.5-release 2023-03-07 18:22:53 +01:00
Member

As per #105300, this adds optional "license" and "copyright" meta-data
to assets.


They look like this in the interface:

CopyrightLicense.png

As per #105300, this adds optional "license" and "copyright" meta-data to assets. --- They look like this in the interface: ![CopyrightLicense.png](/attachments/a52f7274-3a2e-475a-9364-d863544346fa)
Harley changed target branch from main to blender-v3.5-release 2023-02-28 21:38:33 +01:00
Harley Acheson changed title from Assets: Add License and Copyright metadata to Assets: Add License and Copyright meta-data 2023-02-28 21:39:53 +01:00
Harley Acheson requested review from Julian Eisel 2023-02-28 21:41:40 +01:00

Hi Harley, License should go before Copyright. Some licenses don't require copyright, so this field may end up empty every now and then.

Hi Harley, License should go before Copyright. Some licenses don't require copyright, so this field may end up empty every now and then.
Harley Acheson force-pushed AssetMeta from b0630d4e2b to e3200e2696 2023-03-02 18:49:38 +01:00 Compare
Harley Acheson changed title from Assets: Add License and Copyright meta-data to WIP: Assets: Add License and Copyright meta-data 2023-03-02 18:55:18 +01:00
Harley Acheson force-pushed AssetMeta from e3200e2696 to fc11ff92ad 2023-03-02 19:00:32 +01:00 Compare
Harley Acheson changed title from WIP: Assets: Add License and Copyright meta-data to WIP: Assets: Add License and Copyright metadata 2023-03-02 19:05:38 +01:00
Harley changed target branch from blender-v3.5-release to main 2023-03-02 19:05:48 +01:00
Harley Acheson force-pushed AssetMeta from fc11ff92ad to 00ca7c5221 2023-03-02 19:27:49 +01:00 Compare
Harley Acheson changed title from WIP: Assets: Add License and Copyright metadata to WIP: Assets: Add License and Copyright meta-data 2023-03-02 19:28:20 +01:00
Harley changed target branch from main to blender-v3.5-release 2023-03-02 19:28:32 +01:00
Harley Acheson changed title from WIP: Assets: Add License and Copyright meta-data to Assets: Add License and Copyright meta-data 2023-03-02 19:50:57 +01:00
Author
Member

Hi Harley, License should go before Copyright. Some licenses don't require copyright, so this field may end up empty every now and then.

Yes, I swapped those around. And updated the captures in the first comment.

> Hi Harley, License should go before Copyright. Some licenses don't require copyright, so this field may end up empty every now and then. Yes, I swapped those around. And updated the captures in the first comment.
Julian Eisel requested changes 2023-03-06 13:06:33 +01:00
Julian Eisel left a comment
Member

Let's not deprecate the author field, this may still be useful in some cases (e.g. to know who to contact in case of unclear copyright). We can just show a bunch of metadata fields, if people don't need it, they just don't set it.

Separately, we could make it so unset fields from an external asset are not shown, a bunch of empty buttons are not really useful. For assets from the current file we show all available fields. Again, this is a separate change, for the release we can just add the copyright and license field.

Checked with @dfelinto and he's fine with that. Code wise looks good (suggested tooltip changes).

Let's not deprecate the author field, this may still be useful in some cases (e.g. to know who to contact in case of unclear copyright). We can just show a bunch of metadata fields, if people don't need it, they just don't set it. Separately, we could make it so unset fields from an external asset are not shown, a bunch of empty buttons are not really useful. For assets from the current file we show all available fields. Again, this is a separate change, for the release we can just add the copyright and license field. Checked with @dfelinto and he's fine with that. Code wise looks good (suggested tooltip changes).
@ -400,0 +471,4 @@
"rna_AssetMetaData_copyright_get",
"rna_AssetMetaData_copyright_length",
"rna_AssetMetaData_copyright_set");
RNA_def_property_ui_text(prop, "Copyright", "Copyright of the asset");
Member

The description isn't adding much information, but I'm also not sure what to put in there. Maybe: "Copyright notice of the asset. An empty copyright notice does not mean there are no copyrights assigned. Contact the author if any clarification is needed."

The description isn't adding much information, but I'm also not sure what to put in there. Maybe: *"Copyright notice of the asset. An empty copyright notice does not mean there are no copyrights assigned. Contact the author if any clarification is needed."*
Harley marked this conversation as resolved
@ -400,0 +479,4 @@
"rna_AssetMetaData_license_get",
"rna_AssetMetaData_license_length",
"rna_AssetMetaData_license_set");
RNA_def_property_ui_text(prop, "License", "License of the asset");
Member

Similar thing here, suggest something like: "Name of the license the asset is distributed under. An empty license name does not mean there are no licensing terms. Contact the author if any clarification is needed."

Similar thing here, suggest something like: *"Name of the license the asset is distributed under. An empty license name does not mean there are no licensing terms. Contact the author if any clarification is needed."*
Harley marked this conversation as resolved
Harley Acheson changed title from Assets: Add License and Copyright meta-data to WIP: Assets: Add License and Copyright meta-data 2023-03-06 17:50:16 +01:00
Harley Acheson force-pushed AssetMeta from 016d8e05dd to 94cb92e7b3 2023-03-06 19:32:47 +01:00 Compare
Harley Acheson force-pushed AssetMeta from 94cb92e7b3 to 09f5c37f5e 2023-03-06 20:15:31 +01:00 Compare
Harley Acheson changed title from WIP: Assets: Add License and Copyright meta-data to Assets: Add License and Copyright meta-data 2023-03-06 20:31:58 +01:00
Julian Eisel approved these changes 2023-03-07 10:59:52 +01:00
Julian Eisel left a comment
Member

LGTM! Thanks for working on this.

LGTM! Thanks for working on this.
@ -400,0 +486,4 @@
RNA_def_property_ui_text(prop,
"License",
"The type of license this asset is distributed under. An empty license "
"name does not necessarily indicate that this is without licensing "
Member

Maybe "... that this is free of licensing terms" sounds a bit better? You decide :)

Maybe "... that this is free of licensing terms" sounds a bit better? You decide :)
Harley marked this conversation as resolved
Harley Acheson added 1 commit 2023-03-07 18:20:00 +01:00
Harley Acheson added 1 commit 2023-03-07 18:21:47 +01:00
Harley Acheson merged commit d0918c5c7f into blender-v3.5-release 2023-03-07 18:22:53 +01:00
Harley Acheson deleted branch AssetMeta 2023-03-07 18:22:54 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105318
No description provided.