Fix #105339: grease pencil selection can toggle object selection #105342

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:105339 into blender-v3.5-release 2023-03-02 09:52:47 +01:00
Member

Grease Pencil (when not in object mode) implements its own selection
opertor. This operator (gpencil.select) returns
OPERATOR_PASS_THROUGH, then falls though to view3d.select which can
toggle object selection (when using shift-click picking).

Removing OPERATOR_PASS_THROUGH would fix the object toggling, but this
was added in 62c73db734 with good reason (the tweak tool would not
work then).

Now prevent view3d.select from acting on Grease Pencil (when not in
object mode).

NOTE: this could also go into the poll function.

Grease Pencil (when not in object mode) implements its own selection opertor. This operator (`gpencil.select`) returns `OPERATOR_PASS_THROUGH`, then falls though to `view3d.select` which can toggle object selection (when using shift-click picking). Removing `OPERATOR_PASS_THROUGH` would fix the object toggling, but this was added in 62c73db73415 with good reason (the tweak tool would not work then). Now prevent `view3d.select` from acting on Grease Pencil (when not in object mode). NOTE: this could also go into the poll function.
Philipp Oeser added 1 commit 2023-03-01 15:26:46 +01:00
9b7e7c168c Fix #105339: grease pencil selection can toggle object selection
Grease Pencil (when not in object mode) implements its own selection
opertor. This operator (`gpencil.select`) returns
`OPERATOR_PASS_THROUGH`, then falls though to `view3d.select` which can
toggle object selection (when using shift-click picking).

Removing `OPERATOR_PASS_THROUGH` would fix the object toggling, but this
was added in 62c73db734 with good reason (the tweak tool would not
work then).

Now prevent `view3d.select` from acting on Grease Pencil (when not in
object mode).

NOTE: this could also go into the poll function.
Philipp Oeser added this to the Grease Pencil project 2023-03-01 15:27:02 +01:00
Philipp Oeser requested review from Falk David 2023-03-01 15:27:12 +01:00
Philipp Oeser requested review from Campbell Barton 2023-03-01 15:27:25 +01:00
Campbell Barton approved these changes 2023-03-02 06:51:03 +01:00

While the fix is OK AFAICS, longer term I think we could have grease pencil using view3d.select to avoid having to add these awkward exceptions.

While the fix is OK AFAICS, longer term I think we could have grease pencil using `view3d.select` to avoid having to add these awkward exceptions.
Philipp Oeser merged commit 2eeec49640 into blender-v3.5-release 2023-03-02 09:52:47 +01:00
Philipp Oeser deleted branch 105339 2023-03-02 09:52:50 +01:00
Antonio Vazquez removed this from the Grease Pencil project 2023-03-21 16:05:34 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105342
No description provided.