Fix #105395: Handle quoted paths better in the OBJ importer #105478

Jesse Yurkovich · 2023-03-06T03:01:02+01:00

Jesse Yurkovich commented

2023-03-06 03:01:02 +01:00

If the texture image path in the MTL is a "quoted" absolute path, the importer will fail to find the
file. It was only attempting to un-quote the path for the relative case. Now we attempt to un-quote
in all cases.

Before

Cannot load image file: 'T:\New folder\"T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg"'
Cannot load image file: '"T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg"'
Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg'
Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement 03 1k.blend/textures/pavement 03 diff 1k.jpg'
Cannot load image file: 'T:\New folder\pavement_03_diff_1k.jpg"'
OBJ import of 'daz cube text 4.obj' took 24.5 ms

After

Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg'
Loaded image from: 'T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg'
OBJ import of 'daz cube text 4.obj' took 3.2 ms

Question:
Linux/Mac technically allows folder/file names containing literal " quotes. The legacy exporter will write out those quotes
but the legacy importer will not import them correctly.

If a Linux/Mac user zips up such quoted files, as would typically happen when packaging the .obj and accompanying files for distribution, when they are unpacked on Windows the literal " is replaced with _... (just learned this today!)

We could maybe attempt that replacement as well, like we do spaces.

Thoughts on how best to proceed here? We can certainly try more combinations but we're firing in the dark really.

If the texture image path in the MTL is a "quoted" absolute path, the importer will fail to find the file. It was only attempting to un-quote the path for the relative case. Now we attempt to un-quote in all cases. ---- Before ``` Cannot load image file: 'T:\New folder\"T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg"' Cannot load image file: '"T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg"' Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg' Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement 03 1k.blend/textures/pavement 03 diff 1k.jpg' Cannot load image file: 'T:\New folder\pavement_03_diff_1k.jpg"' OBJ import of 'daz cube text 4.obj' took 24.5 ms ``` After ``` Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg' Loaded image from: 'T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg' OBJ import of 'daz cube text 4.obj' took 3.2 ms ``` Question: Linux/Mac technically allows folder/file names containing literal `"` quotes. The legacy exporter will write out those quotes but the legacy importer will not import them correctly. If a Linux/Mac user zips up such quoted files, as would typically happen when packaging the .obj and accompanying files for distribution, when they are unpacked on Windows the literal `"` is replaced with `_`... (just learned this today!) We could maybe attempt that replacement as well, like we do spaces. Thoughts on how best to proceed here? We can certainly try more combinations but we're firing in the dark really.

Jesse Yurkovich added 1 commit 2023-03-06 03:01:07 +01:00

2653762f1b WIP: Fix #105395 : Handle quoted paths better in the OBJ importer

If the texture image path in the MTL is a "quoted" absolute path, the importer will fail to find the
file. It was only attempting to un-quote the path for the relative case. Now we attempt to un-quote
in both all cases.

----
Before
```
Cannot load image file: 'T:\New folder\"T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg"'
Cannot load image file: '"T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg"'
Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg'
Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement 03 1k.blend/textures/pavement 03 diff 1k.jpg'
Cannot load image file: 'T:\New folder\pavement_03_diff_1k.jpg"'
OBJ import of 'daz cube text 4.obj' took 24.5 ms
```

After
```
Cannot load image file: 'T:\New folder\T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg'
Loaded image from: 'T:/New Folder/Testure 1/texture 2/texture 3/texture 4/pavement_03_1k.blend/textures/pavement_03_diff_1k.jpg'
OBJ import of 'daz cube text 4.obj' took 3.2 ms
```

Question:
Linux/Mac technically allows folder/file names containing literal `"` quotes. The legacy exporter will write out those quotes
but the legacy importer will not import them correctly.

If a Linux/Mac user zips up such quoted files, as would typically happen when packaging the .obj and accompanying files for distribution, when they are unpacked on Windows the literal `"` is replaced with `_`... (just learned this today!)

We could maybe attempt that replacement as well, like we do spaces.

Thoughts on how best to proceed here? We can certainly try more combinations but we're firing in the dark really.

Jesse Yurkovich requested review from Aras Pranckevicius 2023-03-06 03:01:18 +01:00

Jesse Yurkovich added this to the Pipeline, Assets & IO project 2023-03-06 03:01:25 +01:00

Aras Pranckevicius approved these changes 2023-03-06 05:56:14 +01:00

Aras Pranckevicius left a comment

Looks good to me, thanks!

Thoughts on how best to proceed here? We can certainly try more combinations but we're firing in the dark really

I'm not sure if it's worth doing everything possible. Like, technically Linux allows bytes with actual zero value in the filenames, but in practice nothing supports that. Or for example, a filename called "CON" or "PRN" or "AUX" is illegal on Windows. Having quotes around the name is probably fairly common, having super exotic ones maybe we should not try to solve until we run into something that actually uses them.

Looks good to me, thanks! > Thoughts on how best to proceed here? We can certainly try more combinations but we're firing in the dark really I'm not sure if it's worth doing everything possible. Like, technically Linux allows bytes with actual zero value in the filenames, but in practice nothing supports that. Or for example, a filename called "CON" or "PRN" or "AUX" is illegal on Windows. Having quotes around the name is probably fairly common, having super exotic ones maybe we should not try to solve until we run into something that actually uses them.

Jesse Yurkovich changed title from ~~WIP: Fix #105395: Handle quoted paths better in the OBJ importer~~ to Fix #105395: Handle quoted paths better in the OBJ importer

2023-03-06 06:26:06 +01:00

Jesse Yurkovich merged commit 68d5784802 into blender-v3.5-release

2023-03-06 06:29:51 +01:00

Jesse Yurkovich referenced this issue from a commit

2023-03-06 06:29:51 +01:00

Fix #105395: Handle quoted paths better in the OBJ importer

Jesse Yurkovich deleted branch fix105395-objquote

2023-03-06 06:29:53 +01:00

Jesse Yurkovich referenced this issue from a commit

2023-03-06 06:36:50 +01:00

Fix #105395: Handle quoted paths better in the OBJ importer

Bastien Montagne removed this from the Pipeline, Assets & IO project 2023-07-03 13:01:39 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #105395: Handle quoted paths better in the OBJ importer #105478