From 5336a00353b3c0b8655d748258dffb0dc778dabc Mon Sep 17 00:00:00 2001 From: Weizhen Huang Date: Thu, 9 Mar 2023 11:50:29 +0100 Subject: [PATCH] Fix #105553: do not copy "Roughness" value from the previous node --- source/blender/editors/space_node/node_templates.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/source/blender/editors/space_node/node_templates.cc b/source/blender/editors/space_node/node_templates.cc index cb69800e515..e0154338b67 100644 --- a/source/blender/editors/space_node/node_templates.cc +++ b/source/blender/editors/space_node/node_templates.cc @@ -268,7 +268,13 @@ static void node_socket_add_replace(const bContext *C, nodeRemLink(ntree, link); } - node_socket_copy_default_value(sock_from, sock_prev); + /* NOTE: some properties have different (physical) meanings among different nodes, even + * when they share the same name; the values of these sockets should not be copied. For + * now a few special cases are made, we could implement some more sophisticated mechanism + * if necessary. */ + if (!STREQ(sock_from->name, "Roughness")) { + node_socket_copy_default_value(sock_from, sock_prev); + } } } } -- 2.30.2