WIP: VSE: Use seconds for strip length and position #105620

Richard Antalik · 2023-03-09T23:15:47+01:00

Richard Antalik commented

2023-03-09 23:15:47 +01:00

When seconds are used to define strips, this allows for changing scene framerate without affecting timeline composition.

Seconds are only used internally where necessary. All accessor functions return length or position in frames.
There is no change for user.

Drawback is, that in a lot of cases, conversion from seconds to frames and back to seconds is necessary.

TODO:

Retimed strips don't work very well. Perhaps a function could exist to get overall factor, so it can be applied to seq->len

Plan for this patch is to merge after Sequence::anim_*ofs is replaced by retiming freeze frames

When seconds are used to define strips, this allows for changing scene framerate without affecting timeline composition. Seconds are only used internally where necessary. All accessor functions return length or position in frames. There is no change for user. Drawback is, that in a lot of cases, conversion from seconds to frames and back to seconds is necessary. TODO: - Retimed strips don't work very well. Perhaps a function could exist to get overall factor, so it can be applied to `seq->len` Plan for this patch is to merge after `Sequence::anim_*ofs` is replaced by retiming freeze frames

❤️ 2

Richard Antalik added 8 commits 2023-03-09 23:16:06 +01:00

2eb7847c4c VSE: Use seconds to define strip length and position

d2b9ee4cfd Merge branch 'main' into time-in-seconds

3b27d69f57 Fix build error

8ba6379033 Bunch of stuff to make this work

fecde4561a Merge branch 'main' into time-in-seconds

7a981825f8 Add versioning code

56a3c21e94 Fix incorrect sound start position

12a953d53a Fix effect lengths

Hans Goudey changed title from ~~[WIP] VSE: Use seconds for strip length and position~~ to WIP: VSE: Use seconds for strip length and position

2023-03-09 23:44:24 +01:00

Richard Antalik added 1 commit 2023-04-12 03:07:22 +02:00

2eef653538 Update operators and RNA

Rna is still buggy - needs to calculate frames to seconds?

Richard Antalik referenced this pull request

2023-05-24 04:37:38 +02:00

Regression: VSE: Copy-Paste of strips from one scene to another offsets the data #108157

Richard Antalik added 1 commit 2023-06-22 15:48:52 +02:00

ed5960ce64 Merge branch 'main' into time-in-seconds

Richard Antalik added 2 commits 2023-06-23 17:10:33 +02:00

c1cb0696b2 Merge branch 'main' into time-in-seconds

fb4523d6d4 Fix RNA functionality

Richard Antalik added 1 commit 2023-06-27 09:14:06 +02:00

fce4040537 Start work on retiming

This pull request has changes conflicting with the target branch.

source/blender/blenkernel/BKE_blender_version.h
source/blender/blenkernel/intern/sound.c
source/blender/blenloader/intern/versioning_400.cc
source/blender/editors/space_sequencer/sequencer_draw.cc
source/blender/editors/space_sequencer/sequencer_edit.cc
source/blender/editors/space_sequencer/sequencer_gizmo_retime_type.cc
source/blender/editors/space_sequencer/sequencer_retiming.cc
source/blender/editors/transform/transform_convert_sequencer.c
source/blender/editors/transform/transform_snap_sequencer.c
source/blender/makesdna/DNA_sequence_types.h

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u time-in-seconds:iss-time-in-seconds

git checkout iss-time-in-seconds

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: VSE: Use seconds for strip length and position #105620

Checkout