Animation: Weight Paint select more/less for vertices #105633

Merged
Christoph Lendenfeld merged 14 commits from ChrisLend/blender:weight_paint_grow_sel_vert into main 2023-03-31 14:48:09 +02:00

This adds the select more/less operators to the weight paint mode vertex selection.

Just like in edit mode, press CTRL+Numpad Plus/Minus to use them.
They have also been added to the Select menu.

This adds the select more/less operators to the weight paint mode vertex selection. Just like in edit mode, press CTRL+Numpad Plus/Minus to use them. They have also been added to the Select menu.
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2023-03-10 12:46:36 +01:00
Christoph Lendenfeld added 6 commits 2023-03-10 12:46:46 +01:00
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-03-10 12:47:07 +01:00
Christoph Lendenfeld requested review from Marion Stalke 2023-03-10 12:47:07 +01:00
Hans Goudey reviewed 2023-03-10 13:39:23 +01:00
Hans Goudey left a comment
Member

This works well in a simple test. I have the same comment as in the face version of the patch-- that it would be helpful to have a version of these functions that just takes a Mesh as an argument, and that would also make sense as an abstraction level.

This works well in a simple test. I have the same comment as in the face version of the patch-- that it would be helpful to have a version of these functions that just takes a Mesh as an argument, and that would also make sense as an abstraction level.
@ -662,0 +683,4 @@
MeshElemMap *edge_poly_map;
int *edge_poly_mem;
if (face_step) {
BKE_mesh_edge_poly_map_create(&edge_poly_map,
Member

The functionality is the same, but mesh_topology::build_edge_to_poly_map(..) has an interface that's a bit more friendly in C++. Performance might be slightly worse currently, but there are plans to improve those functions in the near future.

The functionality is the same, but `mesh_topology::build_edge_to_poly_map(..)` has an interface that's a bit more friendly in C++. Performance might be slightly worse currently, but there are plans to improve those functions in the near future.
Christoph Lendenfeld force-pushed weight_paint_grow_sel_vert from 7b49b6aba0 to 96a0a0e921 2023-03-10 13:58:01 +01:00 Compare
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR105633) when ready.
Sybren A. Stüvel approved these changes 2023-03-13 15:02:52 +01:00
Sybren A. Stüvel left a comment
Member

LGTM!

LGTM!
Christoph Lendenfeld added 2 commits 2023-03-16 11:18:14 +01:00
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR105633) when ready.
Christoph Lendenfeld requested review from Hans Goudey 2023-03-16 11:18:44 +01:00
Christoph Lendenfeld added 1 commit 2023-03-23 10:21:22 +01:00
Christoph Lendenfeld added 1 commit 2023-03-23 11:16:14 +01:00
Hans Goudey approved these changes 2023-03-23 15:25:09 +01:00
Hans Goudey left a comment
Member

Looks good. Needs an update for #104424, let me know if you have any questions about that.

Looks good. Needs an update for #104424, let me know if you have any questions about that.
@ -662,0 +682,4 @@
}
/* Need a copy of the selected verts that we can read from and is not modified. */
BitVector<> select_vert_original(mesh->totvert, false);
Member

You set every value of the bit vector, so there's no need to explicitly initialize it to false here.

You set every value of the bit vector, so there's no need to explicitly initialize it to false here.
Christoph Lendenfeld added 2 commits 2023-03-24 14:42:01 +01:00
Author
Member

@HooglyBoogly I will wait with merging this until you've reviewed the other patch, just in case I missed something about the Mloop removal

@HooglyBoogly I will wait with merging this until you've reviewed the other patch, just in case I missed something about the `Mloop` removal
Christoph Lendenfeld added 1 commit 2023-03-24 15:03:34 +01:00
Member

Works technically well
but in all view modes that are not wireframes the wire dissapears if you use the short cuts
had show overlays - show wire on

image
image

without "wire on"
the selection is also really really hard to see in wireframe mode
image

Works technically well but in all view modes that are not wireframes the wire dissapears if you use the short cuts had show overlays - show wire on ![image](/attachments/84876bca-6ce5-45b4-ab51-f94b27cc60de) ![image](/attachments/349c9687-eb82-47c0-a745-306e36af7b64) without "wire on" the selection is also really really hard to see in wireframe mode ![image](/attachments/0cae5c7d-f849-4ed9-b5e2-ff579eaba0af)
786 KiB
430 KiB
240 KiB
Author
Member

So I've investigated that, it doesn't come from this patch, but has been an issue in blender for a while: #106369: Weight Paint Vertex Selection Display issue

So I've investigated that, it doesn't come from this patch, but has been an issue in blender for a while: [#106369: Weight Paint Vertex Selection Display issue](https://projects.blender.org/blender/blender/issues/106369)
Christoph Lendenfeld added 1 commit 2023-03-31 14:29:19 +02:00
Christoph Lendenfeld merged commit 0d1a0cb453 into main 2023-03-31 14:48:09 +02:00
Christoph Lendenfeld deleted branch weight_paint_grow_sel_vert 2023-03-31 14:48:10 +02:00
Member

Just noting this is also for other modes using paint mask (vertexpaint & imagepaint equally benefit from it), noice!

Just noting this is also for other modes using paint mask (vertexpaint & imagepaint equally benefit from it), noice!
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105633
No description provided.