blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 750 Projects 19 Wiki Activity

UI: Fix disconnected and non-clickable checkbox labels in popovers #105657

Merged
Pablo Vazquez merged 1 commits from pioverfour/blender:dp_jenkm_popover_checkboxes into main 2023-04-12 17:01:05 +02:00
Conversation 4 Commits 1 Files Changed 3 +35 -42
Damien Picard commented 2023-03-11 13:45:56 +01:00
Member
Copy Link

Follow the logic of
ed870f87b9 Fix weird placement of "Motion Tracking" in 3D View
overlay popup

but with an additional check, if this sub-panel is used in Popover,
and not inside the Sidebar or Property editor.

For panels, the checkbox inside panel header must not have a label, so
the panel can be collapsed/expanded, panels already have their own
label in the header, this remains unchanged with this patch.

For popovers, draw the checkbox in header as usual with label, but
hide the panel header label, see Julian's commit.

Patch by Yevgeny Makarov (@jenkm) in
https://archive.blender.org/developer/D9586

See attached capture illustrating the non-clickable issue: non-clickable-checkbo.mov.

Menu Before After
GP Cursor menu, sculpt mode image image
GP Cursor menu, vertex paint mode image image
GP Cursor menu, weight paint mode image image
GP stroke menu image image
Mesh stroke menu image image
Mesh cursor menu image image
Mesh falloff menu image image
Mesh options menu image image
Mesh masking menu image image

The corresponding panels haven’t changed:
image

Follow the logic of ed870f87b942 Fix weird placement of "Motion Tracking" in 3D View overlay popup but with an additional check, if this sub-panel is used in Popover, and not inside the Sidebar or Property editor. For panels, the checkbox inside panel header must not have a label, so the panel can be collapsed/expanded, panels already have their own label in the header, this remains unchanged with this patch. For popovers, draw the checkbox in header as usual with label, but hide the panel header label, see Julian's commit. Patch by Yevgeny Makarov (@jenkm) in https://archive.blender.org/developer/D9586 ----- See attached capture illustrating the non-clickable issue: `non-clickable-checkbo.mov`. | Menu | Before | After | | ---- | ------ | ----- | | GP Cursor menu, sculpt mode | ![image](/attachments/e38dade7-dd4e-4677-b1fe-60d5d823c67c) | ![image](/attachments/c0a8082c-f869-48af-8386-ea9aa97cf641) | | GP Cursor menu, vertex paint mode | ![image](/attachments/e5a2d175-02cb-40f8-b553-4e931809fa07) | ![image](/attachments/7c03a5ec-e63d-41fb-bb4c-3f180f3a2d34) | | GP Cursor menu, weight paint mode | ![image](/attachments/61e693ff-39f2-4656-9cb6-f50629b2f657) | ![image](/attachments/d5e5c503-4761-4ee7-b94d-f268e98dc606) | | GP stroke menu | ![image](/attachments/bc6da662-5f3e-43ef-9b83-89ebcfb31c25) | ![image](/attachments/f3cc2c2c-3b9e-4252-8b2d-1d2fd6839c88) | | Mesh stroke menu| ![image](/attachments/cfb98e4c-57bd-4a5b-b9e9-d5923819f6ba) | ![image](/attachments/25274a24-1c50-419a-9f69-b75e49027df2) | | Mesh cursor menu| ![image](/attachments/30d90c14-5ae8-4ad1-9e30-359d27b55f9b) | ![image](/attachments/9de415d1-2dd6-4adb-ba5e-c9fe9e914b1c) | | Mesh falloff menu | ![image](/attachments/ca6de1db-b6d4-4090-ac01-5cbece6b5249) | ![image](/attachments/14e2ec43-f3bd-429e-900d-1ee2b20ce2d9) | | Mesh options menu | ![image](/attachments/56d8a02f-9875-4428-a37a-a679302d3459) | ![image](/attachments/f300b03b-11cc-482d-9838-fa58424a59ea) | | Mesh masking menu | ![image](/attachments/5ab858a4-7213-4765-b94b-000166af2ff1) | ![image](/attachments/3cd429ee-5ea0-45b2-8369-cb4d7b0e8ab6) | The corresponding panels haven’t changed: ![image](/attachments/acf23864-4ef9-4a38-ae0e-8edf27c578ed)
non-clickable-checkbo.mov
658 KiB
image.png
36 KiB
image.png
71 KiB
image.png
49 KiB
image.png
77 KiB
image.png
33 KiB
image.png
22 KiB
image.png
20 KiB
image.png
50 KiB
image.png
50 KiB
image.png
49 KiB
image.png
78 KiB
image.png
51 KiB
image.png
72 KiB
image.png
23 KiB
image.png
15 KiB
image.png
19 KiB
image.png
51 KiB
image.png
31 KiB
image.png
16 KiB
👍 3
Damien Picard added this to the User Interface project 2023-03-11 13:53:19 +01:00
Damien Picard force-pushed dp_jenkm_popover_checkboxes from 7569ab116a to 3d9d950685 2023-03-11 17:26:22 +01:00 Compare
Damien Picard requested review from Pablo Vazquez 2023-03-19 16:20:17 +01:00
Damien Picard force-pushed dp_jenkm_popover_checkboxes from 3d9d950685 to 14301e3669 2023-03-19 16:23:24 +01:00 Compare
Damien Picard commented 2023-03-19 16:24:43 +01:00
Author
Member
Copy Link

@pablovazquez I updated the PR to align the checkboxes to the left as you suggested on the chat, and added screenshots.

@pablovazquez I updated the PR to align the checkboxes to the left as you suggested on the chat, and added screenshots.
Damien Picard force-pushed dp_jenkm_popover_checkboxes from 14301e3669 to e9b8f4931b 2023-03-19 17:05:43 +01:00 Compare
Pablo Vazquez approved these changes 2023-03-21 19:39:20 +01:00
Pablo Vazquez left a comment
Member
Copy Link

Thank you!

Thank you!
🎉 2
Damien Picard commented 2023-04-12 14:12:49 +02:00
Author
Member
Copy Link

Hi, do you think this can be merged?

Hi, do you think this can be merged?
Pablo Vazquez commented 2023-04-12 16:36:41 +02:00
Member
Copy Link

Hi, do you think this can be merged?

Yes, go ahead, I approved it 3 weeks ago.

Do you need me to merge it? I see you have commit access ("Collaborator" tag)

> Hi, do you think this can be merged? Yes, go ahead, I approved it 3 weeks ago. Do you need me to merge it? I see you have commit access ("Collaborator" tag)
Damien Picard commented 2023-04-12 16:52:27 +02:00
Author
Member
Copy Link

Do you need me to merge it?

Yes, please :)

I see you have commit access ("Collaborator" tag)

As far as I can tell, "Collaborator" is only for triaging, I can’t merge or push myself.

image

> Do you need me to merge it? Yes, please :) > I see you have commit access ("Collaborator" tag) As far as I can tell, "Collaborator" is only for triaging, I can’t merge or push myself. ![image](/attachments/9cb94605-ba0f-4193-9bd1-e94c85c1f5b9)
image.png
19 KiB
Pablo Vazquez merged commit 2771f53cb7 into main 2023-04-12 17:01:05 +02:00
Pablo Vazquez deleted branch dp_jenkm_popover_checkboxes 2023-04-12 17:01:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
User Interface
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105657
No description provided.
Delete Branch "pioverfour/blender:dp_jenkm_popover_checkboxes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?