WIP: Fix #105404: The USD Input operator does not validate the file received as input. #105659

Piyush Aniruddha Udhao · 2023-03-11T13:59:03+01:00

2023-03-11 13:59:03 +01:00

First-time contributor

There is no check to implement if the USD input operator inputs the right files. This pull request aims to fix that by first, storing the actual length of the input file in a variable int i. We find that by incrementing i till filename[i] is not equal to \0.
We know that a valid filepath is the one which ends with '.usd'. We check that by running an if-check for the invalid case, and if it returns a true value and we enter the if block, we report the error and return OPERATOR_CANCELLED.

Fixes #105404.

Alternate Solutions: The function RNA_string_get() calls RNA_property_string_get(), where an assertion on char *value could be implemented.

There is no check to implement if the USD input operator inputs the right files. This pull request aims to fix that by first, storing the actual length of the input file in a variable `int i`. We find that by incrementing `i` till `filename[i]` is not equal to `\0`. We know that a valid filepath is the one which ends with '.usd'. We check that by running an if-check for the invalid case, and if it returns a true value and we enter the if block, we report the error and return `OPERATOR_CANCELLED`. Fixes #105404. Alternate Solutions: The function `RNA_string_get()` calls `RNA_property_string_get()`, where an assertion on `char *value` could be implemented.

Piyush Aniruddha Udhao added 2 commits 2023-03-11 13:59:14 +01:00

c296cd9b7d Fix #105404 : The USD Input operator did not validate the file received as input.

e9a4c9bd60 Fix #105404 : The USD Input operator did not validate the file received as input

Brecht Van Lommel commented

2023-03-11 14:27:00 +01:00

The original report was about a directory instead of file being specified, which this does not cover.

Further USD has multiple possible file extensions like .usda and .usdz so this test is not correct. I don't think checking for file extensions is required at all really, we generally enforce those in file browser filtering but do not strictly forbid using a different extension.

The original report was about a directory instead of file being specified, which this does not cover. Further USD has multiple possible file extensions like .usda and .usdz so this test is not correct. I don't think checking for file extensions is required at all really, we generally enforce those in file browser filtering but do not strictly forbid using a different extension.

Piyush Aniruddha Udhao commented

2023-03-11 15:45:46 +01:00

First-time contributor

we generally enforce those in file browser filtering but do not strictly forbid using a different extension.

I too went into blender and tried to import the wrong file, but it did not allow me to. So this bug confused me. But then I thought, it's marked as a good first issue, why not submit a PR?

> we generally enforce those in file browser filtering but do not strictly forbid using a different extension. I too went into blender and tried to import the wrong file, but it did not allow me to. So this bug confused me. But then I thought, it's marked as a good first issue, why not submit a PR?

This pull request has changes conflicting with the target branch.

source/blender/editors/io/io_usd.c

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u validating-usd-input-file:Piyush-Aniruddha-Udhao-validating-usd-input-file

git checkout Piyush-Aniruddha-Udhao-validating-usd-input-file

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Fix #105404: The USD Input operator does not validate the file received as input. #105659

Checkout