Fix: USD Import: set active mesh color #105907

Closed

Michael Kowalski wants to merge 1 commits from makowalski:usd_import_set_active_color into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Michael Kowalski commented

2023-03-20 00:56:06 +01:00

Member

NOTE: this is a fix to regression in 3.5, so hopefully
it can be merged into the 3.5 release branch.

Fixed a bug where the active color wasn't being set
on imported meshes, resulting in no colors displaying
in the viewport.

This bug has been in the code for a long time. However,
the colors have been displaying correctly until recently,
so this issue wasn't previously apparent.

Also, changed custom color data name from "displayColors"
to "displayColor", to match the actual USD primvar name.
(This was a typo in the original code.)

Note that pull request

addresses other issues in the color import code (e.g.,
converting all color primvars and not just "displayColor",
avoiding hard-coding of attribute names, handling all
iterpolation types, etc.).

However, the current commit is meant as a short term fix
to a regression, where the "displayColor" attribute does
not render in the viewport at all, until the above pull
can be merged.

To reproduce the issue, import the pixar Kitchen_set.usd

https://openusd.org/release/dl_kitchen_set.html

with Color Attributes enabled. The meshes render black
when displaying color attributes is enabled in the viewport.

NOTE: this is a fix to regression in 3.5, so hopefully it can be merged into the 3.5 release branch. Fixed a bug where the active color wasn't being set on imported meshes, resulting in no colors displaying in the viewport. This bug has been in the code for a long time. However, the colors have been displaying correctly until recently, so this issue wasn't previously apparent. Also, changed custom color data name from "displayColors" to "displayColor", to match the actual USD primvar name. (This was a typo in the original code.) Note that pull request https://projects.blender.org/blender/blender/pulls/104542 addresses other issues in the color import code (e.g., converting all color primvars and not just "displayColor", avoiding hard-coding of attribute names, handling all iterpolation types, etc.). However, the current commit is meant as a short term fix to a regression, where the "displayColor" attribute does not render in the viewport at all, until the above pull can be merged. To reproduce the issue, import the pixar `Kitchen_set.usd` https://openusd.org/release/dl_kitchen_set.html with `Color Attributes` enabled. The meshes render black when displaying color attributes is enabled in the viewport.

Michael Kowalski added the

Pipeline, Assets & IO

labels 2023-03-20 00:56:06 +01:00

Michael Kowalski added 1 commit 2023-03-20 00:56:17 +01:00

04160c4d4d USD import fix: set active mesh color.

Fixed a bug where the active color wasn't being set
on imported meshes, resulting in no colors displaying
in the viewport.

This bug has been in the code for a long time. However,
the colors have been displaying correctly until recently,
so this issue wasn't previously apparent.

Also, changed custom color data name from "displayColors"
to "displayColor", to match the actual USD primvar name.
(This was a typo in the original code.)

Note that pull request

#104542

addresses other issues in the color import code (e.g.,
converting all color primvars and not just "displayColor",
avoiding hard-coding of attribute names, handling all
iterpolation types, etc.).

However, the current commit is meant as a short term fix
to a regression, where the "displayColor" attribute does
not render in the viewport at all, until the above pull
can be merged.

Michael Kowalski requested review from Matt McLin 2023-03-20 00:56:45 +01:00

Michael Kowalski requested review from Bastien Montagne 2023-03-20 00:57:23 +01:00

Bastien Montagne requested changes 2023-03-20 11:52:31 +01:00

Bastien Montagne left a comment

Owner

Patch LGTM, can you please create a new PR with proper base (3.5 branch rather than main) though? will make it easier to merge.

Patch LGTM, can you please create a new PR with proper base (3.5 branch rather than main) though? will make it easier to merge.

Brecht Van Lommel added this to the 3.5 milestone 2023-03-20 12:07:00 +01:00

Hans Goudey changed title from ~~USD import fix: set active mesh color.~~ to Fix: USD Import: set active mesh color.

2023-03-20 13:21:18 +01:00

Hans Goudey changed title from ~~Fix: USD Import: set active mesh color.~~ to Fix: USD Import: set active mesh color

2023-03-20 14:18:02 +01:00

Michael Kowalski commented

2023-03-20 16:34:37 +01:00

Author

Member

@mont29 I created a new pull request for this into the 3.5-release branch here:

So I will now close this pull request in favor of the new one.

@mont29 I created a new pull request for this into the 3.5-release branch here: https://projects.blender.org/blender/blender/pulls/105925 So I will now close this pull request in favor of the new one.

Michael Kowalski closed this pull request

2023-03-20 16:34:38 +01:00

Bastien Montagne deleted branch usd_import_set_active_color

2023-03-20 17:06:46 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105907

No description provided.