Fix #94080: clicking empty space in timeline creates undo step #105913

When nothing is found once mouse is released, return OPERATOR_CANCELLED so no undo step is created.

Hi, thanks for the PR. This is a nice improvement.
Though clicking over empty area of timeline/dopesheet selects channel within the clicked region, which is working as expected from code perspective.
So undo step will still be created when no keyframe is selected/deselected (due to selection of channels. see video).
Not sure how to proceed further. Maybe @dr.sybren can have a look at this.

Hi, thanks for the PR. This is a nice improvement. Though clicking over empty area of timeline/dopesheet selects channel within the clicked region, which is working as expected from code perspective. So undo step will still be created when no keyframe is selected/deselected (due to selection of channels. see video). Not sure how to proceed further. Maybe @dr.sybren can have a look at this.

PR-105913-review.mp4

1.2 MiB

Thanks for the patch @Melissa-Goon !

To expand on what @PratikPB2123 already said: a patch should contain either functional changes (as in, change the functionality of Blender) or non-functional changes (like cleaning up formatting of the code, doing refactors of the code that don't change its functionality, etc). Mixing both in the same patch is something that's not allowed here, as it makes it much harder to later look at the history of a file and understand what happened.

You can run make format to let the auto-formatter do its work, and/or configure your editor for auto-formatting with Clang-Format. You can read more about this in the style guide.

Thanks for the patch @Melissa-Goon ! To expand on what @PratikPB2123 already said: a patch should contain either functional changes (as in, change the functionality of Blender) or non-functional changes (like cleaning up formatting of the code, doing refactors of the code that don't change its functionality, etc). Mixing both in the same patch is something that's not allowed here, as it makes it much harder to later look at the history of a file and understand what happened. You can run `make format` to let the auto-formatter do its work, and/or configure your editor for auto-formatting with Clang-Format. You can read more about this in the [style guide](https://wiki.blender.org/wiki/Style_Guide/C_Cpp).

Thank you for the feedback, I'll get on it asap!

Hi, could you update the PR with main? action_select.c file is now moved to c++, see: e858be84fa

For updating the PR, refer this wiki page

Hi, could you update the PR with main? `action_select.c` file is now moved to c++, see: e858be84fa7ea438006bc2e174f537ad92a3eda4 For updating the PR, refer this [wiki page](https://wiki.blender.org/wiki/Tools/Pull_Requests#Workflow:~:text=Update%20a%20Pull%20Request)

Hi, thanks for updating. Now the undo step is not created when deselecting channel/keyframes with left click. Apart from this issue, change looks good and harmless.

 @ -1748,3 +1748,3 @@
     /* reset selection mode for next steps */
     select_mode = SELECT_ADD;

 @ -1759,1 +1759,3 @@
       /* If nothing selected, return OPERATOR_CANCELLED.*/
       if (!found && ale == NULL) {

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #94080: clicking empty space in timeline creates undo step #105913

Reviewers