WIP: Surface-Deform-GP-Modifier-Blender-v3.5 #105935
Draft
Elisabetta Abbattista
wants to merge 40 commits from
When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
bettiabba/blender:Surface-Deform-GP-Modifier-Blender-v3.5
into blender-v3.5-release
pull from: bettiabba/blender:Surface-Deform-GP-Modifier-Blender-v3.5
merge into: blender:blender-v3.5-release
blender:main
blender:asset-browser-frontend-split
blender:blender-v3.3-release
blender:blender-v3.6-release
blender:universal-scene-description
blender:temp-sculpt-dyntopo
blender:brush-assets-project
blender:asset-shelf
blender:anim/armature-drawing-refactor-3
blender:temp-sculpt-dyntopo-hive-alloc
blender:tmp-usd-python-mtl
blender:tmp-usd-3.6
blender:blender-v3.5-release
blender:blender-projects-basics
blender:blender-v2.93-release
blender:temp-sculpt-attr-api
blender:realtime-clock
blender:sculpt-dev
blender:gpencil-next
blender:bevelv2
blender:microfacet_hair
blender:xr-dev
blender:principled-v2
When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Reviewers
Request review
No reviewers
Labels
Clear labels
This issue affects/is about backward or forward compatibility
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Apply labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
This issue affects/is about backward or forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
13 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#105935
Reference in New Issue
There is no content yet.
Delete Branch "bettiabba/blender:Surface-Deform-GP-Modifier-Blender-v3.5"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Surface Deform Grease Pencil Modifier for Blender 3.5
Updated video: https://youtu.be/HOV3CVPtops
First video: https://www.youtube.com/watch?v=fiS-5CTulRM
#100301
@blender-bot package
Package build started. Download here when ready.
Is there a 3.5 windows version available? I didn't found one.
This failed to build on Windows, there are some errors (and warnings) to fix:
https://builder.blender.org/admin/#/builders/133/builds/726/steps/6/logs/stdio
Hello, thanks for the link. I am currently working on linux but it can happen that the windows compiler throws different errors. I just committed a possible fix, how do I tell the bot to try building again?
a66618d80d
to35eb9db6e5
Builds can only be started by developers with write access to the Blender repository. I'll start it:
@blender-bot package
Package build started. Download here when ready.
Thanks! Looks like this time it worked.
@bettiabba Fantastic stuff!
It is currently crashing on opening files saved by this build with a bind.
To reproduce try to open the attached file.
@bettiabba Just Noticed it also crashes on Unbind
@blender-bot package
Package build started. Download here when ready.
Try several times, but I don't get you to blind surface to the greasepencil.
Ehm, It's the other way around.
@blender-bot package
Package build started. Download here when ready.
Only blender organization members with write access can start builds. See documentation for details.
Only blender organization members with write access can start builds. See documentation for details.
@blender-bot package
Package build started. Download here when ready.
icappello requested I take a look at the latest build since I've expressed interest in this functionality before. Here are my findings after giving it a spin. I would like to keep testing as things progress but it would be nice if going forward commits could mention which issues are fixed so I can focus my effort.
CRASH: pressing “Unbind All” while the modifier is not bound to a mesh will crash blender.
Steps: 1) Press Bind all once 2) press Unbind all twice
CRASH: perform undo after performing bind. This only happens if you deselect the GP object before hand
Steps: 1) add modifier to GP object and bind to mesh object 2) deselect GP object 3) Perform undo
CRASH: Re-open a file that contains a GP surface deform modifier that has been bound. If its present but not bound it will not crash on opening.
Steps: 1) save blend with GP surface deform modifier that is bound 2) Try to re-open that blend
CRASH: Bind to a skinned mesh where the armature has a keyframe will crash. This only happens when at least one keyframe is present on the armature. If there are no keyframes the binding process will work fine.
Steps: 1) create a simple mesh and make it so an armature deforms it 2) set a keyframe on the bones in pose mode 3) try to bind a GP object to the mesh
GENERAL: undo seems incredibly unstable
GENERAL: The buttons "Bind this frame" and "Unbind this frame" seem studio related. Apart from me not knowing what they do exactly perhaps its best to remove that and go for feature parity first?
If you want this modifier to only be active during certain frames there are other methods for that. The original surface deform has a strength slider for example which you can simply animate. You can also animate the modifier itself being active or not. That sounds more intuitive and more in line with how blender does things (to me).
UI: The buttons "Bind all" and "Unbind all" don’t tell me what the status of the modifier is. Is it now already bound or not? With the existing SD modifier one button is used and the text changes to signify what state the modifier is in. (i.e. it shows "unbind" when the status is bound and "bind" when the status is unbound)
FEATURE: all GP modifiers have an influence panel so you can limit the influence of the modifier. It would be very useful if the GP surface deform modifier offered the same because otherwise your forced to break apart your GP objects.
Currently normal objects do not receive new modifiers, as they can be easily recreated with geometry nodes.
There are also plans for Grease Pencil to be introduced in geometry node as a new component.
Are these plans consistent with this modifier?
EDIT: Just wondering if this has been discussed before? I could only find discussions from 9 months ago...
@blender-bot package
Package build started. Download here when ready.
@ -0,0 +1,33 @@
{
I think this file should not have been committed to the branch. It definitely should not be in the PR.
There is no windows build of the latest version. I'd love to test the latest fixes but I cannot until a new windows build becomes available.
There is:
https://builder.blender.org/download/patch/blender-3.5.0-candidate+main-PR105935.0c699f63eed3-windows.amd64-release.zip
No. There isn't. That build is from the 9th of may. I have already supplied feedback for that build. The latest commit was done on the 17th of may.
Its clearly stated in the name as well of the link you supplied me:
blender-3.5.0-candidate+main-PR105935.
0c699f63ee
-windows.amd64-release.zipThat refers to this commit made on the 9th of may:
0c699f63ee
@blender-bot package windows
Package build started. Download here when ready.
@jwvdronkelaar you're right. Kicked the buildbot again.
@blender-bot package windows
Package build started. Download here when ready.
@blender-bot package macos
Package build started. Download here when ready.
Looks like the Mac builds completed successfully but the Windows build didn't make it, still at May 19.
@blender-bot package
Package build started. Download here when ready.
@blender-bot package
Package build started. Download here when ready.
@blender-bot package
Package build started. Download here when ready.
@blender-bot package
Package build started. Download here when ready.
@blender-bot package
Package build started. Download here when ready.
@blender-bot package
Package build started. Download here when ready.
@blender-bot package macos
Package build started. Download here when ready.