Clear active flag of GPencil layer when deselecting #106116

Pratik Borhade · 2023-03-24T18:07:44+01:00

Pratik Borhade commented

2023-03-24 18:07:44 +01:00

Active flag of Gpencil channel is not cleared when deselecting or
selecting channels of other types. This is causing problem for #104565

Active flag of Gpencil channel is not cleared when deselecting or selecting channels of other types. This is causing problem for #104565

Pratik Borhade added 1 commit 2023-03-24 18:07:56 +01:00

793272a0d7 Clear active flag of GPencil layer when deselecting

Active flag of Gpencil channel is not cleared when deselecting or
selecting channels of other types. This is causing problem for #104565

Pratik Borhade requested review from Sybren A. Stüvel 2023-03-24 18:08:16 +01:00

Sybren A. Stüvel added the

labels 2023-03-27 15:55:05 +02:00

Sybren A. Stüvel requested review from Amélie Fondevilla 2023-03-27 15:55:13 +02:00

Amélie Fondevilla commented

2023-03-29 12:34:16 +02:00

Hi, I'm summing up here what was discussed in the chat.

It seems like this patch has important consequences on the grease pencil workflow : clicking on any non grease pencil channel in the dopesheet would result in all of the grease pencil objects having no active layer.
This is a problem, because all grease pencil object always need to have an active layer to draw on. Deselecting channels in the dopesheet should not change the active layer of the grease pencil objects.

So I think we've got to find another way of dealing with this.

Hi, I'm summing up here what was discussed in the chat. It seems like this patch has important consequences on the grease pencil workflow : clicking on any non grease pencil channel in the dopesheet would result in all of the grease pencil objects having no active layer. This is a problem, because all grease pencil object always need to have an active layer to draw on. Deselecting channels in the dopesheet should not change the active layer of the grease pencil objects. So I think we've got to find another way of dealing with this.

👍 1

Pratik Borhade commented

2023-03-29 15:36:58 +02:00

In further discussion, we came up with two possible solutions

Create a new flag GP_CHANNEL_ACTIVE to separate "active channel" and "active layer" of GPencil
Introduce a new pointer variable (active/active_index) that will reference the active channel of dopesheet

In further discussion, we came up with two possible solutions - Create a new flag `GP_CHANNEL_ACTIVE` to separate "active channel" and "active layer" of GPencil - Introduce a new pointer variable (`active`/`active_index`) that will reference the active channel of dopesheet

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Clear active flag of GPencil layer when deselecting #106116

Pull request closed