WIP UI: Adjustable Color Picker Size #106135

Closed
Harley Acheson wants to merge 4 commits from Harley/blender:PickerSize into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Allows user preference for the size of the color picker.


I have read some grumblings that our color picker is too small, and starting working on making the size a user preference. Since playing with this though I am now firmly in the "color picker is too small" camp.

Once applied this PR allows changing the picker size by dragging a little widget at the bottom right:

image

Allows user preference for the size of the color picker. --- I have read some grumblings that our color picker is too small, and starting working on making the size a user preference. Since playing with this though I am now firmly in the "color picker is too small" camp. Once applied this PR allows changing the picker size by dragging a little widget at the bottom right: ![image](/attachments/242bde19-7137-4d0f-9bb5-5c1dadd7b41c)
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR106135) when ready.
Harley Acheson force-pushed PickerSize from 20876de434 to 9765af95b3 2023-03-25 19:47:15 +01:00 Compare
Hans Goudey added this to the User Interface project 2023-03-25 22:02:18 +01:00
Harley Acheson force-pushed PickerSize from 9765af95b3 to 000499ef49 2023-03-26 18:52:48 +02:00 Compare
Harley Acheson force-pushed PickerSize from 000499ef49 to b90a9f761f 2023-03-26 19:33:03 +02:00 Compare
Harley Acheson requested review from Julian Eisel 2023-03-28 22:37:11 +02:00
Harley Acheson force-pushed PickerSize from b90a9f761f to 711350c931 2023-05-18 00:05:43 +02:00 Compare
Harley Acheson requested review from Pablo Vazquez 2023-06-30 17:51:26 +02:00
Member

Hi,

Thanks for the patch, I also think the current default is a bit on the small side, but adding a new preference for this seems too much.

How about making the color picker resizable (on a range like the one you tried, 150-400), and store that during the session or even in the preferences but not exposed.

Quick mockups

Using a bar on the top:
image

Using the UI List draggable widget:
image

To sum up:

  • Set the default size of the picker to 200, we all agree the current 170 is small.
  • Add a resize widget on the top the picker, dragging it up/down resizes the picker keeping the aspect ratio.
  • Store that picker size in the current session, so every time the picker is open it uses the previously set size.
Hi, Thanks for the patch, I also think the current default is a bit on the small side, but adding a new preference for this seems too much. How about making the color picker resizable (on a range like the one you tried, 150-400), and store that during the session or even in the preferences but not exposed. ### Quick mockups Using a bar on the top: ![image](/attachments/982cbe52-a6ec-4072-8794-4aa24573b41c) Using the UI List draggable widget: ![image](/attachments/223ba283-d9a3-4aa6-b34c-04c3b82b265a) To sum up: * Set the default size of the picker to 200, we all agree the current 170 is small. * Add a resize widget on the top the picker, dragging it up/down resizes the picker keeping the aspect ratio. * Store that picker size in the current session, so every time the picker is open it uses the previously set size.
Author
Member

To sum up:

  • Set the default size of the picker to 200, we all agree the current 170 is small.
  • Add a resize widget on the top the picker, dragging it up/down resizes the picker keeping the aspect ratio.
  • Store that picker size in the current session, so every time the picker is open it uses the previously set size.

Yes, this does sound great.

Although when I have looked at this (and similar) I was not able to figure out how to have a block like this refresh in this way (completely redrawn so that it can be a different width).

So easy to add a resizing gripper and have the dragging of it change the size of the colorpicker for the next time it is drawn, but unable to have it update its width while dragging the resizing gripper. Will keep investigating, but this is where I get stuck.

> To sum up: > * Set the default size of the picker to 200, we all agree the current 170 is small. > * Add a resize widget on the top the picker, dragging it up/down resizes the picker keeping the aspect ratio. > * Store that picker size in the current session, so every time the picker is open it uses the previously set size. Yes, this does sound great. Although when I have looked at this (and similar) I was not able to figure out how to have a block like this refresh in this way (completely redrawn so that it can be a different width). So easy to add a resizing gripper and have the dragging of it change the size of the colorpicker for the **next time it is drawn**, but unable to have it update its width **while dragging** the resizing gripper. Will keep investigating, but this is where I get stuck.
Member

easy to have the dragging of it change the size of the colorpicker for the next time it is drawn, but unable to have it update its width while dragging the resizing gripper.

I can live with it updating on release, but since we don't it anywhere else in the UI it'd look odd. Maybe @JulianEisel knows a trick to update the widget as it's resized?

> easy to have the dragging of it change the size of the colorpicker for the **next time it is drawn**, but unable to have it update its width **while dragging** the resizing gripper. I can live with it updating on release, but since we don't it anywhere else in the UI it'd look odd. Maybe @JulianEisel knows a trick to update the widget as it's resized?
Harley Acheson force-pushed PickerSize from 711350c931 to b13ebf662a 2023-07-06 21:05:20 +02:00 Compare
Harley Acheson changed title from UI: Adjustable Color Picker Size to WIP UI: Adjustable Color Picker Size 2023-07-06 21:05:56 +02:00
Author
Member

@pablovazquez

I have it live updating now, currently with a grabber widget at the bottom-right (could go somewhere else but here it does not take away any real estate). Works well enough for testing anyway. It isn't perfect but is simple enough that maybe this could be enough for others to give help or hints to make it better.

@pablovazquez I have it live updating now, currently with a grabber widget at the bottom-right (could go somewhere else but here it does not take away any real estate). Works well enough for testing anyway. It isn't perfect but is simple enough that maybe this could be enough for others to give help or hints to make it better.
Harley Acheson added 2 commits 2023-07-15 00:43:29 +02:00
Harley Acheson added 1 commit 2023-07-15 00:44:52 +02:00
First-time contributor

I'd +1 Pablo's suggestion of putting it at the top so that it looks like it will resize rather than grab. If that happens though, it might be helpful to flip it to the bottom when the picker is opened below the input. Having the mouse roughly follow the transform while the opposite side stays anchored to the input like that would feel more intuitive.

I'd also +1 saving it to preferences even if not exposed, so we won't need to change it back every session.

I'd +1 Pablo's suggestion of putting it at the top so that it looks like it will resize rather than grab. If that happens though, it might be helpful to flip it to the bottom when the picker is opened below the input. Having the mouse roughly follow the transform while the opposite side stays anchored to the input like that would feel more intuitive. I'd also +1 saving it to preferences even if not exposed, so we won't need to change it back every session.
Author
Member

@JonathanLampel-4

I did initially want the gripper at the top but then ran into issues when the color picker type was not a round one. Further I have (so far) had little luck having this live resize by dragging with the mouse. Our current design isn't really made with type of interaction in mind.

We talked about this today and are probably going to start with a stop-gap solution of just increasing the size of the picker for now - #111153 - and possibly revisit this later. We want to improve this for 4.0 and can't wait for me to figure out the live resizing.

This PR can remain though, in case someone else wants to take it up.

> @JonathanLampel-4 I did initially want the gripper at the top but then ran into issues when the color picker type was not a round one. Further I have (so far) had little luck having this live resize by dragging with the mouse. Our current design isn't really made with type of interaction in mind. We talked about this today and are probably going to start with a stop-gap solution of just increasing the size of the picker for now - #111153 - and possibly revisit this later. We want to improve this for 4.0 and can't wait for me to figure out the live resizing. This PR can remain though, in case someone else wants to take it up.
Author
Member

Closing. We just made these a bit bigger with #111153

Closing. We just made these a bit bigger with #111153
Harley Acheson closed this pull request 2023-11-10 18:38:29 +01:00

Pull request closed

Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106135
No description provided.