blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 746 Projects 19 Wiki Activity

Show FCurve modifier toggle widget as 'inactive' when there are no modifiers #106214

Merged
Sybren A. Stüvel merged 5 commits from dr.sybren/blender:anim/fcurve-modifier-toggle-visibility into main 2023-09-14 15:03:43 +02:00
Conversation 10 Commits 5 Files Changed 1 +16
Sybren A. Stüvel commented 2023-03-28 11:26:59 +02:00
Member
Copy Link

In the animation editors, show the FCurve Modifier toggle widget (the wrench) as 'inactive' when the FCurve has no modifiers on it.

image

The above image shows, from top to bottom, the following cases:

  • Modifiers enabled, but no modifiers present.
  • Modifiers enabled and present.
  • Modifiers disabled and present.
  • Modifiers disabled, but no modifiers present.

Note 1: this PR affects all channel lists, so also the various Dopesheet modes and the Timeline.

Note 2: this PR only affects FCurves, and not FCurve Groups. This is also something to discuss here, whether FCurve Groups should get the same treatment (only showing the wrench when one or more contained FCurves have modifiers).

Note 3: In an earlier version of this PR, the wrench icon would be completely hidden when the FCurve had no modifier. This was discussed in a module meeting and decided that making it 'inactive' would be better.

In the animation editors, show the FCurve Modifier toggle widget (the wrench) as 'inactive' when the FCurve has no modifiers on it. ![image](/attachments/f4f23ca6-e24d-40a7-82cc-c0372300c7ec) The above image shows, from top to bottom, the following cases: - Modifiers enabled, but no modifiers present. - Modifiers enabled and present. - Modifiers disabled and present. - Modifiers disabled, but no modifiers present. **Note 1:** this PR affects all channel lists, so also the various Dopesheet modes and the Timeline. **Note 2:** this PR only affects FCurves, and not FCurve *Groups*. This is also something to discuss here, whether FCurve Groups should get the same treatment (only showing the wrench when one or more contained FCurves have modifiers). **Note 3:** In an earlier version of this PR, the wrench icon would be completely hidden when the FCurve had no modifier. This was discussed in a [module meeting](https://devtalk.blender.org/t/2023-06-08-animation-rigging-module-meeting/29793) and decided that making it 'inactive' would be better.
image.png
6.5 KiB
🎉 2
Sybren A. Stüvel added the
Module
Animation & Rigging
 label 2023-03-28 11:26:59 +02:00
Sybren A. Stüvel added 1 commit 2023-03-28 11:27:16 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
fa61aca0cc Anim: only show FCurve modifier toggle widget when there are modifiers 
In the animation editors, only show the FCurve Modifier toggle widget
(the wrench) when the FCurve actually has one or more modifiers on it.

This simplifies the UI, by only showing the widget when it's relevant.

A possible downside is that now it's no longer possible to disable
modifiers before adding them.
Sybren A. Stüvel requested review from Pierrick PICAUT 2023-03-28 11:33:58 +02:00
Sybren A. Stüvel added this to the Animation & Rigging project 2023-03-28 11:34:11 +02:00
Pierrick PICAUT commented 2023-03-28 11:42:51 +02:00
Member
Copy Link

Is it relevant to keep the icon next to the bone name when there is not modifier at all?
EG. FK-Shoulder.L

Is it relevant to keep the icon next to the bone name when there is not modifier at all? EG. FK-Shoulder.L
image.png
41 KiB
image.png
Pierrick PICAUT commented 2023-03-28 11:48:13 +02:00
Member
Copy Link

BTW, I'm pretty new to this so if there is anything I need to do for you to get feedback, just let me know.

BTW, I'm pretty new to this so if there is anything I need to do for you to get feedback, just let me know.
Pratik Borhade commented 2023-03-28 12:04:40 +02:00
Member
Copy Link

@P2design: Is it relevant to keep the icon next to the bone name when there is not modifier at all?

@dr.sybren: Note 2: not FCurve Groups. This is also something to discuss here

@P2design , refer "Note 2" :)
PR is only affecting channels (ex: "X location") and not groups ("FK-Shoulder.L")

> @P2design: Is it relevant to keep the icon next to the bone name when there is not modifier at all? > @dr.sybren: **Note 2:** not FCurve Groups. This is also something to discuss here @P2design , refer "Note 2" :) PR is only affecting channels (ex: "X location") and not groups ("FK-Shoulder.L")
Sybren A. Stüvel commented 2023-03-28 12:16:33 +02:00
Author
Member
Copy Link

@blender-bot package

Is it relevant to keep the icon next to the bone name when there is not modifier at all?

yeah, that's the bone group thing.

@blender-bot package > Is it relevant to keep the icon next to the bone name when there is not modifier at all? yeah, that's the bone group thing.
Blender Bot commented 2023-03-28 12:16:36 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR106214) when ready.
Pierrick PICAUT commented 2023-03-28 14:08:10 +02:00
Member
Copy Link

hi,

There is a little bug @dr.sybren
if you have a modifier on 2 different channels.
You disable one of the modifer, it will also disable the master wrench icon near the bone name. It makes sense as it allows to know there might be a disabled modifier in that bone.

But if you re-enable the channel modifier, the bone modifier still appear muted while the modifier is influencing the bone.

The same happens with a single modifier, if you disable/enable on the channel, it won't update the "master" icon

This is a little bug.

Then, I do feel that at some point will need to add a way to tell :

  • Is there a modifier
  • Is it enabled/disabled
hi, There is a little bug @dr.sybren if you have a modifier on 2 different channels. You disable one of the modifer, it will also disable the master wrench icon near the bone name. It makes sense as it allows to know there might be a disabled modifier in that bone. But if you re-enable the channel modifier, the bone modifier still appear muted while the modifier is influencing the bone. The same happens with a single modifier, if you disable/enable on the channel, it won't update the "master" icon This is a little bug. Then, I do feel that at some point will need to add a way to tell : - Is there a modifier - Is it enabled/disabled
Sybren A. Stüvel commented 2023-03-28 16:58:57 +02:00
Author
Member
Copy Link

Oh yes, this is a completely different switch from the individual modifier enable/disable buttons. This PR doesn't change what the wrench icon does, it just decides to not show it when there is no modifier.

Oh yes, this is a completely different switch from the individual modifier enable/disable buttons. This PR doesn't change what the wrench icon does, it just decides to not show it when there is no modifier.
Sybren A. Stüvel added 1 commit 2023-06-12 15:00:41 +02:00
Sybren A. Stüvel changed title from Only show FCurve modifier toggle widget when there are modifiers to Show FCurve modifier toggle widget as 'inactive' when there are no modifiers 2023-06-12 15:17:36 +02:00
Sybren A. Stüvel added 1 commit 2023-06-12 15:34:28 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
40d0ed8d80 Feedback from last animation module meeting
Sybren A. Stüvel commented 2023-06-12 16:29:52 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-06-12 16:29:55 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR106214) when ready.
Sybren A. Stüvel added 2 commits 2023-09-14 14:54:21 +02:00
Sybren A. Stüvel commented 2023-09-14 15:02:18 +02:00
Author
Member
Copy Link

In the 2023-06-08 module meeting Nathan mentioned some confusion about what the different icon variations (grey vs white, and filled vs hollow) mean. Since this PR uses the existing icon semantics, changing that would be for a different PR. Because that was the only remark during the meetings where this PR was discussed, I'll just land it as-is.

In [the 2023-06-08 module meeting](https://devtalk.blender.org/t/2023-06-08-animation-rigging-module-meeting/29793) Nathan mentioned some confusion about what the different icon variations (grey vs white, and filled vs hollow) mean. Since this PR uses the existing icon semantics, changing that would be for a different PR. Because that was the only remark during the meetings where this PR was discussed, I'll just land it as-is.
Sybren A. Stüvel merged commit 456d65b00a into main 2023-09-14 15:03:43 +02:00
Sybren A. Stüvel deleted branch anim/fcurve-modifier-toggle-visibility 2023-09-14 15:03:44 +02:00
Sybren A. Stüvel removed this from the Animation & Rigging project 2023-09-14 15:05:11 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pierrick PICAUT
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106214
No description provided.
Delete Branch "dr.sybren/blender:anim/fcurve-modifier-toggle-visibility"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?