Show FCurve modifier toggle widget as 'inactive' when there are no modifiers #106214

In the animation editors, show the FCurve Modifier toggle widget (the wrench) as 'inactive' when the FCurve has no modifiers on it.

The above image shows, from top to bottom, the following cases:

Modifiers enabled, but no modifiers present.
Modifiers enabled and present.
Modifiers disabled and present.
Modifiers disabled, but no modifiers present.

Note 1: this PR affects all channel lists, so also the various Dopesheet modes and the Timeline.

Note 2: this PR only affects FCurves, and not FCurve Groups. This is also something to discuss here, whether FCurve Groups should get the same treatment (only showing the wrench when one or more contained FCurves have modifiers).

Note 3: In an earlier version of this PR, the wrench icon would be completely hidden when the FCurve had no modifier. This was discussed in a module meeting and decided that making it 'inactive' would be better.

In the animation editors, show the FCurve Modifier toggle widget (the wrench) as 'inactive' when the FCurve has no modifiers on it. ![image](/attachments/f4f23ca6-e24d-40a7-82cc-c0372300c7ec) The above image shows, from top to bottom, the following cases: - Modifiers enabled, but no modifiers present. - Modifiers enabled and present. - Modifiers disabled and present. - Modifiers disabled, but no modifiers present. **Note 1:** this PR affects all channel lists, so also the various Dopesheet modes and the Timeline. **Note 2:** this PR only affects FCurves, and not FCurve *Groups*. This is also something to discuss here, whether FCurve Groups should get the same treatment (only showing the wrench when one or more contained FCurves have modifiers). **Note 3:** In an earlier version of this PR, the wrench icon would be completely hidden when the FCurve had no modifier. This was discussed in a [module meeting](https://devtalk.blender.org/t/2023-06-08-animation-rigging-module-meeting/29793) and decided that making it 'inactive' would be better.

image.png

6.5 KiB

Is it relevant to keep the icon next to the bone name when there is not modifier at all?
EG. FK-Shoulder.L

Is it relevant to keep the icon next to the bone name when there is not modifier at all? EG. FK-Shoulder.L

image.png

41 KiB

BTW, I'm pretty new to this so if there is anything I need to do for you to get feedback, just let me know.

@P2design: Is it relevant to keep the icon next to the bone name when there is not modifier at all?

@dr.sybren: Note 2: not FCurve Groups. This is also something to discuss here

@P2design , refer "Note 2" :)
PR is only affecting channels (ex: "X location") and not groups ("FK-Shoulder.L")

> @P2design: Is it relevant to keep the icon next to the bone name when there is not modifier at all? > @dr.sybren: **Note 2:** not FCurve Groups. This is also something to discuss here @P2design , refer "Note 2" :) PR is only affecting channels (ex: "X location") and not groups ("FK-Shoulder.L")

@blender-bot package

Is it relevant to keep the icon next to the bone name when there is not modifier at all?

yeah, that's the bone group thing.

@blender-bot package > Is it relevant to keep the icon next to the bone name when there is not modifier at all? yeah, that's the bone group thing.

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR106214) when ready.

hi,

There is a little bug @dr.sybren
if you have a modifier on 2 different channels.
You disable one of the modifer, it will also disable the master wrench icon near the bone name. It makes sense as it allows to know there might be a disabled modifier in that bone.

But if you re-enable the channel modifier, the bone modifier still appear muted while the modifier is influencing the bone.

The same happens with a single modifier, if you disable/enable on the channel, it won't update the "master" icon

This is a little bug.

Then, I do feel that at some point will need to add a way to tell :

Is there a modifier
Is it enabled/disabled

hi, There is a little bug @dr.sybren if you have a modifier on 2 different channels. You disable one of the modifer, it will also disable the master wrench icon near the bone name. It makes sense as it allows to know there might be a disabled modifier in that bone. But if you re-enable the channel modifier, the bone modifier still appear muted while the modifier is influencing the bone. The same happens with a single modifier, if you disable/enable on the channel, it won't update the "master" icon This is a little bug. Then, I do feel that at some point will need to add a way to tell : - Is there a modifier - Is it enabled/disabled

Oh yes, this is a completely different switch from the individual modifier enable/disable buttons. This PR doesn't change what the wrench icon does, it just decides to not show it when there is no modifier.

@blender-bot package

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR106214) when ready.

In the 2023-06-08 module meeting Nathan mentioned some confusion about what the different icon variations (grey vs white, and filled vs hollow) mean. Since this PR uses the existing icon semantics, changing that would be for a different PR. Because that was the only remark during the meetings where this PR was discussed, I'll just land it as-is.

In [the 2023-06-08 module meeting](https://devtalk.blender.org/t/2023-06-08-animation-rigging-module-meeting/29793) Nathan mentioned some confusion about what the different icon variations (grey vs white, and filled vs hollow) mean. Since this PR uses the existing icon semantics, changing that would be for a different PR. Because that was the only remark during the meetings where this PR was discussed, I'll just land it as-is.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Show FCurve modifier toggle widget as 'inactive' when there are no modifiers #106214

Reviewers