Cycles: Avoid overhead from RNA when extracting mesh data #106275

Merged

Hans Goudey merged 14 commits from HooglyBoogly/blender:cycles-mesh-cleanup into main

2023-04-03 17:05:10 +02:00

Hans Goudey commented

2023-03-29 19:18:32 +02:00

Member

Use raw Blender structs and mesh data rather than using the RNA API.
There isn't any benefit from using the RNA when Cycles is compiled
with Blender anyway.

This gives a significant improvement in performance when ingesting
meshes, since using the RNA API rather than random access with
pointers was very expensive.

Some tests of the runtime of the create_mesh function (in seconds):

	Before	After
Grid	0.66	0.11
Many realized cubes	2.60	0.48
Large curve to mesh setup	4.18	1.14

Here is a profile from before the change showing the overhead
from function calls and string lookups:

Also change to resizing the arrays and filling them by index rather
than appending. This makes the parallel aspect of the logic clearer,
and makes the loops easier to parallelize in the future, and makes
it easier to have a performance benefit when an attribute like
sharp_face doesn't exist.

Use raw Blender structs and mesh data rather than using the RNA API. There isn't any benefit from using the RNA when Cycles is compiled with Blender anyway. This gives a significant improvement in performance when ingesting meshes, since using the RNA API rather than random access with pointers was very expensive. Some tests of the runtime of the `create_mesh` function (in seconds): | | Before | After | | ------------------------- | ------ | ----- | | Grid | 0.66 | 0.11 | | Many realized cubes | 2.60 | 0.48 | | Large curve to mesh setup | 4.18 | 1.14 | Here is a profile from before the change showing the overhead from function calls and string lookups: ![image](/attachments/b5abc284-02d6-411c-927d-a811a8371902) Also change to resizing the arrays and filling them by index rather than appending. This makes the parallel aspect of the logic clearer, and makes the loops easier to parallelize in the future, and makes it easier to have a performance benefit when an attribute like `sharp_face` doesn't exist.

93 KiB

❤️ 2 🎉 1 🚀 6

Hans Goudey added 5 commits 2023-03-29 19:18:45 +02:00

d7ee9cca52 Progess

1f6ec903d2 Merge branch 'main' into cycles-mesh-cleanup

f4d9b6fa31 Mesh: Add RNA collection property for corner normals

74a31fb62c Progress

86c8845726 Cleanup

Hans Goudey added this to the Render & Cycles project 2023-03-29 19:21:18 +02:00

Hans Goudey added the

Render & Cycles

labels 2023-03-29 19:21:33 +02:00

Hans Goudey changed title from ~~Cycles: Avoid overhead from RNA when extracting mesh data~~ to WIP: Cycles: Avoid overhead from RNA when extracting mesh data

2023-03-29 19:21:38 +02:00

Lorenzo Giannini commented

2023-03-29 20:21:23 +02:00

First-time contributor

:)

:)

Hans Goudey added 2 commits 2023-03-30 17:29:52 +02:00

819b6b1953 Merge branch 'main' into cycles-mesh-cleanup

5727218765 Fix missing corner verts copy

Hans Goudey changed title from ~~WIP: Cycles: Avoid overhead from RNA when extracting mesh data~~ to Cycles: Avoid overhead from RNA when extracting mesh data

2023-03-30 20:14:14 +02:00

Hans Goudey added 2 commits 2023-03-30 20:14:16 +02:00

73f83be7bf Merge branch 'main' into cycles-mesh-cleanup

buildbot/vexp-code-patch-coordinator Build done. Details

f6c690511f Fix

Hans Goudey requested review from Brecht Van Lommel 2023-03-30 20:15:28 +02:00

Hans Goudey commented

2023-03-30 20:46:36 +02:00

Author

Member

@blender-bot build

@blender-bot build

Hans Goudey added 1 commit 2023-03-31 13:52:02 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

522680ca28 Merge branch 'main' into cycles-mesh-cleanup

Hans Goudey commented

2023-03-31 13:52:08 +02:00

Author

Member

@blender-bot build macos

@blender-bot build macos

Hans Goudey force-pushed cycles-mesh-cleanup from 3f04908084 to 522680ca28

2023-03-31 14:15:50 +02:00

Compare

Brecht Van Lommel requested changes 2023-04-03 16:08:31 +02:00

intern/cycles/blender/mesh.cpp Outdated

						
				@ -412,43 +412,43 @@ static void attr_create_generic(Scene *scene,

				    switch (b_data_type) {

				      case BL::Attribute::data_type_FLOAT: {

				        BL::FloatAttribute b_float_attribute{b_attribute};

				        const float *src = static_cast<const float *>(b_float_attribute.data[0].ptr.data);

Brecht Van Lommel commented

2023-04-03 11:09:40 +02:00

Owner

Is this safe when the number of elements is 0? It seems fragile regardless, seems better to use:

if (b_float_attribute.data.length()) {
  const float *src = static_cast<const float *>(b_float_attribute.data[0].ptr.data);
  fill_generic_attribute(b_mesh, data, b_domain, subdivision, [&](int i) { return src[i]; });
}

Is this safe when the number of elements is 0? It seems fragile regardless, seems better to use: ``` if (b_float_attribute.data.length()) { const float *src = static_cast<const float *>(b_float_attribute.data[0].ptr.data); fill_generic_attribute(b_mesh, data, b_domain, subdivision, [&](int i) { return src[i]; }); } ```

HooglyBoogly marked this conversation as resolved

Hans Goudey added 3 commits 2023-04-03 16:46:23 +02:00

5ac4c003f5 Merge branch 'main' into cycles-mesh-cleanup

da276547d2 Add empty data checks in some places

ef49793adc Remove timer

Hans Goudey added 1 commit 2023-04-03 16:54:37 +02:00

824a1e575a Fix compile error from mistake in previous commit

Hans Goudey requested review from Brecht Van Lommel 2023-04-03 16:56:47 +02:00

Brecht Van Lommel approved these changes 2023-04-03 17:01:27 +02:00

Hans Goudey referenced this issue from a commit

2023-04-03 17:05:10 +02:00

Cycles: Avoid overhead from RNA when extracting mesh data

Hans Goudey merged commit 4bcd59d644 into main

2023-04-03 17:05:10 +02:00

Hans Goudey deleted branch cycles-mesh-cleanup

2023-04-03 17:05:11 +02:00

Brecht Van Lommel removed this from the Render & Cycles project 2023-05-24 19:05:21 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106275

No description provided.