Fix #106261: When geometry output is viewed the cycling operator picks wrong sockets. #106318

Merged
Lukas Tönne merged 1 commits from LukasTonne/blender:fix-data-socket-viewer-cycling into main 2023-03-30 16:57:09 +02:00
Member

The cycling method for the viewer connection starts searching from the next socket
after the last current connection. If a geometry socket is is the last connected
output this caused the method to jump to the next socket after the geometry,
potentially skipping over valid data sockets that are not viewed yet.

The solution is to ignore the geometry sockets in the cycling entirely and only
consider data sockets (i.e. non-geometry sockets).

The cycling method for the viewer connection starts searching from the next socket after the last current connection. If a geometry socket is is the last connected output this caused the method to jump to the next socket after the geometry, potentially skipping over valid data sockets that are not viewed yet. The solution is to ignore the geometry sockets in the cycling entirely and only consider data sockets (i.e. non-geometry sockets).
Lukas Tönne added the
Module
Nodes & Physics
label 2023-03-30 16:52:43 +02:00
Hans Goudey was assigned by Lukas Tönne 2023-03-30 16:52:43 +02:00
Lukas Tönne added 1 commit 2023-03-30 16:52:53 +02:00
a4d2c9a1aa Fix 106261: When geometry output is viewed the cycling operator picks wrong sockets.
The cycling method for the viewer connection starts searching from the next socket
after the last current connection. If a geometry socket is is the last connected
output this caused the method to jump to the next socket after the geometry,
potentially skipping over valid data sockets that are not viewed yet.

The solution is to ignore the geometry sockets in the cycling entirely and only
consider data sockets (i.e. non-geometry sockets).
Hans Goudey requested review from Hans Goudey 2023-03-30 16:53:54 +02:00
Hans Goudey removed their assignment 2023-03-30 16:54:00 +02:00
Lukas Tönne changed title from Fix 106261: When geometry output is viewed the cycling operator picks wrong sockets. to Fix #106261: When geometry output is viewed the cycling operator picks wrong sockets. 2023-03-30 16:56:05 +02:00
Hans Goudey approved these changes 2023-03-30 16:56:06 +02:00
Hans Goudey left a comment
Member

Looks reasonable, thanks.

For the commit title, this includes the # and fits withing the 72 char limit:
Fix #106261: Incorrect viewer socket cycling with geometry socket

Looks reasonable, thanks. For the commit title, this includes the `#` and fits withing the 72 char limit: `Fix #106261: Incorrect viewer socket cycling with geometry socket`
Lukas Tönne merged commit bdc3f1581d into main 2023-03-30 16:57:09 +02:00
Lukas Tönne deleted branch fix-data-socket-viewer-cycling 2023-03-30 16:57:10 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106318
No description provided.