Fix #106235: Use consistent order for multi-input socket links #106320
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#106320
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "mod_moder:fix_internal_link_drawing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Make indexing the same in all parts of the code:
Oh wait, I think I forgot that we need a fix for 3.4 and 3.5
Hmm, 3.4 isn't updated anymore, and this isn't a critical bug, it's just a visual thing. So I don't think it needs to be backported actually.
Then it's all right. I also now realized that it can be done a little more cleanly, so I'll update this.
Looks fine.
Am I missing something? Seems to me that it's the first input that's passed through, not the last.
Fix #106235: Fix drawing internal link as connected to last link in multi-input socketto Fix #106235: Refactoring: Consist directly linked links & multi input index & drawing index & evaluated indexProblems: maybe versioning is needed, not sure... Links from old sessions are reversed. But I'm not sure if it's fixable or serious.
Fix #106235: Refactoring: Consist directly linked links & multi input index & drawing index & evaluated indexto Refactoring: Consist Directly linked links & Multi-input index & Drawing order & Evaluated behaviorRefactoring: Consist Directly linked links & Multi-input index & Drawing order & Evaluated behaviorto Refactoring: Consist: Directly linked links & index & drawing order & evaluated behavior of multi-input linksNow yes, this is the first link.
Refactoring: Consist: Directly linked links & index & drawing order & evaluated behavior of multi-input linksto Refactoring: Geometry Node: Multi-input link indices directionRefactoring: Geometry Node: Multi-input link indices directionto Refactoring: Geometry Node: Multi-input socket links indices directionRefactoring: Geometry Node: Multi-input socket links indices directionto Fix: Enumerate links connected to multi-input socket in consist orderFix: Enumerate links connected to multi-input socket in consist orderto Fix #106235: Enumerate links connected to multi-input socket in consist orderFix #106235: Enumerate links connected to multi-input socket in consist orderto Fix #106235: Use consistent order for multi-input socket linksDoes this have any consequences for backwards or forwards compatibility?
I'll need to be rechecked. In theory, only the visual order of the links changes, but not how it works.
Yeah, this actually change order of inputs and now files, opened in 3.6, will look different.
Not sure how to fix this now. If we send this to 3.6, then the versioning should take into account all versions 4.0 and 4.1 before fixing them...
Closing this as it seems not worth the effort to reverse the order. The compatibility story is too annoying. We could rename the the
index
to asort_id
though internally. Also see8f36281787
.Pull request closed