Fix: Crash in install_linux_packages.py script #106461

bvpav · 2023-04-02T17:36:52+02:00

bvpav commented

2023-04-02 17:36:52 +02:00

There is a KeyError exception when the install_linux_packages.py build script is ran with --distro-id:

$ ./build_files/build_environment/install_linux_packages.py --distro-id arch
INFO:     Distribution identifier forced by user to arch.
Traceback (most recent call last):
  File "file:///blender/./build_files/build_environment/install_linux_packages.py", line 1656, in <module>
    main()
  File "file:///blender/./build_files/build_environment/install_linux_packages.py", line 1646, in main
    distro_package_installer = PackageInstaller(settings) if settings.show_deps else get_distro_package_installer(settings)
  File "file:///blender/./build_files/build_environment/install_linux_packages.py", line 1570, in get_distro_package_installer
    return DISTRO_IDS_INSTALLERS[get_distro(settings)](settings)
KeyError: None

This happens because the get_distro function returns None if the distribution ID is forced with the --distro-id option, when it should return the provided value.

There is a `KeyError` exception when the `install_linux_packages.py` build script is ran with `--distro-id`: ```console $ ./build_files/build_environment/install_linux_packages.py --distro-id arch INFO: Distribution identifier forced by user to arch. Traceback (most recent call last): File "file:///blender/./build_files/build_environment/install_linux_packages.py", line 1656, in <module> main() File "file:///blender/./build_files/build_environment/install_linux_packages.py", line 1646, in main distro_package_installer = PackageInstaller(settings) if settings.show_deps else get_distro_package_installer(settings) File "file:///blender/./build_files/build_environment/install_linux_packages.py", line 1570, in get_distro_package_installer return DISTRO_IDS_INSTALLERS[get_distro(settings)](settings) KeyError: None ``` This happens because the `get_distro` function returns `None` if the distribution ID is forced with the `--distro-id` option, when it should return the provided value.

bvpav added 1 commit 2023-04-02 17:37:04 +02:00

Fix: Crash in install_linux_packages.py script 310fbdb3aa

This fixes a KeyError exception when running `install_linux_packages.py`
with `--distro-id`. The exception was thrown, because of a bare return
in `get_distro`, which caused a dict to be indexed with `None`.

Brecht Van Lommel requested review from Bastien Montagne 2023-04-05 18:04:34 +02:00

Bastien Montagne approved these changes 2023-04-05 19:32:11 +02:00

Bastien Montagne commented

2023-04-05 19:33:26 +02:00

@bvpav thanks!

Can you please update your patch against latest main branch? That way we can merge it directly from the gitea webapp. ;)

@bvpav thanks! Can you please update your patch against latest main branch? That way we can merge it directly from the gitea webapp. ;)

bvpav added 1 commit 2023-04-10 10:51:14 +02:00

Merge branch 'main' into install-linux-packages-fix 111a646c69

bvpav commented

2023-04-10 10:57:26 +02:00

@mont29 of course!

Sorry for the wait :^)

@mont29 of course! Sorry for the wait :^)

Bastien Montagne merged commit 8dae058768 into main

2023-04-10 21:13:11 +02:00

Bastien Montagne referenced this issue from a commit

2023-04-10 21:13:11 +02:00

Fix: Crash in `install_linux_packages.py` script

Bastien Montagne deleted branch install-linux-packages-fix

2023-04-10 21:13:12 +02:00

Bastien Montagne commented

2023-04-10 21:15:20 +02:00

No problem, thanks for the update! :)

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: Crash in install_linux_packages.py script #106461

Fix: Crash in `install_linux_packages.py` script #106461