Fix #106422: Mesh Data Attributes Using tip_ for iface_ #106507

Merged
Harley Acheson merged 1 commits from Harley/blender:MeshDataTip into main 2023-04-03 20:55:34 +02:00
Member

pgettext_tip incorrectly imported as iface_ instead of importing
pgettext_iface. These leads to incorrectly translated attribute text
shown when the user elects to translate only tooltips.


Users can choose to select a translated language, but elect to only show translated strings for certain parts. When choosing only "Tooltips" we generally show the entire visible interface in English but only translate tooltips and other longer explanatory text. This is normally done to make it easier to follow along with online tutorials.

image

Unfortunately we have an error in properties_data_mesh.py where we import pgettext_tip as iface_, instead of pgettext_iface as iface_. This leads to showing translated text even though only "tooltip" translation is desired:

image

This just corrects that import so that we show these correctly:

image

pgettext_tip incorrectly imported as iface_ instead of importing pgettext_iface. These leads to incorrectly translated attribute text shown when the user elects to translate only tooltips. --- Users can choose to select a translated language, but elect to only show translated strings for certain parts. When choosing only "Tooltips" we generally show the entire visible interface in English but only translate tooltips and other longer explanatory text. This is normally done to make it easier to follow along with online tutorials. ![image](/attachments/232e28bd-b3f1-467b-91dd-4a6582d1cc8a) Unfortunately we have an error in `properties_data_mesh.py` where we import `pgettext_tip as iface_`, instead of `pgettext_iface as iface_`. This leads to showing translated text even though only "tooltip" translation is desired: ![image](/attachments/b59b5f9d-1042-423f-b682-6b646e6cdf03) This just corrects that import so that we show these correctly: ![image](/attachments/f189d05b-58b7-4d8a-b29b-22e4887169b7)
Harley Acheson added 1 commit 2023-04-03 20:51:15 +02:00
7a1373d0c0 Fix #106422: Mesh Data Attributes Using tip_ for iface_
pgettext_tip incorrectly imported as iface_ instead of importing
pgettext_iface. These leads to incorrectly translated attribute text
shown when the user select to translate only tooltips.
Hans Goudey approved these changes 2023-04-03 20:53:28 +02:00
Harley Acheson merged commit 14b112ef82 into main 2023-04-03 20:55:34 +02:00
Harley Acheson deleted branch MeshDataTip 2023-04-03 20:55:35 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106507
No description provided.