UI: Change the name of Invert nodes to Invert Color #106750

Merged

Daniel Salazar merged 2 commits from zanqdo/blender:rename-invert-node into main

2023-04-19 21:52:32 +02:00

Daniel Salazar commented

2023-04-10 02:03:17 +02:00

Member

The nodes for inverting a color are named simply Invert, which begs the question: invert what?

This patch changes the naming for the node in Shading, Texture and Compositing nodes to Invert Color

This matches the naming of other color dedicated nodes like Separate Color or Combine Color

The nodes for inverting a color are named simply *Invert*, which begs the question: invert what? ![image](/attachments/83ff645a-6a33-4b09-a317-fd18db2016f6) This patch changes the naming for the node in Shading, Texture and Compositing nodes to *Invert Color* ![image](/attachments/66536914-9422-46d9-af72-1e969bb151c9) This matches the naming of other color dedicated nodes like *Separate Color* or *Combine Color*

27 KiB

26 KiB

Daniel Salazar added 1 commit 2023-04-10 02:03:28 +02:00

3b0dcffbbf Change the name of Invert nodes to Invert Color

Daniel Salazar requested review from Pablo Vazquez 2023-04-10 02:04:10 +02:00

Daniel Salazar requested review from Hans Goudey 2023-04-10 02:04:10 +02:00

Daniel Salazar changed title from ~~WIP: Change the name of Invert nodes to Invert Color~~ to Change the name of Invert nodes to Invert Color

2023-04-10 02:05:06 +02:00

Daniel Salazar changed title from ~~Change the name of Invert nodes to Invert Color~~ to UI: Change the name of Invert nodes to Invert Color

2023-04-10 02:08:53 +02:00

Iliya Katushenock added the

Nodes & Physics

labels 2023-04-10 07:05:36 +02:00

Pablo Vazquez commented

2023-04-12 18:56:18 +02:00

Member

I think it makes sense, since we are only converting Color and the category is even of type color.

Could you please update to main? There seems to be a conflict.

I think it makes sense, since we are only converting Color and the category is even of type color. Could you please update to main? There seems to be a conflict.

Daniel Salazar added 1 commit 2023-04-13 00:16:26 +02:00

429bc4a5f3 Merge branch 'main' into rename-invert-node

Daniel Salazar commented

2023-04-13 00:32:23 +02:00

Author

Member

I think it makes sense, since we are only converting Color and the category is even of type color.

Could you please update to main? There seems to be a conflict.

Thank you, that's exactly my reasoning, specially since the existence of Separate Color and Combine Color. Imagine if they only said Separate and Combine.

Merge done!

> I think it makes sense, since we are only converting Color and the category is even of type color. > > Could you please update to main? There seems to be a conflict. Thank you, that's exactly my reasoning, specially since the existence of _Separate Color_ and _Combine Color_. Imagine if they only said _Separate_ and _Combine_. Merge done!

Pablo Vazquez commented

2023-04-13 11:32:31 +02:00

Member

Imagine if they only said Separate and Combine.

Well at some point if they are to become more generic like Mix, it'd make sense and just get the type from context. But in this case it's not generic so it makes sense to call it Invert Color.

> Imagine if they only said _Separate_ and _Combine_. Well at some point if they are to become more generic like `Mix`, it'd make sense and just get the type from context. But in this case it's not generic so it makes sense to call it `Invert Color`.

Daniel Salazar commented

2023-04-15 00:40:16 +02:00

Author

Member

@pablovazquez so can I get an approve?

@pablovazquez so can I get an approve?

Iliya Katushenock added this to the Nodes & Physics project 2023-04-15 10:23:13 +02:00

Hans Goudey approved these changes 2023-04-18 21:38:56 +02:00

Daniel Salazar commented

2023-04-19 00:40:09 +02:00

Author

Member

@pablovazquez your move. I can wait for the 4.0 branch if you prefer (as you hinted on the Blender Hoy stream)

@pablovazquez your move. I can wait for the 4.0 branch if you prefer (as you hinted on the Blender Hoy stream)

Pablo Vazquez commented

2023-04-19 12:48:04 +02:00

Member

@pablovazquez your move. I can wait for the 4.0 branch if you prefer (as you hinted on the Blender Hoy stream)

I think it is okay in this case, since there is only one node that starts with "Invert" anyway.

> @pablovazquez your move. I can wait for the 4.0 branch if you prefer (as you hinted on the Blender Hoy stream) I think it is okay in this case, since there is only one node that starts with "Invert" anyway.

Pablo Vazquez approved these changes 2023-04-19 12:48:15 +02:00

Daniel Salazar referenced this issue from a commit

2023-04-19 21:52:32 +02:00

UI: Change the name of Invert nodes to Invert Color

Daniel Salazar merged commit 9344deed89 into main

2023-04-19 21:52:32 +02:00

Daniel Salazar deleted branch rename-invert-node

2023-04-19 21:52:33 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106750

No description provided.