Fix #106794: Changing active camera changes other viewport local cameras #106799

Merged
Philipp Oeser merged 2 commits from lichtwerk/blender:106794 into main 2023-04-12 10:10:27 +02:00
Member

f36543c5f5 took care of syncing multiple viewport`s cameras, but wasnt
fully meeting intentions [which was to only do this if both viewports
are locked to the scene camera].

Check was only done for the viewport this was executed in (if this was
locked to the scene camera, it would change all other viewports as
well), now also check if the target viewport prefers to use its own
local camera instead and skip it in that case.

f36543c5f552 took care of syncing multiple viewport`s cameras, but wasnt fully meeting intentions [which was to only do this if both viewports are locked to the scene camera]. Check was only done for the viewport this was executed in (if this was locked to the scene camera, it would change all other viewports as well), now also check if the target viewport prefers to use its own local camera instead and skip it in that case.
Philipp Oeser added 1 commit 2023-04-11 13:02:23 +02:00
9ee7305317 Fix #106794: Changing active camera changes other viewport local cameras
f36543c5f5 took care of syncing multiple viewport`s cameras, but wasnt
fully meeting intentions [which was to only do this if both viewports
are locked to the scene camera].

Check was only done for the viewport this was executed in (if this was
locked to the scene camera, it would change all other viewports as
well), now also check if the target viewport prefers to use its own
local camera instead and skip it in that case.
Philipp Oeser requested review from Sergey Sharybin 2023-04-11 13:02:36 +02:00
Philipp Oeser requested review from Campbell Barton 2023-04-11 13:02:48 +02:00
Philipp Oeser added this to the User Interface project 2023-04-11 13:02:57 +02:00
Sergey Sharybin approved these changes 2023-04-11 13:31:20 +02:00
Sergey Sharybin left a comment
Owner

Is a bit tricky logic, so wouldn't mind if Campbell checks as well.
To me the change seems correct.

Is a bit tricky logic, so wouldn't mind if Campbell checks as well. To me the change seems correct.

Agree this is correct, although a short comment noting that checking the other view is needed to prevent local cameras being modified would be useful to include, as it's not obvious what this change does on a user level when reading the code.

Agree this is correct, although a short comment noting that checking the other view is needed to prevent local cameras being modified would be useful to include, as it's not obvious what this change does on a user level when reading the code.
Campbell Barton approved these changes 2023-04-12 09:49:15 +02:00
Philipp Oeser added 1 commit 2023-04-12 10:07:31 +02:00
Philipp Oeser merged commit 022652beb9 into main 2023-04-12 10:10:27 +02:00
Philipp Oeser deleted branch 106794 2023-04-12 10:10:29 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106799
No description provided.