Fix #102574: Don't Show "Rename" for Volume and & System lists #106873

Merged
Harley Acheson merged 2 commits from Harley/blender:FileListHints into main 2023-05-19 01:17:34 +02:00
Member

For File Browser "System" and "Volumes" lists, the item names cannot be
changed by users yet the tooltip says "Double click to rename". This PR
just removes that text for these non-editable lists.


This is an old and fairly common complaint. While hovering your mouse over File Browser "System" and "Volumes" list the tooltips says that you can double-click to rename the items. This doesn't work for these lists as the names are taken from system resource names.

This PR just alters the tooltip depending on the flags of the list. The System and Volumes lists already have their flags cleared of PROP_EDITABLE, but this PR adds the flag to Bookmarks and Recent. Then the the tooltip contents depends on that flag. The format of the tooltip is altered slightly to put the "Double click to rename" on a separate line below the path string.

An example of the "System" list:

FileList1.png

But the "Recent" (and Bookmarks) still shows the renaming text:

FileList2.png

For File Browser "System" and "Volumes" lists, the item names cannot be changed by users yet the tooltip says "Double click to rename". This PR just removes that text for these non-editable lists. --- This is an old and fairly common complaint. While hovering your mouse over File Browser "System" and "Volumes" list the tooltips says that you can double-click to rename the items. This doesn't work for these lists as the names are taken from system resource names. This PR just alters the tooltip depending on the flags of the list. The System and Volumes lists already have their flags cleared of PROP_EDITABLE, but this PR adds the flag to Bookmarks and Recent. Then the the tooltip contents depends on that flag. The format of the tooltip is altered slightly to put the "Double click to rename" on a separate line below the path string. An example of the "System" list: ![FileList1.png](/attachments/d066b4c5-cc60-4748-b891-272c7319a541) But the "Recent" (and Bookmarks) still shows the renaming text: ![FileList2.png](/attachments/5a1a0270-96d6-46af-9af6-50a6427007e9)
Harley Acheson added 1 commit 2023-04-12 23:23:08 +02:00
c00bc8cb3e Fix #102574: Don't Show "Rename" for Volume and & System lists
For File Browser "System" and "Volumes" lists, the item names cannot be
changed by users yet the tooltip says "Double click to rename". This PR
just removes that text for these non-editable lists.
Harley Acheson requested review from Julian Eisel 2023-04-12 23:23:17 +02:00
Harley Acheson added this to the User Interface project 2023-04-12 23:23:26 +02:00
Harley Acheson added this to the 4.0 milestone 2023-05-18 00:12:50 +02:00
Harley Acheson added 1 commit 2023-05-19 00:32:06 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
9c8f1ed6a1
Merge branch 'main' into FileListHints
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson merged commit dad9e8e621 into main 2023-05-19 01:17:34 +02:00
Harley Acheson deleted branch FileListHints 2023-05-19 01:17:37 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:38 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106873
No description provided.