GPU: Add Texture Usage Parameter to GPUOffscreen. #106899

Jeroen Bakker · 2023-04-13T12:44:59+02:00

Jeroen Bakker commented

2023-04-13 12:44:59 +02:00

Currently the Textures used for offscreen rendering don't have
the GPU_TEXTURE_USAGE_HOST_READ flag. But some cases it is
needed. This PR adds a parameter when creating an offscreen
buffer.

Other solution could be to add this flag to all textures, but
we chose not to do this as that reduces the amount of fine-tuning
options for Metal/Vulkan backends. GPU can store textures
differently based on its actual usage.

This option isn't available in the python API as we don't expect
add-on developers to fine-tune texture usages to this extent.

For convenience GPU_TEXTURE_USAGE_ATTACHMENT is by default
always added.

Currently the Textures used for offscreen rendering don't have the `GPU_TEXTURE_USAGE_HOST_READ` flag. But some cases it is needed. This PR adds a parameter when creating an offscreen buffer. Other solution could be to add this flag to all textures, but we chose not to do this as that reduces the amount of fine-tuning options for Metal/Vulkan backends. GPU can store textures differently based on its actual usage. This option isn't available in the python API as we don't expect add-on developers to fine-tune texture usages to this extent. For convenience `GPU_TEXTURE_USAGE_ATTACHMENT` is by default always added.

Jeroen Bakker added 1 commit 2023-04-13 12:45:07 +02:00

GPU: Add texture usage parameter to GPUOffscreen. 29cc37cf22

Currently the Textures used for offscreen rendering don't have
the `GPU_TEXTURE_USAGE_HOST_READ` flag. But some cases it is
needed. This PR adds a parameter when creating an offscreen
buffer.

Other solution could be to add this flag to all textures, but
we chose not to do this as that reduces the amount of fine-tuning
options for Metal/Vulkan backends. GPU can store textures
differently based on its actual usage.

This option isn't available in the python API as we don't expect
add-on developers to fine-tune texture usages to this extent.

Jeroen Bakker requested review from Clément Foucault 2023-04-13 12:45:14 +02:00

Jeroen Bakker added the

Module

Viewport & EEVEE

label 2023-04-13 12:45:25 +02:00

Jeroen Bakker added this to the 3.6 LTS milestone 2023-04-13 12:45:28 +02:00

Jeroen Bakker added this to the Viewport & EEVEE project 2023-04-13 12:45:31 +02:00

Jeroen Bakker self-assigned this 2023-04-13 12:45:36 +02:00

Jeroen Bakker commented

2023-04-13 12:48:18 +02:00

I checked the actual usages around the areas where the offscreen buffers where created and updated them accordingly. There were some areas already that needed
the host visibility flags.

Depending on the actual platform this could have been an issue. I came across this issue during development of the Vulkan graphics pipeline. Where Vulkan mentioned incorrect usage flags.

I checked the actual usages around the areas where the offscreen buffers where created and updated them accordingly. There were some areas already that needed the host visibility flags. Depending on the actual platform this could have been an issue. I came across this issue during development of the Vulkan graphics pipeline. Where Vulkan mentioned incorrect usage flags.

Jeroen Bakker added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPU: Add Texture Usage Parameter to GPUOffscreen. #106899