Geometry Nodes: Use implicit sharing in point/mesh conversion nodes #106917
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#106917
Loading…
Reference in New Issue
No description provided.
Delete Branch "HooglyBoogly:points-nodes-sharing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Reduces memory usage and time spent copying data in the "Points to
Vertices" and "Mesh to Points" nodes. An arbitrary speedup can be
observed by just adding more data to the source geometries.
For example, in a simple test I saw a 70x speedup. The sharing in
the "Mesh to Points" node is more limited though, since it can copy
from multiple domains.
A new utility function is added to share a custom data layer.
I'd imagine this being part of a more general "attribute interpolation"
abstraction in the future.
@ -45,6 +45,23 @@ static void node_init(bNodeTree * /*tree*/, bNode *node)
node->storage = data;
}
static const CustomData &mesh_custom_data_for_domain(const Mesh &mesh, const eAttrDomain domain)
I'm not quite convinced we should start using custom data here yet. Better integrate implicit sharing with the attribute api and later field evaluation + maybe virtual arrays. I started doing that a bit in my branch. See e.g.
GAttributeReader
in https://projects.blender.org/JacquesLucke/blender/src/branch/sim-bake/source/blender/blenkernel/BKE_attribute.hh.@ -89,0 +95,4 @@
const bool share_arrays = selection.size() == domain_size;
const bool share_position = share_arrays && domain == ATTR_DOMAIN_POINT &&
positions_eval.is_span() &&
positions_eval.get_internal_span() == mesh->vert_positions();
This does a deep comparison of the positions leading to some significant new overhead.
@ -100,0 +113,4 @@
/* Create an empty point cloud so the positions can be easily shared with a generic utility. */
pointcloud = BKE_pointcloud_new_nomain(0);
pointcloud->totpoint = mesh->totvert;
CustomData_free_layer_named(&pointcloud->pdata, "position", pointcloud->totpoint);
move one line up
@ -67,0 +76,4 @@
Mesh *mesh = BKE_mesh_new_nomain(0, 0, 0, 0);
geometry_set.replace_mesh(mesh);
mesh->totvert = points->totpoint;
CustomData_free_layer_named(&mesh->vdata, "position", mesh->totvert);
This should probably be moved one line up.
I find the changes to the points to vertices node much less controversial, so maybe split the patch up.
Thanks for looking at this. I didn't think about integrating with the attribute API, but that does make a lot more sense. I think I'll shelve this change and look into that approach instead. Maybe we can talk about that next week.
Pull request closed