UI: remove "vertex_active" theme color from Editors that dont use it #106936

Philipp Oeser · 2023-04-14T10:41:49+02:00

Philipp Oeser commented

2023-04-14 10:41:49 +02:00

Report was that "Active Vertex" theme color does nothing for the 3D
View.

vertex_active / TH_VERTEX_ACTIVE is only in use for the Graph
Editor (FCurve points).
editmesh_active / TH_EDITMESH_ACTIVE is in use elsewhere [we might
consider changing the name here geometry_point_active? -- since it is
also used for curves]

Both of these are included in rna_def_userdef_theme_spaces_vertex
[which is used for the Graph Editor, 3D View and Image Editor]

So solution might be to move this out of
rna_def_userdef_theme_spaces_vertex and into
rna_def_userdef_theme_space_graph (of course, the naming for
rna_def_userdef_theme_spaces_vertex is then also a bit "improvable")

Fixes #106885

Report was that "Active Vertex" theme color does nothing for the 3D View. - `vertex_active` / `TH_VERTEX_ACTIVE` is only in use for the Graph Editor (FCurve points). - `editmesh_active` / `TH_EDITMESH_ACTIVE` is in use elsewhere [we might consider changing the name here `geometry_point_active`? -- since it is also used for curves] Both of these are included in `rna_def_userdef_theme_spaces_vertex` [which is used for the `Graph Editor`, `3D View` and `Image Editor`] So solution might be to move this out of `rna_def_userdef_theme_spaces_vertex` and into `rna_def_userdef_theme_space_graph` (of course, the naming for `rna_def_userdef_theme_spaces_vertex` is then also a bit "improvable") Fixes #106885

Philipp Oeser added 1 commit 2023-04-14 10:42:05 +02:00

4b11e5fcb7 UI: remove "vertex_active" theme color from Editors that dont use it

Report was that "Active Vertex" theme color does nothing for the 3D
View.

- `vertex_active` / `TH_VERTEX_ACTIVE` is only in use for the Graph
Editor (FCurve points).
- `editmesh_active` / `TH_EDITMESH_ACTIVE` is in use elsewhere [we might
consider changing the name here `geometry_point_active`? -- since it is
also used for curves]

Both of these are included in `rna_def_userdef_theme_spaces_vertex`
[which is used for the `Graph Editor`, `3D View` and `Image Editor`]

So solution might be to move this out of
`rna_def_userdef_theme_spaces_vertex` and into
`rna_def_userdef_theme_space_graph` (of course, the naming for
`rna_def_userdef_theme_spaces_vertex` is then also a bit "improvable")

Fixes #106885

Philipp Oeser added this to the User Interface project 2023-04-14 10:42:19 +02:00

Philipp Oeser requested review from Pablo Vazquez 2023-04-14 10:42:27 +02:00

Philipp Oeser requested review from Harley Acheson 2023-04-14 10:42:35 +02:00

Harley Acheson commented

2023-04-14 18:22:14 +02:00

Interesting! That works well and I had to give it a think on why it doesn't need versioning.

editmesh_active / TH_EDITMESH_ACTIVE is in use elsewhere [we might
consider changing the name here geometry_point_active? -- since it is
also used for curves]

AFAIK "editmesh_active" is used for the color of the active vertex, edge, and face. As in 3D View uses separate colors for selected vertex, edge, and face. But then has this single weird editmesh_active for all the actives. And with that we ignore the alpha for active vertex and edge but use the alpha for the active face somehow. It behaves oddly.

But maybe could be renamed "geometry_active" or similar so not to imply it is just for points?

Interesting! That works well and I had to give it a think on why it doesn't need versioning. > editmesh_active / TH_EDITMESH_ACTIVE is in use elsewhere [we might consider changing the name here geometry_point_active? -- since it is also used for curves] AFAIK "editmesh_active" is used for the color of the active vertex, edge, and face. As in 3D View uses separate colors for _selected_ vertex, edge, and face. But then has this single weird editmesh_active for all the actives. And with that we ignore the alpha for active vertex and edge but use the alpha for the active face somehow. It behaves oddly. But maybe could be renamed "geometry_active" or similar so not to imply it is just for points?

Pablo Vazquez commented

2023-05-24 14:42:34 +02:00

+1 on the change to geometry_active or geometry_component_active or similar.

+1 on the change to `geometry_active` or `geometry_component_active` or similar.

Pablo Vazquez commented

2023-07-22 18:45:33 +02:00

Perhaps 4.0 is a good time to finish with the rename of this setting?