Make first non-anonymous CustomData layer active #106972

Martijn Versteegh · 2023-04-14T23:16:03+02:00

Martijn Versteegh commented

2023-04-14 23:16:03 +02:00

For each created CustomData layer check if the previous active layer
was an anonymous layer and if so set the new layer as active. Do the same
for the render/clone/mask layer. This way we never end up in a state
where a mesh has non-anonymous layers but none of them are active.

For each created CustomData layer check if the previous active layer was an anonymous layer and if so set the new layer as active. Do the same for the render/clone/mask layer. This way we never end up in a state where a mesh has non-anonymous layers but none of them are active.

Martijn Versteegh added 1 commit 2023-04-14 23:16:20 +02:00

639b10bc1c Make first non-anonymous CustomData layer active

For each created CustomData layer check if the previous active layer
was an anonymous layer and if so set the new layer as active. Do the same
for the render/clone/mask layer. This way we never end up in a state
where a mesh has non-anonymous layers but none of them are active.

Martijn Versteegh requested review from Hans Goudey 2023-04-18 12:17:22 +02:00

Martijn Versteegh commented

2023-04-18 12:19:02 +02:00

@HooglyBoogly considering your lukewarm reaction in the chat I assume you'r prefer not to do this patch and wait for converting all active layers to name-based -on-the-geometry instead? And then think about how to handle this stuff?

@HooglyBoogly considering your lukewarm reaction in the chat I assume you'r prefer *not* to do this patch and wait for converting all active layers to name-based -on-the-geometry instead? And *then* think about how to handle this stuff?

~~Martijn Versteegh referenced this pull request 2023-04-18 12:30:48 +02:00~~

Regression: Viewport Shading 'Attribute' Option Broken for generated Geometry #106563

Hans Goudey commented

2023-04-18 14:12:44 +02:00

Yeah, I do think that's probably a better approach, that's not a strong opinion though.

Martijn Versteegh commented

2023-04-18 20:05:21 +02:00

I don't really have a strong opinion either. It's kinda weird that there's now the possible situation of a hidden layer being the active one, but no one seems to have complained so maybe I'll just scratch/archive this patch until a bugreport surfaces that calls for it. And hope we can get string based active layers working before that ;-)

Martijn Versteegh closed this pull request

2023-07-12 14:39:27 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Make first non-anonymous CustomData layer active #106972

Pull request closed