WIP: UI: Add Drag & Drop Feedback on Windows #107056

Draft

Guillermo Venegas wants to merge 3 commits from guishe/blender:drag-and-drop-update into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Guillermo Venegas commented

2023-04-17 23:25:56 +02:00

Contributor

On Windows, Drag & Drop data can be obtained when the mouse enters in a
window. This data can be used to provide feedback to the user, for example,
if the data contains a file path, it can be displayed if an operation can
be performed on the file on drop.

On Windows, Drag & Drop data can be obtained when the mouse enters in a window. This data can be used to provide feedback to the user, for example, if the data contains a file path, it can be displayed if an operation can be performed on the file on drop.

❤️ 1 🚀 1

Guillermo Venegas commented

2023-04-17 23:31:32 +02:00

Author

Contributor

Here is a video showing the patch:

Here is a video showing the patch:

2023-04-17 15-28-07.mp4

1.9 MiB

Iliya Katushenock added this to the User Interface project 2023-04-17 23:33:57 +02:00

Iliya Katushenock added the

Pipeline, Assets & IO

label 2023-04-17 23:34:01 +02:00

Guillermo Venegas commented

2023-04-17 23:38:13 +02:00

Author

Contributor

In my testing, I've found that apps can fail to report drop status to Blender, which can cause unexpected behavior (as seen in the video).

The following works fine:

Drag and drop from desktop
Drag and drop from the 7Zip file explorer

The file browser does not report the drop if the mouse is moving, and keeps updating the drag state with the same mouse coodinates at the time the drop should have been done.
Performing another drag and drop from the file explorer fixes the issue.

In my testing, I've found that apps can fail to report drop status to Blender, which can cause unexpected behavior (as seen in the video). The following works fine: * Drag and drop from desktop * Drag and drop from the 7Zip file explorer The file browser does not report the drop if the mouse is moving, and keeps updating the drag state with the same mouse coodinates at the time the drop should have been done. Performing another drag and drop from the file explorer fixes the issue.

2023-04-17 15-32-43.mp4

1.0 MiB

Guillermo Venegas changed title from ~~UI: Add Drag & Drop Feedback on Windows~~ to WIP: UI: Add Drag & Drop Feedback on Windows

2023-04-18 21:32:19 +02:00

Guillermo Venegas force-pushed drag-and-drop-update from 7db8f39c06 to 5d53c8a2ea

2023-04-18 23:42:16 +02:00

Compare

Guillermo Venegas force-pushed drag-and-drop-update from 5d53c8a2ea to 433e4d8c0e

2023-04-19 04:40:43 +02:00

Compare

Guillermo Venegas force-pushed drag-and-drop-update from 433e4d8c0e to 76d9526aaf

2023-04-22 23:47:47 +02:00

Compare

Guillermo Venegas force-pushed drag-and-drop-update from 76d9526aaf to 7c4d5e08ad

2023-05-02 17:31:44 +02:00

Compare

Guillermo Venegas force-pushed drag-and-drop-update from 7c4d5e08ad to a6b78e0a08

2023-05-02 17:36:51 +02:00

Compare

Guillermo Venegas commented

2023-05-02 17:45:21 +02:00

Author

Contributor

@blender-bot package

@blender-bot package

Blender Bot commented

2023-05-02 17:45:23 +02:00

Member

Only blender organization members with write access can start builds. See documentation for details.

Only blender organization members with write access can start builds. See [documentation](https://projects.blender.org/infrastructure/blender-bot/src/branch/main/README.md) for details.

Guillermo Venegas force-pushed drag-and-drop-update from a6b78e0a08 to a402e5c94d

2023-05-02 17:52:21 +02:00

Compare

This pull request has changes conflicting with the target branch.

intern/ghost/intern/GHOST_DropTargetWin32.cc
intern/ghost/intern/GHOST_DropTargetX11.cc
source/blender/editors/interface/interface_drag.cc
source/blender/editors/io/CMakeLists.txt
source/blender/editors/io/io_obj.c
source/blender/editors/io/io_obj.h
source/blender/editors/io/io_ops.c
source/blender/editors/screen/screen_ops.c
source/blender/editors/space_clip/space_clip.cc
source/blender/editors/space_console/space_console.c

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u drag-and-drop-update:guishe-drag-and-drop-update

git checkout guishe-drag-and-drop-update

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107056

No description provided.