Fix: segfault when indexing into some collections with strings. #107086

Merged
Nathan Vegdahl merged 1 commits from nathanvegdahl/blender:str_collection_indexing_bug into main 2023-04-18 17:15:34 +02:00
Member

This happens when the collection's item type doesn't have a
'nameproperty' to index with. For debug builds we error out with an
assert, since in general this shouldn't happen. For release builds
Python will report item not found.

This happens when the collection's item type doesn't have a 'nameproperty' to index with. For debug builds we error out with an assert, since in general this shouldn't happen. For release builds Python will report item not found.
Nathan Vegdahl added 1 commit 2023-04-18 16:59:29 +02:00
3adc3a1370 Fix: segfault when indexing into some collections with strings.
This happens when the collection's item type doesn't have a
'nameproperty' to index with.  For debug builds we error out with an
assert, since in general this shouldn't happen.  For release builds
Python will report item not found.
Nathan Vegdahl requested review from Bastien Montagne 2023-04-18 17:01:54 +02:00
Bastien Montagne approved these changes 2023-04-18 17:04:44 +02:00
Hans Goudey reviewed 2023-04-18 17:06:38 +02:00
@ -2374,0 +2375,4 @@
nameprop,
"Attempted to use a string to index into a collection of items with no 'nameproperty'.");
if (nameprop == NULL) {
// For non-debug builds, bail if there's no 'nameproperty' to check.
Member

Blender uses /* */ comment style, see https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Comments

Blender uses `/* */` comment style, see https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Comments
Author
Member

Gah! Sorry, I didn't refresh the page between Bastien's approval and merging, and missed your comment. Thanks for letting me know. I'll fix it.

Gah! Sorry, I didn't refresh the page between Bastien's approval and merging, and missed your comment. Thanks for letting me know. I'll fix it.
Nathan Vegdahl merged commit 5bb3a3f157 into main 2023-04-18 17:15:34 +02:00
Nathan Vegdahl deleted branch str_collection_indexing_bug 2023-04-18 17:15:35 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107086
No description provided.