I18n: disambiguate a few messages #107139

Merged
Bastien Montagne merged 2 commits from pioverfour/blender:dp_disambiguate into main 2023-05-16 14:52:12 +02:00
Member
  • "Out" meaning "one end of a bone". Same as in 9120c86c3f.
  • "Canvas" meaning a painting support for Dynamic Paint.
  • "Twist" meaning an action verb, as opposed to an amount.
  • "Solid" meaning a textureless, single-color material.
  • "Blend mode" meaning material opacity blending, as opposed to color
    blending.
  • "Pixel Size" meaning "a size measured using pixels as the unit".
  • "Light" meaning "not dark", as in "Light Theme".

Ref #43295

- "Out" meaning "one end of a bone". Same as in 9120c86c3f. - "Canvas" meaning a painting support for Dynamic Paint. - "Twist" meaning an action verb, as opposed to an amount. - "Solid" meaning a textureless, single-color material. - "Blend mode" meaning material opacity blending, as opposed to color blending. - "Pixel Size" meaning "a size measured using pixels as the unit". - "Light" meaning "not dark", as in "Light Theme". Ref #43295
Damien Picard added the
Module
User Interface
Interest
Translations
labels 2023-04-19 19:54:43 +02:00
Damien Picard requested review from Bastien Montagne 2023-04-19 19:55:04 +02:00
Damien Picard force-pushed dp_disambiguate from 958b7f6916 to b8e53f6765 2023-04-20 19:13:50 +02:00 Compare
Bastien Montagne requested changes 2023-04-28 18:25:54 +02:00
Bastien Montagne left a comment
Owner

Have the feeling there are more changes than needed here... Also not sure about the rational of adding contexts to strings like "Mode" or "Type"?

Have the feeling there are more changes than needed here... Also not sure about the rational of adding contexts to strings like "Mode" or "Type"?
@ -130,6 +130,7 @@ const char *BLT_translate_do_new_dataname(const char *msgctxt, const char *msgid
#define BLT_I18NCONTEXT_AMOUNT "Amount"
#define BLT_I18NCONTEXT_COLOR "Color"
#define BLT_I18NCONTEXT_CONSTRAINT "Constraint"
#define BLT_I18NCONTEXT_THEME "Theme"

Don't think that one is needed here, 'light' is in color context here...

Don't think that one is needed here, 'light' is in color context here...
pioverfour marked this conversation as resolved
@ -2573,6 +2574,7 @@ static void rna_def_brush(BlenderRNA *brna)
RNA_def_property_enum_sdna(prop, NULL, "gpencil_sculpt_tool");
RNA_def_property_enum_items(prop, rna_enum_brush_gpencil_sculpt_types_items);
RNA_def_property_ui_text(prop, "Grease Pencil Sculpt Paint Tool", "");
RNA_def_property_translation_context(prop, BLT_I18NCONTEXT_ID_GPENCIL);

Don't understand the need for this change (and the one above)? Doubt there is any conflict with any other usage/meanings here?

Don't understand the need for this change (and the one above)? Doubt there is any conflict with any other usage/meanings here?
Damien Picard added 1 commit 2023-04-28 23:47:33 +02:00
Author
Member

Have the feeling there are more changes than needed here... Also not sure about the rational of adding contexts to strings like "Mode" or "Type"?

Don't understand the need for this change (and the one above)? Doubt there is any conflict with any other usage/meanings here?

These are just about "Twist", which in this context is a verb, while it’s a noun in others. Since AFAIK the only way to disambiguate an enum item (from rna_enum_brush_gpencil_sculpt_types_items) is to add the context to the whole prop, I couldn’t think of a better way.

> Have the feeling there are more changes than needed here... Also not sure about the rational of adding contexts to strings like "Mode" or "Type"? > Don't understand the need for this change (and the one above)? Doubt there is any conflict with any other usage/meanings here? These are just about "Twist", which in this context is a verb, while it’s a noun in others. Since AFAIK the only way to disambiguate an enum item (from `rna_enum_brush_gpencil_sculpt_types_items`) is to add the context to the whole prop, I couldn’t think of a better way.
Damien Picard requested review from Bastien Montagne 2023-05-07 12:18:57 +02:00
Bastien Montagne approved these changes 2023-05-15 18:54:03 +02:00
Bastien Montagne left a comment
Owner

Ah right, these are enum properties... Then LGTM.

Ah right, these are enum properties... Then LGTM.

@blender-bot build

@blender-bot build
Bastien Montagne merged commit b905b02222 into main 2023-05-16 14:52:12 +02:00
Bastien Montagne deleted branch dp_disambiguate 2023-05-16 14:52:13 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:39 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107139
No description provided.