Metal: Resolve runtime issues with texture views #107167

Jason Fielder · 2023-04-20T12:42:39+02:00

Jason Fielder commented

2023-04-20 12:42:39 +02:00

When creating a texture view, Metal may require that the original
GPUTexture state is modified in some way. This may be a result
of deferred creation, or, to cache the texture view against the
source.

As a result, GPUTexture passed into GPU_texture_create_view
cannot be const.

Small fixes have also been made in the Metal texture
implementation to ensure correct function of texture views.

Authored by Apple: Michael Parkin-White

Ref #96261

When creating a texture view, Metal may require that the original GPUTexture state is modified in some way. This may be a result of deferred creation, or, to cache the texture view against the source. As a result, GPUTexture passed into GPU_texture_create_view cannot be const. Small fixes have also been made in the Metal texture implementation to ensure correct function of texture views. Authored by Apple: Michael Parkin-White Ref #96261

Jason Fielder added 1 commit 2023-04-20 12:42:50 +02:00

254b047e6f Metal: Resolve runtime issues with texture views

When creating a texture view, Metal may require that the original
GPUTexture state is modified in some way. This may be a result
of deferred creation, or, to cache the texture view against the
source.

As a result, GPUTexture passed into GPU_texture_create_view
cannot be const.

Small fixes have also been made in the Metal texture
implementation to ensure correct function of texture views.

Authored by Apple: Michael Parkin-White

Ref #96261

Jason Fielder requested review from Jeroen Bakker 2023-04-20 12:43:19 +02:00

Michael Parkin-White referenced this pull request

2023-04-20 12:43:35 +02:00

GPU: Resolve runtime issues with texture views for Metal #106220

Jeroen Bakker requested changes 2023-04-24 08:49:11 +02:00

source/blender/gpu/metal/mtl_texture.mm

						
				@ -1820,3 +1821,4 @@

				  /* Assign usage. */

				  gpu_image_usage_flags_ = GPU_texture_usage(src);

				  BLI_assert_msg(

Jeroen Bakker commented

2023-04-24 08:48:59 +02:00

How bad is it to have incorrect usage flags. This might also fail for devs/users not familiar with the Metal backend and they are then not able to continue their work. Would rather see an CLog error/warning depending on the actual priority to fix the issue. Or guarded by --debug-gpu.

Michael Parkin-White commented

2023-04-28 14:19:01 +02:00

First-time contributor

Yeah, its likely not important for non-metal platforms right now, but there was a discussion about moving the checks outside of the GPU backend, as this may also help the Vulkan bring-up.

However, we can guard it behind debug-gpu for now perhaps?
The purpose of this was mostly for aiding bring-up, to ensure certain features were using required flags up front, though hopefully the debug-gpu flag can still be used for this.

Yeah, its likely not important for non-metal platforms right now, but there was a discussion about moving the checks outside of the GPU backend, as this may also help the Vulkan bring-up. However, we can guard it behind debug-gpu for now perhaps? The purpose of this was mostly for aiding bring-up, to ensure certain features were using required flags up front, though hopefully the debug-gpu flag can still be used for this.

Jeroen Bakker commented

2023-05-01 09:06:17 +02:00

I think for now it is better to assert all the time. This way it is easier for users/developers to detect any issue so we can fix it. Hiding it behind the --debug-gpu flag has some other cons:

might crash when we ask users to provide more information about a different issue.

I think for now it is better to assert all the time. This way it is easier for users/developers to detect any issue so we can fix it. Hiding it behind the --debug-gpu flag has some other cons: - might crash when we ask users to provide more information about a different issue.

Jeroen Bakker approved these changes 2023-05-01 09:12:52 +02:00

Jeroen Bakker added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Metal: Resolve runtime issues with texture views #107167