WIP: Shading: Set temperature subtype in shading nodes #107278

Draft
Daniel Salazar wants to merge 6 commits from zanqdo/blender:blackbody-node-default-value into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Changes the default Kelvin value of the Black body node to a neutral "daylight" 6500 K instead of the very red 1500 K

Also (with the help of @deadpin) added support for temperature subtype in nodes,

Use temperature subtype in the Blackbody and Principled Volume nodes so they display temperature as Kelvin by default and auto convert to Celsius or Fahrenheit according to preference.

imageimageimage

Note: This currently breaks forwards compatibility

Changes the default Kelvin value of the Black body node to a neutral "daylight" 6500 K instead of the very red 1500 K Also (with the help of @deadpin) added support for temperature subtype in nodes, Use temperature subtype in the Blackbody and Principled Volume nodes so they display temperature as Kelvin by default and auto convert to Celsius or Fahrenheit according to preference. ![image](/attachments/ba61f32c-3955-4826-b9de-427b5b851d3b)![image](/attachments/8643e1bf-40c0-4744-b68a-53ccb1ae0dd3)![image](/attachments/d9a8718f-5245-4d51-8c72-3302d43c8839) **Note: This currently breaks forwards compatibility**
Daniel Salazar added 1 commit 2023-04-24 02:30:57 +02:00
Daniel Salazar added this to the Render & Cycles project 2023-04-24 02:31:41 +02:00
Daniel Salazar added the
Interest
Cycles
label 2023-04-24 02:34:05 +02:00
Daniel Salazar changed title from Shading: Set default Blackbody node value to 6500 to WIP: Shading: Set default Blackbody node value to 6500 2023-04-24 02:42:06 +02:00
Iliya Katushenock added the
Interest
Nodes & Physics
label 2023-04-24 06:34:49 +02:00
Brecht Van Lommel added
Module
Render & Cycles
and removed
Interest
Nodes & Physics
Interest
Cycles
labels 2023-04-25 13:10:45 +02:00
Daniel Salazar added 2 commits 2023-05-04 22:06:49 +02:00
Daniel Salazar added 1 commit 2023-05-04 22:25:14 +02:00
Daniel Salazar added 1 commit 2023-05-04 23:00:17 +02:00
Daniel Salazar changed title from WIP: Shading: Set default Blackbody node value to 6500 to WIP: Shading: Set default Blackbody node value to 6500 K 2023-05-04 23:00:42 +02:00
Daniel Salazar added 1 commit 2023-05-04 23:19:08 +02:00
Set the Temperature property in the volume node to Teperature type
Daniel Salazar changed title from WIP: Shading: Set default Blackbody node value to 6500 K to WIP: Shading: Set temperature property type in shading nodes 2023-05-04 23:39:22 +02:00
Daniel Salazar changed title from WIP: Shading: Set temperature property type in shading nodes to WIP: Shading: Set temperature subtype in shading nodes 2023-05-05 00:10:08 +02:00
Member

I don’t think using the temperature subtype is a good idea, because colour temperatures are always expressed in K, so even if someone uses °C or °F for simulations, they will not want to see the colour temp in the same unit.

I don’t think using the temperature subtype is a good idea, because colour temperatures are always expressed in K, so even if someone uses °C or °F for simulations, they will not want to see the colour temp in the same unit.
Member

I don’t think using the temperature subtype is a good idea, because colour temperatures are always expressed in K, so even if someone uses °C or °F for simulations, they will not want to see the colour temp in the same unit.

Agreed - I like the idea of having proper unit support here, but I'd rather have a dedicated unit type for color temperatures that always gets displayed in Kelvin (similar to the wavelength unit, which always is nm regardless of scene scale or unit system).

> I don’t think using the temperature subtype is a good idea, because colour temperatures are always expressed in K, so even if someone uses °C or °F for simulations, they will not want to see the colour temp in the same unit. Agreed - I like the idea of having proper unit support here, but I'd rather have a dedicated unit type for color temperatures that always gets displayed in Kelvin (similar to the wavelength unit, which always is nm regardless of scene scale or unit system).
Author
Member

I don’t think using the temperature subtype is a good idea, because colour temperatures are always expressed in K, so even if someone uses °C or °F for simulations, they will not want to see the colour temp in the same unit.

Agreed - I like the idea of having proper unit support here, but I'd rather have a dedicated unit type for color temperatures that always gets displayed in Kelvin (similar to the wavelength unit, which always is nm regardless of scene scale or unit system).

Can agree with that 👍🏻

> > I don’t think using the temperature subtype is a good idea, because colour temperatures are always expressed in K, so even if someone uses °C or °F for simulations, they will not want to see the colour temp in the same unit. > > Agreed - I like the idea of having proper unit support here, but I'd rather have a dedicated unit type for color temperatures that always gets displayed in Kelvin (similar to the wavelength unit, which always is nm regardless of scene scale or unit system). Can agree with that 👍🏻
Member

I've opened a PR for the unit in !123337.

I think the proposed change to the default is still reasonable, so maybe we can repurpose this PR for that? I'm not sure about 6500K specifically since it'll show up as white which might be confusing for new users, but I agree that 1500K is too low.

Actually, I think we should also extend the supported range to at least 25000K, but that's another topic again.

I've opened a PR for the unit in !123337. I think the proposed change to the default is still reasonable, so maybe we can repurpose this PR for that? I'm not sure about 6500K specifically since it'll show up as white which might be confusing for new users, but I agree that 1500K is too low. Actually, I think we should also extend the supported range to at least 25000K, but that's another topic again.
Author
Member

Same as the default color for lamps is a neutral white. The default blackbody temperature should be neutral. It shouldn't be confusing to anyone adding a blackbody node. It's actually confusing to turn a lamp to a red color just because of adding a blackbody node.

Same as the default color for lamps is a neutral white. The default blackbody temperature should be neutral. It shouldn't be confusing to anyone adding a blackbody node. It's actually confusing to turn a lamp to a red color just because of adding a blackbody node.
This pull request has changes conflicting with the target branch.
  • source/blender/blenkernel/intern/node.cc
  • source/blender/makesrna/intern/rna_nodetree.c
  • source/blender/nodes/intern/node_socket.cc
  • source/blender/nodes/shader/nodes/node_shader_blackbody.cc
  • source/blender/nodes/shader/nodes/node_shader_volume_principled.cc

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u blackbody-node-default-value:zanqdo-blackbody-node-default-value
git checkout zanqdo-blackbody-node-default-value
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107278
No description provided.