Fix #107306: Merge by distance node is not deterministic #107312
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#107312
Loading…
Reference in New Issue
No description provided.
Delete Branch "mod_moder/blender:tmp_fix_merge_by_distance_indexing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Based on the test results (just 2 very detailed cubes and a transformation),
it doesn't seem to affect performance that much. Сan leave this enabled in
the general, and not just for the node.
Credit for @MMMM was pointed this option.
@blender-bot build
Looks like this breaks the tests. That might be fine, and just a change of indices, but we should be sure before this is committed.
Will check later (23:40)
Yes, no rush of course!
Might be relevant:
There was a "bug fix" about 6 years ago that changed the "Meld Modifier" to be "false" because it cause crashes.
I believe I have a solution to that as well:
If this causes a crash, it may be caused by accessing an index that's already been deleted, this can be fixed by setting Some Variable to "tree->nodes_len" then set I to Some Variable in the loop, then inside the loop, subtracting the number of removed indexes from Some Variable. This would prevent "I" from being greater than the updated node_length.
ae7c71ef09/source/blender/blenlib/intern/kdtree_impl.h (L889)
After recheck, yeah, look like this just problem of indices (old mesh haven's same point in same indices). So this test-failed problems isn't real.
So, to finish this bug fix, the test case needs to be corrected? Who does that? If it's something that'll take more than a minute or two, if you point me to the test file, I'll make the changes and submit it.
I spent a couple hours digging around and can't seem to find them. The appear to be two blend files not in repository. I'm guessing they are made on demand, but can't figure out where.
There is information about the tests here: https://wiki.blender.org/wiki/Tools/Tests/Setup
The change is quick to make, I can do it when committing this change today. Thanks for the reminder.
Fix #107306: Geometry Nodes: Merge by Distance node be deterministicallyto Fix #107306: Merge by distance node is not deterministic