WIP: Fix: Slider bidirectionality in pose_slide.c #107397

Closed
Christoph Lendenfeld wants to merge 2 commits from ChrisLend/blender:fix_pose_slider_bidirectional into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

When the slider was set to default to 0-1 with no overshoot to the left,
the code was not adapted to still allow overshoot on the pose slide operators.

This patch fixes that, and also makes sure to use const and lerpf when possible

When the slider was set to default to 0-1 with no overshoot to the left, the code was not adapted to still allow overshoot on the pose slide operators. This patch fixes that, and also makes sure to use `const` and `lerpf` when possible
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2023-04-27 11:29:40 +02:00
Christoph Lendenfeld added 1 commit 2023-04-27 11:29:50 +02:00
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-04-27 11:31:02 +02:00

This patch combines a lot of non-functional changes with a few functional changes, which makes it harder to actually spot all the functional ones. Can you split it up into two PRs? Or just one PR for the functional changes -- the cleanups look good to me and if things really don't change the functionality they can be committed directly.

In the PR description I think lerpf should be interpf?

This patch combines a lot of non-functional changes with a few functional changes, which makes it harder to actually spot all the functional ones. Can you split it up into two PRs? Or just one PR for the functional changes -- the cleanups look good to me and if things really don't change the functionality they can be committed directly. In the PR description I think `lerpf` should be `interpf`?
Sybren A. Stüvel requested changes 2023-05-02 11:04:56 +02:00
Sybren A. Stüvel left a comment
Member

Just marking 'request changes' to put the PR into the right queue.

Just marking 'request changes' to put the PR into the right queue.
Christoph Lendenfeld added 1 commit 2023-05-04 10:47:02 +02:00
Author
Member

extracted the non functional changes into: #107610: Refactor: pose_slide.c

Once #107406: Refactor: Allow to explicitly set the range on the slider UI element lands, I will revisit this, because it allows other solutions to the issue

extracted the non functional changes into: [#107610: Refactor: pose_slide.c](https://projects.blender.org/blender/blender/pulls/107610) Once [#107406: Refactor: Allow to explicitly set the range on the slider UI element](https://projects.blender.org/blender/blender/pulls/107406) lands, I will revisit this, because it allows other solutions to the issue
Christoph Lendenfeld changed title from Fix: Slider bidirectionality in pose_slide.c to WIP: Fix: Slider bidirectionality in pose_slide.c 2023-05-04 12:18:50 +02:00
Author
Member
since [#107406: Refactor: Allow to explicitly set the range on the slider UI element](https://projects.blender.org/blender/blender/pulls/107406) this is no longer an issue

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107397
No description provided.