WIP: VFONT: Text Object Word Selection #107519

Harley Acheson · 2023-05-02T00:08:40+02:00

Harley Acheson commented

2023-05-02 00:08:40 +02:00

Corrections to allow better cursor keyboard movement and selection by
word and mouse word selection by double-clicking.

Corrections to selection of word boundaries when inserting the text cursor, selecting words with keyboard and with the mouse. With this PR applied the following works as expected:

Moving the text cursor a word at time backward (ctrl-left arrow) will generally move directly from the front of one word to the front of the previous word. Similarly pressing ctrl-right arrow will move directly from the end of one word to the end of the next word. Even if the word is only one character long.

However if the text cursor is placed at the end of a word, pressing ctrl-left will move to the beginning of that same word. Pressing ctrl-right will move to the end of a word if you start from the beginning. Even if the word is only a single character long.

Holding shift while using ctrl-left or ctrl-right will select a word at a time.

Double-clicking on a word will select that word even if you click on the space between words. So clicking on the right-side of the space before a word will select that word. And similarly for the end of the word. Even if the word is a single character long, starting or ending the sentence, etc.

Corrections to allow better cursor keyboard movement and selection by word and mouse word selection by double-clicking. ---- Corrections to selection of word boundaries when inserting the text cursor, selecting words with keyboard and with the mouse. With this PR applied the following works as expected: Moving the text cursor a word at time backward (ctrl-left arrow) will generally move directly from the front of one word to the front of the previous word. Similarly pressing ctrl-right arrow will move directly from the end of one word to the end of the next word. Even if the word is only one character long. However if the text cursor is placed at the end of a word, pressing ctrl-left will move to the beginning of that same word. Pressing ctrl-right will move to the end of a word if you start from the beginning. Even if the word is only a single character long. Holding shift while using ctrl-left or ctrl-right will select a word at a time. Double-clicking on a word will select that word even if you click on the space between words. So clicking on the right-side of the space before a word will select that word. And similarly for the end of the word. Even if the word is a single character long, starting or ending the sentence, etc.

Harley Acheson added 1 commit 2023-05-02 00:08:46 +02:00

ad02f4757d VFONT: Text Object Word Selection

Corrections to allow better cursor keyboard movement and selection by
word and mouse word selection by double-clicking.

Harley Acheson requested review from Campbell Barton 2023-05-02 00:08:55 +02:00

Harley Acheson added this to the User Interface project 2023-05-02 00:09:03 +02:00

Campbell Barton commented

2023-05-04 05:57:28 +02:00

This makes Ctrl-Arrow key cursor motion fail when stepping over multiple spaces (the cursor stops early).
It should be possible to fix this without changing move_cursor at all.

It should be enough not to step forward/back if there is immediately before/after the cursor, the initial single character forward step also doesn't seem necessary.

Checking how firefox responds to double-clicking on whitespace, it moves the cursor backwards and select the word behind the cursor (not essential for the fix, but seems a reasonable default).

This makes Ctrl-Arrow key cursor motion fail when stepping over multiple spaces (the cursor stops early). It should be possible to fix this without changing `move_cursor` at all. It should be enough not to step forward/back if there is immediately before/after the cursor, the initial single character forward step also doesn't seem necessary. Checking how firefox responds to double-clicking on whitespace, it moves the cursor backwards and select the word behind the cursor (not essential for the fix, but seems a reasonable default).

Harley Acheson added 1 commit 2023-05-07 23:34:32 +02:00

5d1adb4c76 Updated to incorporate changes suggested by review

Harley Acheson commented

2023-05-07 23:36:42 +02:00

@ideasman42 - It should be possible to fix this without changing move_cursor at all.

Not really because there are errors built into that function with its use of use_init_step for BLI_str_cursor_step_utf32.

If you start with an older version of Blender, like 3.5, before we started mucking around. Ctrl-arrow movement seems to work mostly okay but there are errors. If starting at either side of a single-character word it will move one character too far.

Similarly if your cursor is between the second and third character of a word, pressing ctrl-left will move to the beginning of the word. But if between the first and second character hitting ctrl-left will move to the end of the previous word. The same thing happens if just before the last character of a word, versus the second-to-last, and pressing ctrl-right.

It should be enough not to step forward/back if there is immediately before/after the cursor...

I updated this PR with a font_select_word_exec that is probably the kind of simple thing you are expecting, while only having minimal changes to move_cursor that I am hoping make sense. PREV_WORD and NEXT_WORD are just changed not do that init_step in most cases.

> @ideasman42 - It should be possible to fix this without changing move_cursor at all. Not really because there are errors built into that function with its use of `use_init_step` for `BLI_str_cursor_step_utf32`. If you start with an older version of Blender, like 3.5, before we started mucking around. Ctrl-arrow movement _seems_ to work mostly okay but there are errors. If starting at either side of a single-character word it will move one character too far. Similarly if your cursor is between the second and third character of a word, pressing ctrl-left will move to the beginning of the word. But if between the first and second character hitting ctrl-left will move to the end of the previous word. The same thing happens if just before the last character of a word, versus the second-to-last, and pressing ctrl-right. > It should be enough not to step forward/back if there is immediately before/after the cursor... I updated this PR with a `font_select_word_exec` that is probably the kind of simple thing you are expecting, while only having minimal changes to `move_cursor` that I am hoping make sense. PREV_WORD and NEXT_WORD are just changed not do that init_step in most cases.

Campbell Barton commented

2023-05-08 02:02:44 +02:00

@ideasman42 - It should be possible to fix this without changing move_cursor at all.

Not really because there are errors built into that function with its use of use_init_step for BLI_str_cursor_step_utf32.

If your proposing functionality changes I rather this be handled separately, the behavior your pointing out is matched in the text-editor, python-console & text fields.

The logic is that Ctrl motion that would take a single step, always step over that character (as there is no need to hold Ctrl if a single character needed to be stepped over). Changing this may be fine but it's a separate matter.

It might be simplest not to use word stepping logic and instead and check the white space directly.

> > @ideasman42 - It should be possible to fix this without changing move_cursor at all. > > Not really because there are errors built into that function with its use of `use_init_step` for `BLI_str_cursor_step_utf32`. If your proposing functionality changes I rather this be handled separately, the behavior your pointing out is matched in the text-editor, python-console & text fields. The logic is that Ctrl motion that would take a single step, always step over that character (as there is no need to hold Ctrl if a single character needed to be stepped over). Changing this may be fine but it's a separate matter. It might be simplest not to use word stepping logic and instead and check the white space directly.

Harley Acheson commented

2023-05-08 22:00:54 +02:00

If your proposing functionality changes I rather this be handled separately, the behavior your pointing out is matched in the text-editor, python-console & text fields.

Yes, it is the same behavior all over. Following shows where the cursor goes when using Ctrl-Arrows. The incorrect move shown in red happens everywhere.

It also result in this kind of behavior around one-letter words:

This all just comes from that use_init_step happening all the time, doing that initial one-character move without any testing. We always call BLI_str_cursor_step_utf8 and BLI_str_cursor_step_utf32 with that set true.

So fixing it is messy. But I'll post a PR that we can stare at and maybe think about how it could be less messy.

> If your proposing functionality changes I rather this be handled separately, the behavior your pointing out is matched in the text-editor, python-console & text fields. Yes, it is the same behavior all over. Following shows where the cursor goes when using Ctrl-Arrows. The incorrect move shown in red happens everywhere. ![WordBoundary1.png](/attachments/2f015dbe-18b5-4862-bb7a-04df48391d34) It also result in this kind of behavior around one-letter words: ![WordBoundary2.gif](/attachments/d221ed90-8aae-4743-94d5-aeef76a7d294) This all just comes from that use_init_step happening all the time, doing that initial one-character move without any testing. We always call `BLI_str_cursor_step_utf8` and `BLI_str_cursor_step_utf32` with that set true. So fixing it is messy. But I'll post a PR that we can stare at and maybe think about how it could be less messy.

WordBoundary2.gif

46 KiB

WordBoundary1.png

44 KiB

Harley Acheson changed title from ~~VFONT: Text Object Word Selection~~ to WIP: VFONT: Text Object Word Selection

2023-05-08 22:01:07 +02:00

Harley Acheson closed this pull request

2023-05-15 22:56:13 +02:00

Harley Acheson deleted branch TextWordSelect

2023-05-15 22:56:22 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: VFONT: Text Object Word Selection #107519

Pull request closed