UI: Text cursor behavior for Apple Devices #107522

Harley Acheson · 2023-05-02T02:21:22+02:00

Harley Acheson commented

2023-05-02 02:21:22 +02:00

MacOS-specific behavior for arrow keys, delete, and backspace. Alt/Opt
modifier to jump by word, CMD modifier to jump to beginning/end.

Idea and code largely by @Austin-Berenyi who has closed his own PR - #106724. His original comment:

UI: Adds expected text cursor behavior for Apple Devices

macOS uses different key modifier sets from Windows for moving a text cursor in text fields. This adds that support, and keeps the previous behavior for backward compatibility.

CMD modifier jumps all
ALT/OPT modifier jumps by delimiter
modifer + SHIFT jumps and selects
This also works with DELETE and BACKSPACE events.

MacOS-specific behavior for arrow keys, delete, and backspace. Alt/Opt modifier to jump by word, CMD modifier to jump to beginning/end. --- Idea and code largely by @Austin-Berenyi who has closed his own PR - #106724. His original comment: UI: Adds expected text cursor behavior for Apple Devices macOS uses different key modifier sets from Windows for moving a text cursor in text fields. This adds that support, and keeps the previous behavior for backward compatibility. CMD modifier jumps all ALT/OPT modifier jumps by delimiter modifer + SHIFT jumps and selects This also works with DELETE and BACKSPACE events.

Harley Acheson added 1 commit 2023-05-02 02:21:27 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

407d3585a1 UI: Text cursor behavior for Apple Devices

MacOS-specific behavior for arrow keys, delete, and backspace. Alt/Opt
modifier to jump by word, CMD modifier to jump to beginning/end.

Harley Acheson requested review from Ankit Meel 2023-05-02 02:22:02 +02:00

Harley Acheson added this to the User Interface project 2023-05-02 02:22:10 +02:00

Austin Berenyi commented

2023-05-02 06:21:37 +02:00

First-time contributor

@Harley thanks for resubmitting this. I wanted to let you know the only reason I closed my PR was because I was experiencing some git issues that were over my head, and felt it best to start over. But it will be quicker this way :) thanks for all your tips along the way. This was really informative and enjoyable. Hoping to contribute more in the future.

Harley Acheson commented

2023-05-02 17:00:59 +02:00

@Austin-Berenyi - thanks for resubmitting this

No worries. I just didn't want to lose track of this one as it seems like something our MacOS users would appreciate.

thanks for all your tips along the way. This was really informative and enjoyable

You are very welcome. I'm glad you enjoyed it.

Hoping to contribute more in the future

Yes please!

> @Austin-Berenyi - thanks for resubmitting this No worries. I just didn't want to lose track of this one as it seems like something our MacOS users would appreciate. > thanks for all your tips along the way. This was really informative and enjoyable You are very welcome. I'm glad you enjoyed it. > Hoping to contribute more in the future Yes please!

Ankit Meel commented

2023-05-02 20:46:54 +02:00

idea looks good.. I myself was bothered by the mismatch between other editors and blender code editor

Need to test it.

idea looks good.. I myself was bothered by the mismatch between other editors and blender code editor Need to test it.

Ankit Meel commented

2023-05-04 07:47:54 +02:00

The behaviour of shift/noshift + command/alt + arrow is the same as before

Also, in main too, alt + delete inserts space and moves cursor to the right.. probably a different bug. Same for this PR.

I set breakpoints in edited code and main code but they don't hit..

The behaviour of shift/noshift + command/alt + arrow is the same as before Also, in main too, alt + delete inserts space and moves cursor to the right.. probably a different bug. Same for this PR. I set breakpoints in edited code and main code but they don't hit..

Austin Berenyi commented

2023-05-06 20:56:23 +02:00

First-time contributor

@ankitm I believe text editor (Scripting workspace) behavior is handled by different code. You can change how the text cursor moves in the text editor in key mapping.

This pull request was originally intended to affect how the cursor behaves in text fields such as outliner names, material names, node group names, etc. It may be affecting how the cursor behaves in the text editor now.

@ankitm I believe text editor (Scripting workspace) behavior is handled by different code. You can change how the text cursor moves in the text editor in key mapping. This pull request was originally intended to affect how the cursor behaves in text fields such as outliner names, material names, node group names, etc. It may be affecting how the cursor behaves in the text editor now.

Ankit Meel commented

2023-05-06 20:57:57 +02:00

Halrley's discretion needed: I feel we should change it for all kinds of text fields/ workspaces at once.

Ankit Meel commented

2023-05-08 20:57:30 +02:00

There is an element of surprise due to change in cursor behaviour in different text contexts: console, text editor and text input. But at least it addressable with keymaps. I'll try to change the blender defaults in a different PR since I have the OS available.

Also will need to add DEL_PREV_LINE also. This change works fine

There is an element of surprise due to change in cursor behaviour in different text contexts: console, text editor and text input. But at least it addressable with keymaps. I'll try to change the blender defaults in a different PR since I have the OS available. Also will need to add DEL_PREV_LINE also. This change works fine

Ankit Meel approved these changes 2023-05-08 22:37:47 +02:00

Austin Berenyi commented

2023-05-24 04:44:49 +02:00

First-time contributor

@ankitm will further progress on this change happen here? Or is your plan to create an additional PR with more extensive changes? Looking forward to this!

Ankit Meel commented

2023-05-24 15:55:04 +02:00

I've approved the functioning with caveats.. committing is up to @Harley

Harley Acheson commented

2023-05-24 17:06:17 +02:00

@ankitm - I've approved the functioning with caveats..

I don't have a Mac so I'm really relying on you here. My gut feeling is that if you think this PR works as advertised then I should just land it today. But that does give some pressure on you, being our Mac interaction specialist, to try to fill in any similar gaps elsewhere that you can. But we do have a fairly long development cycle with 4.0.

> @ankitm - I've approved the functioning with caveats.. I don't have a Mac so I'm really relying on you here. My gut feeling is that if you think this PR works as advertised then I should just land it today. But that does give some pressure on _you_, being our Mac interaction specialist, to try to fill in any similar gaps elsewhere that you can. But we do have a fairly long development cycle with 4.0.

Ankit Meel commented

2023-05-24 19:21:04 +02:00

Please feel free to land it.. I'm okay with making the follow up changes

👍 1

Harley Acheson commented

2023-05-24 21:33:51 +02:00

@blender-bot build

Harley Acheson merged commit 0e8419246d into main

2023-05-24 22:25:50 +02:00

Harley Acheson referenced this issue from a commit

2023-05-24 22:25:50 +02:00

UI: Text cursor behavior for Apple Devices

Harley Acheson deleted branch MacArrows

2023-05-24 22:25:51 +02:00

Howard Trickey referenced this issue from a commit

2023-05-29 02:51:37 +02:00

Merge in orign/main:

Austin Berenyi commented

2023-07-16 23:34:17 +02:00

First-time contributor

@Harley are there plans to reinstate these changes? I remember seeing that you temporarily removed this functionality until further work could be done in some other places of the UI.

Harley Acheson commented

2023-07-17 00:06:49 +02:00

@Austin-Berenyi - we might be getting closer.

I think if we can get this in - #108626 - then we'll (finally) have some consistency between the various places that deal with text in Blender. And then it might the time to consider per-platform changes like this one... if those changes are for all parts of Blender. So the same per-platform shortcut has to work in UI inputs, 3D text, text editor, console. But that would then require a Mac developer.

@Austin-Berenyi - we might be getting closer. I think **if** we can get this in - https://projects.blender.org/blender/blender/pulls/108626 - then we'll (finally) have some consistency between the various places that deal with text in Blender. And then it might the time to consider per-platform changes like this one... if those changes are for all parts of Blender. So the same per-platform shortcut has to work in UI inputs, 3D text, text editor, console. But that would then require a Mac developer.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Text cursor behavior for Apple Devices #107522