Add the sm_89 arch to the default CUDA binaries #107585

Sebastian Parborg · 2023-05-03T17:38:30+02:00

Sebastian Parborg commented

2023-05-03 17:38:30 +02:00

Without this, support for newer NVIDIA cards will not be compiled with pre-compiling the CUDA binaries.

Sebastian Parborg added 1 commit 2023-05-03 17:38:37 +02:00

Add the sm_89 arch to the default CUDA binaries

buildbot/vexp-code-patch-coordinator Build done.

Details

7433e8d558

Without this, support for newer NVIDIA cards will not be compiled with pre-compiling the CUDA binaries.

Sebastian Parborg requested review from Brecht Van Lommel 2023-05-03 17:38:44 +02:00

Sebastian Parborg added this to the Render & Cycles project 2023-05-03 17:38:52 +02:00

Sebastian Parborg commented

2023-05-03 17:57:15 +02:00

@blender-bot build

Brecht Van Lommel commented

2023-05-03 18:25:44 +02:00

@blender-bot package

Blender Bot commented

2023-05-03 18:25:47 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR107585) when ready.

Brecht Van Lommel commented

2023-05-03 19:08:02 +02:00

We'll have to upgrade to a newer CUDA version to support this architecture. I'll put it on my todo list.

Sebastian Parborg commented

2023-05-03 19:43:15 +02:00

Hmm it works on my computer. I guess it might be because I have a newer cuda-toolkit (12.1) perhaps?

EDIT: Gah, the page didn't refresh automatically so I didn't see that you had replied already stating the same thing.

Hmm it works on my computer. I guess it might be because I have a newer cuda-toolkit (12.1) perhaps? EDIT: Gah, the page didn't refresh automatically so I didn't see that you had replied already stating the same thing.

Sergey Sharybin added 1 commit 2023-05-10 18:24:42 +02:00

Point the latest CUDA toolkit to the 12.1.1

buildbot/vexp-code-patch-coordinator Build done.

Details

6cafb3a6bf

The configuration key naming is a bit misleading: it is called cuda11
but from the find_package perspective and some other semantic meaning
it actually means the latest cuda.

We should consider renaming the option, but it is to be done outside
of the scope of this patch.

Sergey Sharybin commented

2023-05-10 19:05:25 +02:00

@blender-bot package

Blender Bot commented

2023-05-10 19:05:28 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR107585) when ready.

Sergey Sharybin requested changes 2023-05-10 19:58:39 +02:00

Sergey Sharybin left a comment

Good news: CUDA 12 is installed on all currently available Rocky and Windows workers.

Bad news: it does not seem we can avoid having 3 version of CUDA. With the current configuration the sm_36 and sm_37 are silently (!) missing.

I would need to work further on the build pipeline on the bot side to allow specifying cuda10, cuda11, and cuda12. And somehow do it in a way that does not interfere with LTS builders.

Marking as requested changes to indicate that the current code should not be merged.

EDIT: Not dully silently, there is a print about it, but it is so easy to miss..

Good news: CUDA 12 is installed on all currently available Rocky and Windows workers. Bad news: it does not seem we can avoid having 3 version of CUDA. With the current configuration the sm_36 and sm_37 are silently (!) missing. I would need to work further on the build pipeline on the bot side to allow specifying cuda10, cuda11, and cuda12. And somehow do it in a way that does not interfere with LTS builders. Marking as requested changes to indicate that the current code should not be merged. EDIT: Not dully silently, there is a print about it, but it is so easy to miss..

Sergey Sharybin added 1 commit 2023-05-11 09:14:52 +02:00

More correct CUDA configuration e995493150

Specify both CUDA11 and CUDA12 configurations.

Sergey Sharybin added 1 commit 2023-05-11 10:47:53 +02:00

Prefer using default CUDA for sm_8*

buildbot/vexp-code-patch-coordinator Build done.

Details

f0a51cc16f

Previously, the sm_8* was compiled using provided CUDA11, which does not
support sm_89.

Sergey Sharybin commented

2023-05-11 11:39:21 +02:00

@blender-bot package

Blender Bot commented

2023-05-11 11:39:23 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR107585) when ready.

Sergey Sharybin approved these changes 2023-05-11 13:29:54 +02:00

Sergey Sharybin left a comment

The Windows build succeeded after the "Rebuild" on the buildbot (it was some intermittent problem on the worker).

Both Linux and Windows now have full set of CUDA kernels.

From my side the code is good to go.

The Windows build succeeded after the "Rebuild" on the buildbot (it was some intermittent problem on the worker). Both Linux and Windows now have full set of CUDA kernels. From my side the code is good to go.

Brecht Van Lommel approved these changes 2023-05-11 13:44:56 +02:00

Brecht Van Lommel left a comment

Thanks!

Sergey Sharybin merged commit 84c5953882 into main

2023-05-12 16:30:31 +02:00

Sergey Sharybin deleted branch Cuda_sm_89

2023-05-12 16:30:32 +02:00

Sergey Sharybin referenced this issue from a commit

2023-05-12 16:30:40 +02:00

Add the sm_89 arch to the default CUDA binaries

Brecht Van Lommel removed this from the Render & Cycles project 2023-05-24 19:05:21 +02:00

Howard Trickey referenced this issue from a commit