Audaspace: Load CoreAudio device on demand #107607

Refactor CoreAudioDevice code to support on demand device opening and
closing when sound is not playing.

Currently device is opened when AUD_init() is called and then closed
immediately. This is because it seems, that this is causing issues with
synchronizer and causes AV sync to fail.

Anothe issue seems to be usage of audio scrubbing. This seems to confuse the device and it fails to play audio at all after some time. For WASAPI this was also problematic and a solution could be to create a timer in new thread, that would delay closing of the device.

Refactor CoreAudioDevice code to support on demand device opening and closing when sound is not playing. Currently device is opened when AUD_init() is called and then closed immediately. This is because it seems, that this is causing issues with synchronizer and causes AV sync to fail. Anothe issue seems to be usage of audio scrubbing. This seems to confuse the device and it fails to play audio at all after some time. For WASAPI this was also problematic and a solution could be to create a timer in new thread, that would delay closing of the device.

@blender-bot package

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR107607) when ready.

Please follow the code style of audaspace and do not apply Blender's clang format in this file. This leads to way too many changes in this file. Audaspace has it's own clang format changes, but you should only format actually changed code.

I'd also name the methods simply open and close, the Device is superfluous and the open function is not on demand, it just opens.

Apart from that, the changes look good as far as I can tell. Cannot try it, since I lack the hardware though.

Please follow the code style of audaspace and do not apply Blender's clang format in this file. This leads to way too many changes in this file. Audaspace has it's own clang format changes, but you should only format actually changed code. I'd also name the methods simply `open` and `close`, the Device is superfluous and the open function is not on demand, it just opens. Apart from that, the changes look good as far as I can tell. Cannot try it, since I lack the hardware though.

@neXyon Hi, this should be ready to review,.Can you have a look?

Please fix the formatting first as I mentioned before, otherwise it's hard to read the diff.

@neXyon Sorry I was pretty sure I did that, but I was wrong. Would you in future accept plain cleanup patch to format the file? Otherwise I have to undo unintended changes manually which is bit tedious.

Not sure what you mean? Do you mean running clang-format as auto-formatter? Clang format can also be run on just the changes in a diff which would be ideal here. So, can you apply the cleanup patch here already?

Not sure what you mean?

I meant to make the files conform to format rules before I make any changes to files. I don't have IDE setup to work on Audaspace code, and MSVC is ignoring clang format currently anyway. Not sure if I broke the addon somehow. It's just in Blender we like to keep our code formatted at all times, so I thought about doing same thing in this case.

So, can you apply the cleanup patch here already?

OMG I forgot to commit changes before pushing :D

> Not sure what you mean? I meant to make the files conform to format rules before I make any changes to files. I don't have IDE setup to work on Audaspace code, and MSVC is ignoring clang format currently anyway. Not sure if I broke the addon somehow. It's just in Blender we like to keep our code formatted at all times, so I thought about doing same thing in this case. > So, can you apply the cleanup patch here already? OMG I forgot to commit changes before pushing :D

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Audaspace: Load CoreAudio device on demand #107607

Reviewers