UI: fix a few messages #107699

Merged
Hans Goudey merged 1 commits from pioverfour/blender:dp_fix_messages into main 2023-05-07 15:27:36 +02:00
Member
  • The official spelling of FFMPEG is FFmpeg (upper, then lower case).
  • The normal vector copy and paste operators shoud be singular because
    they can only be used on a single element.
  • The "Parent File" file browser operator goes up one level in the
    file hierarchy. It should be called "Parent Directory", like the
    current description "Go to the parent directory".
  • "Mass Vertex Group" used to define the mass, but was reused at some
    point and now actually defines cloth pinning so it should be called
    "Pin Vertex Group", as in the UI.
  • The Transformation constraint's Map To Type suffered from a
    typo (probably of -> on).
  • "Fall-off" is more commonly spelled "Falloff".
  • "Effected" should really be "Affected" in this case.
  • Rephrase the descriptions for the curve painting tools drawing
    plane, which did not seem to match what the settings do. Namely,
    they allow selecting in which plane to draw curves using the Curve
    Draw tool.

Reported by @Joan-Pujolar in #43295:

  • Force exporting animation on every objects [objects singular]
  • Color of the interface widgets text insertion cursor (caret) [delete
    interface widgets]
  • Index of active aov [AOV in uppercase everywhere else]
  • Does this tool use an painting canvas [an]
  • This script was written Blender version %d.%d.%d ["for" missing
    before "Blender"]
  • [fcurve -> F-curve]
  • unknown error stating file [statting]
  • Offset into each stroke before the beginning of the dashed segment
    generation [Two spaces between of and the]
  • Find the nearest element in the a group. [either "the" or "a"]
- The official spelling of FFMPEG is FFmpeg (upper, then lower case). - The normal vector copy and paste operators shoud be singular because they can only be used on a single element. - The "Parent File" file browser operator goes up one level in the file hierarchy. It should be called "Parent Directory", like the current description "Go to the parent directory". - "Mass Vertex Group" used to define the mass, but was reused at some point and now actually defines cloth pinning so it should be called "Pin Vertex Group", as in the UI. - The Transformation constraint's Map To Type suffered from a typo (probably of -> on). - "Fall-off" is more commonly spelled "Falloff". - "Effected" should really be "Affected" in this case. - Rephrase the descriptions for the curve painting tools drawing plane, which did not seem to match what the settings do. Namely, they allow selecting in which plane to draw curves using the Curve Draw tool. Reported by @Joan-Pujolar in #43295: - Force exporting animation on every objects [objects singular] - Color of the interface widgets text insertion cursor (caret) [delete interface widgets] - Index of active aov [AOV in uppercase everywhere else] - Does this tool use an painting canvas [an] - This script was written Blender version %d.%d.%d ["for" missing before "Blender"] - [fcurve -> F-curve] - unknown error stating file [statting] - Offset into each stroke before the beginning of the dashed segment generation [Two spaces between of and the] - Find the nearest element in the a group. [either "the" or "a"]
Damien Picard added the
Module
User Interface
label 2023-05-07 12:36:07 +02:00
Damien Picard added 1 commit 2023-05-07 12:36:15 +02:00
98d7cb57fa UI: fix a few messages
- The official spelling of FFMPEG is FFmpeg (upper, then lower case).
- The normal vector copy and paste operators shoud be singular because
  they can only be used on a single element.
- The "Parent File" file browser operator goes up one level in the
  file hierarchy. It should be called "Parent Directory", like the
  current description "Go to the parent directory".
- "Mass Vertex Group" used to define the mass, but was reused at some
  point and now actually defines cloth pinning so it should be called
  "Pin Vertex Group", as in the UI.
- The Transformation constraint's Map To Type suffered from a
  typo (probably of -> on).
- "Fall-off" is more commonly spelled "Falloff".
- "Effected" should really be "Affected" in this case.
- Rephrase the descriptions for the curve painting tools drawing
  plane, which did not seem to match what the settings do. Namely,
  they allow selecting in which plane to draw curves using the Curve
  Draw tool.

Reported by @Joan-Pujolar in #43295:
- Force exporting animation on every objects [objects singular]
- Color of the interface widgets text insertion cursor (caret) [delete
  interface widgets]
- Index of active aov [AOV in uppercase everywhere else]
- Does this tool use an painting canvas [an]
- This script was written Blender version %d.%d.%d ["for" missing
  before "Blender"]
- [fcurve -> F-curve]
- unknown error stating file [statting]
- Offset into each stroke before the beginning of  the dashed segment
  generation [Two spaces between of and the]
- Find the nearest element in the a group. [either "the" or "a"]
Damien Picard reviewed 2023-05-07 12:48:23 +02:00
@ -18,3 +18,3 @@
class RENDER_PT_ffmpeg_presets(PresetPanel, Panel):
bl_label = "FFMPEG Presets"
bl_label = "FFmpeg Presets"
Author
Member

The official spelling of FFMPEG is FFmpeg (upper, then lower case).

The official spelling of FFMPEG is FFmpeg (upper, then lower case).
@ -4512,2 +4512,2 @@
layout.operator("mesh.normals_tools", text="Copy Vectors").mode = 'COPY'
layout.operator("mesh.normals_tools", text="Paste Vectors").mode = 'PASTE'
layout.operator("mesh.normals_tools", text="Copy Vector").mode = 'COPY'
layout.operator("mesh.normals_tools", text="Paste Vector").mode = 'PASTE'
Author
Member

The normal vector copy and paste operators should be singular because they can only be used on a single element.

The normal vector copy and paste operators should be singular because they can only be used on a single element.
@ -1220,3 +1221,3 @@
rd->ffcodecdata.audio_mixrate != 48000 && rd->ffcodecdata.audio_channels != 2)
{
BKE_report(reports, RPT_ERROR, "FFMPEG only supports 48khz / stereo audio for DV!");
BKE_report(reports, RPT_ERROR, "FFmpeg only supports 48khz / stereo audio for DV!");
Author
Member

The official spelling of FFMPEG is FFmpeg (upper, then lower case).

The official spelling of FFMPEG is FFmpeg (upper, then lower case).
@ -278,3 +278,3 @@
if ((ptr->owner_id == NULL) && (ptr->data == NULL)) {
BKE_report(reports, RPT_ERROR, "No RNA pointer available to retrieve values for this fcurve");
BKE_report(reports, RPT_ERROR, "No RNA pointer available to retrieve values for this F-curve");
Author
Member

Replace "fcurve" by "F-Curve" as this spelling is much more common throughout the codebase.

Replace "fcurve" by "F-Curve" as this spelling is much more common throughout the codebase.
@ -289,3 +289,3 @@
BKE_reportf(reports,
RPT_ERROR,
"Could not update flags for this fcurve, as RNA path is invalid for the given ID "
"Could not update flags for this F-curve, as RNA path is invalid for the given ID "
Author
Member

Replace "fcurve" by "F-Curve" as this spelling is much more common throughout the codebase.

Replace "fcurve" by "F-Curve" as this spelling is much more common throughout the codebase.
@ -2254,3 +2254,3 @@
{
/* identifiers */
ot->name = "Parent File";
ot->name = "Parent Directory";
Author
Member

The "Parent File" file browser operator goes up one level in the file hierarchy. It should be called "Parent Directory", like the current description "Go to the parent directory".

The "Parent File" file browser operator goes up one level in the file hierarchy. It should be called "Parent Directory", like the current description "Go to the parent directory".
@ -932,3 +932,3 @@
1,
"Select Curves",
"Allow selecting all the keyframes of a curve by selecting the calculated fcurve");
"Allow selecting all the keyframes of a curve by selecting the calculated F-curve");
Author
Member

Replace "fcurve" by "F-Curve" as this spelling is much more common throughout the codebase.

Replace "fcurve" by "F-Curve" as this spelling is much more common throughout the codebase.
@ -649,3 +649,3 @@
"Unable to stat '%s': %s",
filepath,
errno ? strerror(errno) : TIP_("unknown error stating file"));
errno ? strerror(errno) : TIP_("unknown error statting file"));
Author
Member

Although "stat" is uncommon, its present participle should probably be "statting"
See e.g. https://en.wiktionary.org/wiki/stat#Verb

Although "stat" is uncommon, its present participle should probably be "statting" See e.g. https://en.wiktionary.org/wiki/stat#Verb
@ -649,3 +649,3 @@
"rna_ClothSettings_mass_vgroup_set");
RNA_def_property_override_clear_flag(prop, PROPOVERRIDE_OVERRIDABLE_LIBRARY);
RNA_def_property_ui_text(prop, "Mass Vertex Group", "Vertex Group for pinning of vertices");
RNA_def_property_ui_text(prop, "Pin Vertex Group", "Vertex Group for pinning of vertices");
Author
Member

"Mass Vertex Group" used to define the mass, but was reused at some point and now actually defines cloth pinning so it should be called "Pin Vertex Group", as in the UI.

"Mass Vertex Group" used to define the mass, but was reused at some point and now actually defines cloth pinning so it should be called "Pin Vertex Group", as in the UI.
@ -2238,3 +2238,3 @@
RNA_def_property_enum_items(prop, transform_items);
RNA_def_property_ui_text(
prop, "Map To", "The transformation type to affect of the constrained object");
prop, "Map To", "The transformation type to affect on the constrained object");
Author
Member

Typo

Typo
@ -38,3 +38,3 @@
}
else if (fcu->fpt) {
BKE_report(reports, RPT_WARNING, "FCurve has already sample points");
BKE_report(reports, RPT_WARNING, "F-Curve already has sample points");
Author
Member

Replace "fcurve" by "F-Curve" as this spelling is much more common throughout the codebase.

Replace "fcurve" by "F-Curve" as this spelling is much more common throughout the codebase.
@ -55,3 +55,3 @@
}
else if (fcu->bezt) {
BKE_report(reports, RPT_WARNING, "FCurve has already keyframes");
BKE_report(reports, RPT_WARNING, "F-Curve already has keyframes");
Author
Member

More natural word order.

More natural word order.
@ -4275,3 +4275,3 @@
prop,
"Offset",
"Offset into each stroke before the beginning of the dashed segment generation");
"Offset into each stroke before the beginning of the dashed segment generation");
Author
Member

Two spaces between "of" and "the"

Two spaces between "of" and "the"
@ -1519,3 +1519,3 @@
RNA_def_property_enum_sdna(prop, NULL, "falloff");
RNA_def_property_enum_items(prop, falloff_items);
RNA_def_property_ui_text(prop, "Fall-Off", "");
RNA_def_property_ui_text(prop, "Falloff", "");
Author
Member

"Fall-off" is more commonly spelled "Falloff".

"Fall-off" is more commonly spelled "Falloff".
@ -1728,3 +1728,3 @@
RNA_def_property_boolean_sdna(prop, NULL, "flag", PFIELD_MULTIPLE_SPRINGS);
RNA_def_property_ui_text(
prop, "Multiple Springs", "Every point is effected by multiple springs");
prop, "Multiple Springs", "Every point is affected by multiple springs");
Author
Member

"Effected" should really be "Affected" in this case.

"Effected" should really be "Affected" in this case.
@ -4069,0 +4069,4 @@
"VIEW",
0,
"View",
"Draw in a plane aligned to the viewport"},
Author
Member

Rephrase the descriptions for the curve painting tools drawing plane, which did not match what the settings do. Namely, they allow selecting in which plane to draw curves using the Curve Draw tool.

Rephrase the descriptions for the curve painting tools drawing plane, which did not match what the settings do. Namely, they allow selecting in which plane to draw curves using the Curve Draw tool.
@ -4438,3 +4442,3 @@
"rna_ViewLayer_active_aov_index_set",
"rna_ViewLayer_active_aov_index_range");
RNA_def_property_ui_text(prop, "Active AOV Index", "Index of active aov");
RNA_def_property_ui_text(prop, "Active AOV Index", "Index of active AOV");
Author
Member

AOV is in uppercase everywhere else

AOV is in uppercase everywhere else
@ -1610,3 +1610,2 @@
RNA_def_property_array(prop, 3);
RNA_def_property_ui_text(
prop, "Text Cursor", "Color of the interface widgets text insertion cursor (caret)");
RNA_def_property_ui_text(prop, "Text Cursor", "Color of the text insertion cursor (caret)");
Author
Member

Simplify poor wording.

Simplify poor wording.
@ -303,3 +303,3 @@
RNA_def_property_ui_text(prop, "Index", "");
RNA_def_property_boolean_funcs(prop, "rna_WorkSpaceTool_use_paint_canvas_get", NULL);
RNA_def_property_ui_text(prop, "Use Paint Canvas", "Does this tool use an painting canvas");
RNA_def_property_ui_text(prop, "Use Paint Canvas", "Does this tool use a painting canvas");
Author
Member

Typo.

Typo.
@ -325,3 +325,3 @@
DefNode(GeometryNode, GEO_NODE_IMAGE_INFO, 0, "IMAGE_INFO", ImageInfo, "Image Info", "Retrieve information about an image")
DefNode(GeometryNode, GEO_NODE_IMAGE_TEXTURE, def_geo_image_texture, "IMAGE_TEXTURE", ImageTexture, "Image Texture", "Sample values from an image texture")
DefNode(GeometryNode, GEO_NODE_INDEX_OF_NEAREST, 0, "INDEX_OF_NEAREST", IndexOfNearest, "Index of Nearest", "Find the nearest element in the a group. Similar to the \"Sample Nearest\" node")
DefNode(GeometryNode, GEO_NODE_INDEX_OF_NEAREST, 0, "INDEX_OF_NEAREST", IndexOfNearest, "Index of Nearest", "Find the nearest element in a group. Similar to the \"Sample Nearest\" node")
Author
Member

Typo.

Typo.
Damien Picard requested review from Hans Goudey 2023-05-07 12:49:01 +02:00
Hans Goudey approved these changes 2023-05-07 15:26:15 +02:00
Hans Goudey left a comment
Member

You make these very easy to review, thanks!

It's just in your comments in this PR, but since we're talking about language here, usually "replace X with" is preferred compared to "replace X by": https://english.stackexchange.com/questions/151309/replace-with-versus-replace-by

You make these very easy to review, thanks! It's just in your comments in this PR, but since we're talking about language here, usually "replace X with" is preferred compared to "replace X by": https://english.stackexchange.com/questions/151309/replace-with-versus-replace-by
Hans Goudey merged commit 31d71f39ad into main 2023-05-07 15:27:36 +02:00
Damien Picard deleted branch dp_fix_messages 2023-05-07 15:42:35 +02:00
Author
Member

usually "replace X with" is preferred compared to "replace X by": https://english.stackexchange.com/questions/151309/replace-with-versus-replace-by

Thanks, that rule is still fuzzy to me so I tend to use a calque from French. I’ll try to be more careful!

> usually "replace X with" is preferred compared to "replace X by": https://english.stackexchange.com/questions/151309/replace-with-versus-replace-by Thanks, that rule is still fuzzy to me so I tend to use a calque from French. I’ll try to be more careful!
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:41 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107699
No description provided.