Fix #107289: Sound strips are invisible and overlap #107798

Merged

Richard Antalik merged 4 commits from iss/blender:107289 into main

2023-05-09 22:14:23 +02:00

Richard Antalik commented

2023-05-09 21:50:36 +02:00

Member

In some cases strips may end up with speed factor of 0 which causes
offsets and position to be invalid. The exact cause is unknown, but
most likely caused by do_versions_sequencer_init_retiming_tool_data().

This could possibly happen if 3.6 file is saved with 3.5 version and
then opened again with 3.6 version.

To fix strips, retiming data is removed, start offset reset and speed
factor is set to 1. Previous versioning code is fixed, so speed factor
is never set to 0.

In some cases strips may end up with speed factor of 0 which causes offsets and position to be invalid. The exact cause is unknown, but most likely caused by `do_versions_sequencer_init_retiming_tool_data()`. This could possibly happen if 3.6 file is saved with 3.5 version and then opened again with 3.6 version. To fix strips, retiming data is removed, start offset reset and speed factor is set to 1. Previous versioning code is fixed, so speed factor is never set to 0.

Richard Antalik added 2 commits 2023-05-09 21:50:45 +02:00

694e29dfd0 Fix #107289 : Sound strips are invisible and overlap

In some cases strips may end up with speed factor of 0 which causes
offsets and position to be invalid. The exact cause is unknown, but
most likely caused by `do_versions_sequencer_init_retiming_tool_data()`.

This could possibly happen if 3.6 file is saved with 3.5 version and
then opened again with 3.6 version.

To fix strips, sound length is reloaded, offsets stripped and speed
factor is set to 1. Previous versioning code is fixed, so speed factor is never set to 0.

393817421d I have localized the issue with greater certainty, so now this fix

should be applicable

Richard Antalik added 1 commit 2023-05-09 22:00:47 +02:00

6a282bbd73 Failed to ammend changes

Richard Antalik added 1 commit 2023-05-09 22:03:33 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

3cb8330212 Merge branch 'main' into 107289

Richard Antalik commented

2023-05-09 22:06:39 +02:00

Author

Member

@blender-bot package

@blender-bot package

Blender Bot commented

2023-05-09 22:06:41 +02:00

Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR107798) when ready.

Richard Antalik merged commit c9be925f7d into main

2023-05-09 22:14:23 +02:00

Richard Antalik deleted branch 107289

2023-05-09 22:14:26 +02:00

Richard Antalik referenced this issue from a commit

2023-05-09 22:14:31 +02:00

Fix #107289: Sound strips are invisible and overlap

Colin Basnett referenced this issue from a commit

2023-05-13 21:43:56 +02:00

Fix #107289: Sound strips are invisible and overlap

Howard Trickey referenced this issue from a commit

2023-05-29 02:51:41 +02:00

Merge in orign/main:

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107798

No description provided.