Use utm_source=blender to urls pointing to blender.org #107849

Dalai Felinto · 2023-05-11T17:16:36+02:00

Dalai Felinto commented

2023-05-11 17:16:36 +02:00

This fuctionality allow the Blender project to know if users
are reaching our websites from within Blender:

User Manual
Python API
Release Notes
Development Fund

Right now we always pass "blender" as the utm_source. We can later pass the version/branch if relevant.

This fuctionality allow the Blender project to know if users are reaching our websites from within Blender: * User Manual * Python API * Release Notes * Development Fund Right now we always pass "blender" as the utm_source. We can later pass the version/branch if relevant.

👍 1

Dalai Felinto added 1 commit 2023-05-11 17:16:42 +02:00

f051745bb6 Cleanup: Unify operators to use wm.url_open

Sergey Sharybin was assigned by Dalai Felinto

2023-05-11 17:16:50 +02:00

Ray molenkamp reviewed 2023-05-11 17:22:21 +02:00

scripts/startup/bl_operators/wm.py Outdated

						
				@ -1021,0 +1031,4 @@

				        domain = parsed_url.netloc

				        # Only add a utm source if it points to a blender.org domain.

				        if not domain.endswith("blender.org"):

Ray molenkamp commented

2023-05-11 17:22:21 +02:00

if not domain.endswith(".blender.org"):

otherwise this would still add it to "https://ohno.totally.notblender.org" which is probably not what we want

`if not domain.endswith(".blender.org"):` otherwise this would still add it to "https://ohno.totally.notblender.org" which is probably not what we want

Dalai Felinto commented

2023-05-11 17:27:01 +02:00

good point, I now check for .blender.org or if the entire domain is blender.org (in case someone forgets to use www.)

Dalai Felinto force-pushed web-development from 50eda5d669 to b2d97b7711

2023-05-11 17:26:38 +02:00

Compare

Dalai Felinto force-pushed web-development from aa50b727bb to b2d97b7711

2023-05-11 17:28:19 +02:00

Compare

Pablo Vazquez commented

2023-05-11 17:57:23 +02:00

Nice! Having the version and cycle would be so handy to know, especially for LTS.

Replacing:

@staticmethod
def _get_utm_source():
  return "blender"

With:

@staticmethod
def _get_utm_source():
  version = '.'.join([str(i) for i in bpy.app.version])
  cycle = bpy.app.version_cycle
  blender = f"blender-{version}-{cycle}"

  return blender

To return blender-3.6.0-alpha, blender-3.3.16-release, etc. instead of just blender.

Nice! Having the version and cycle would be so handy to know, especially for LTS. Replacing: ```python @staticmethod def _get_utm_source(): return "blender" ``` With: ```python @staticmethod def _get_utm_source(): version = '.'.join([str(i) for i in bpy.app.version]) cycle = bpy.app.version_cycle blender = f"blender-{version}-{cycle}" return blender ``` To return `blender-3.6.0-alpha`, `blender-3.3.16-release`, etc. instead of just `blender`.

Sergey Sharybin commented

2023-05-12 09:35:56 +02:00

If you go with the version string use bpy.app.version_string instead of re-implementing the logic.

But the actual question is what is the actual final goal.

The version and release cycle, as well as platform, branch name, GPU, build hash are already encoded into the URL. And that information is not at any less importance for the development. Re-encoding all this information in utm_source does not really sound like the goodest idea.

If you go with the version string use `bpy.app.version_string` instead of re-implementing the logic. But the actual question is what is the actual final goal. The version and release cycle, as well as platform, branch name, GPU, build hash are already encoded into the URL. And that information is not at any less importance for the development. Re-encoding all this information in utm_source does not really sound like the goodest idea.

Dalai Felinto commented

2023-05-12 09:39:16 +02:00

Hi @Sergey,

The version and release cycle, as well as platform, branch name, GPU, build hash are already encoded into the UR

This is only the case for the bug reports. The same doesn' t apply for all the other links we have to the other parts of blender.org.

Hi @Sergey, > The version and release cycle, as well as platform, branch name, GPU, build hash are already encoded into the UR This is only the case for the bug reports. The same doesn' t apply for all the other links we have to the other parts of blender.org.

Dalai Felinto added 1 commit 2023-05-12 09:57:08 +02:00

5a99c1e0dc utm_source: use blender version as part of the URL

This makes the URL links to blender.org to have more information than
just utm_source=blender

For example:
* utm_source=blender-3.6.0-alpha
* utm_source=blender-3.3.16-release

Dalai Felinto commented

2023-05-12 10:04:14 +02:00

Incorporated Pablo's suggestion as a separate commit (using bpy.app.version_string as a start point, but making it lower case and to use -).

Incorporated Pablo's suggestion as a separate commit (using bpy.app.version_string as a start point, but making it lower case and to use `-`).

Sergey Sharybin commented

2023-05-12 11:34:38 +02:00

This is only the case for the bug reports. The same doesn' t apply for all the other links we have to the other parts of blender.org.

This is a good point.

> This is only the case for the bug reports. The same doesn' t apply for all the other links we have to the other parts of blender.org. This is a good point.

Sergey Sharybin approved these changes 2023-05-12 15:25:07 +02:00

Dalai Felinto referenced this issue from a commit

2023-05-12 15:35:31 +02:00

Introduce utm_source=blender to urls pointing to blender.org

Dalai Felinto referenced this issue from a commit

2023-05-12 15:35:31 +02:00

utm_source: use blender version as part of the URL

Dalai Felinto commented

2023-05-12 15:36:13 +02:00

Commited as:

Commited as: * cbd838d077b108fca8bba8f543c18ee1fdf0985b * a15c637e63798f61aebb777aca54acaed3bf562c * 676c6d8e9a9a08ad035496fe3ad0e23814a882cf

Dalai Felinto closed this pull request