CMake: plumbing for modern CMake usage #107858
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#107858
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "LazyDodo/blender:tmp_modern_cmake"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is the minimal change required to start using modern CMake in the
blender build system. This change is designed to allow small
incremental changes to the build system rather than doing it in one
big bang which would be unmaintainable (for me)
The biggest functional change is, previously all libraries in the
LIB
section of ablender_add_lib
call had theINTERFACE
scope,which is rarely, if ever the correct scope. This diff changes this to
PRIVATE
Concrete implications of this diff :
The
LIB
,INC
andINC_SYS
sections of anblender_add_lib
callnow allow scoping keywords (
PUBLIC
,PRIVATE,
INTERFACE
) todeclare the scope of the dependency.
Right now the only library using any modern cmake is
bf_intern_atomic
which is an header only interface library that willjust advertise its include directories.
This allows us to clean up any
CMakeLists.txt
that adds../../../intern/atomic
to itsINC
section to remove it inINC
byadding a
PRIVATE bf_intern_atomic
to theLIB
section.@blender-bot package
Package build started. Download here when ready.
This all seems reasonable, if builds & tests pass, LGTM.
@ -506,0 +530,4 @@
)
blender_add_test_executable_impl(
"${name}"
True
*picky* typically all-caps TRUE / FALSE are used in CMake.
That's not being picky, don't be shy with things like this, consistency IS worth having
WIP: CMake: plumbing for modern CMake usageto CMake: plumbing for modern CMake usage@blender-bot package
Package build started. Download here when ready.
@blender-bot build
@blender-bot build
@blender-bot build
This PR makes independently compiling much of blender impossible. Everything depends on everything else. If you need to track down a bug in your compiler environment that's making one or two files not compile, well, good luck with that. Enjoy spending the next week running clean builds. It should be reverted.
Fix in #109614