Fix #107882: Get evaluated mesh from curve object too #107885

Open
Iliya Katushenock wants to merge 4 commits from mod_moder/blender:tmp_fix_get_eval_mesh_from_curves_too into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Evaluated curve object is mesh too. If this
mesh on gpu (due to subdivision), have to
get this mesh within the same way as mesh
object.

Evaluated curve object is mesh too. If this mesh on gpu (due to subdivision), have to get this mesh within the same way as mesh object.
Iliya Katushenock added the
Interest
Geometry Nodes
Interest
Modeling
labels 2023-05-12 15:39:05 +02:00
Iliya Katushenock added 1 commit 2023-05-12 15:39:15 +02:00
Iliya Katushenock added 1 commit 2023-05-12 15:44:03 +02:00
Iliya Katushenock added this to the Nodes & Physics project 2023-05-12 15:45:55 +02:00
Member

It seems like this just shouldn't check the original object type at all. Whether GPU subdivision is used doesn't really depend on that fact. Maybe it makes more sense to check the mesh's wrapper_type instead.

It seems like this just shouldn't check the original object type at all. Whether GPU subdivision is used doesn't really depend on that fact. Maybe it makes more sense to check the mesh's `wrapper_type` instead.
Iliya Katushenock added 1 commit 2023-05-12 16:39:14 +02:00
progress
Some checks failed
buildbot/vexp-code-patch-coordinator Build done.
4d6b356d07
Author
Member

I see, it may work. But i not total sure (didn't do something with subdivision abstraction in a past).

I see, it may work. But i not total sure (didn't do something with subdivision abstraction in a past).
Member

@blender-bot build

@blender-bot build
Iliya Katushenock added 1 commit 2023-05-12 18:40:48 +02:00
back
Some checks failed
buildbot/vexp-code-patch-coordinator Build done.
5fe827ae04
Author
Member

I can assume that a lot of code does not think that it is impossible to get a mesh from bones/camera/.... And this is exactly what the check is for, so as not to try to get a mesh from uninitialized data.
I'm not sure I know how to reproduce the crashes (and the function has quite a few uses). so I just went back to the first varnianut.
@HooglyBoogly Can you run the bot, just to make sure if it correct way?

I can assume that a lot of code does not think that it is impossible to get a mesh from bones/camera/.... And this is exactly what the check is for, so as not to try to get a mesh from uninitialized data. I'm not sure I know how to reproduce the crashes (and the function has quite a few uses). so I just went back to the first varnianut. @HooglyBoogly Can you run the bot, just to make sure if it correct way?
Member

@blender-bot build

@blender-bot build
Author
Member

Okay, this is for a long time

Okay, this is for a long time
Some checks failed
buildbot/vexp-code-patch-coordinator Build done.
Merge conflict checking is in progress. Try again in few moments.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u tmp_fix_get_eval_mesh_from_curves_too:mod_moder-tmp_fix_get_eval_mesh_from_curves_too
git checkout mod_moder-tmp_fix_get_eval_mesh_from_curves_too
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107885
No description provided.