Cleanup: Use StringRef instead of std::string for node declaration #107911

Closed

Iliya Katushenock wants to merge 2 commits from mod_moder:tmp_use_string_ref_in_socket_declarations into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Iliya Katushenock commented

2023-05-13 19:51:03 +02:00

Member

This strings going not changed at runtime. So, better
to use StringRef instead of std::string for avoid
overhead on memory allocation in constructor.
It also will be make muth more sense in dynamic
declarations in future.

This strings going not changed at runtime. So, better to use `StringRef` instead of `std::string` for avoid overhead on memory allocation in constructor. It also will be make muth more sense in dynamic declarations in future.

Iliya Katushenock added the

label 2023-05-13 19:51:03 +02:00

Iliya Katushenock added 1 commit 2023-05-13 19:51:12 +02:00

9619c04e37 init

Iliya Katushenock requested review from Hans Goudey 2023-05-13 19:51:17 +02:00

Iliya Katushenock added this to the Nodes & Physics project 2023-05-13 19:51:20 +02:00

Hans Goudey commented

2023-05-14 00:28:12 +02:00

Member

This is probably only worth it if it gives a noticeable performance improvement, since it means we have to think about lifetimes where we wouldn't have to otherwise. It may be theoretically better but that doesn't necessarily mean it's worth our time!

This is probably only worth it if it gives a noticeable performance improvement, since it means we have to think about lifetimes where we wouldn't have to otherwise. It may be theoretically better but that doesn't necessarily mean it's worth our time!

Iliya Katushenock commented

2023-05-14 00:32:51 +02:00

Author

Member

For code cleanliness, to be clear in the future, it's better to avoid overhead in declarations that can be called for every update of every node...

For code cleanliness, to be clear in the future, it's better to avoid overhead in declarations that can be called for every update of every node...

Jacques Lucke commented

2023-05-14 22:17:04 +02:00

Member

I think just using a const char * when refering to static strings is fine too. Alternatively could use a static std::string but I don't have a strong preference right now. StringRef would be fine with me as well I guess.

I think just using a `const char *` when refering to static strings is fine too. Alternatively could use a `static std::string ` but I don't have a strong preference right now. `StringRef` would be fine with me as well I guess.

Iliya Katushenock commented

2023-05-14 22:23:01 +02:00

Author

Member

It seems that using a static std::string may still not be cheap (somewhere and sometime we need to allocate this). In fact, here we just want to pass a pointer to a static string. And we can just do it (but not a raw pointer, but what string type argument the socket constructor takes (StringRef)).

It seems that using a static `std::string` may still not be cheap (somewhere and sometime we need to allocate this). In fact, here we just want to pass a pointer to a static string. And we can just do it (but not a raw pointer, but what string type argument the socket constructor takes (`StringRef`)).

Iliya Katushenock added 1 commit 2023-07-11 20:36:32 +02:00

d04fd9699d Merge branch 'main' into tmp_use_string_ref_in_socket_declarations

Iliya Katushenock commented

2023-10-11 17:36:13 +02:00

Author

Member

https://projects.blender.org/blender/blender/pulls/113553

Iliya Katushenock closed this pull request

2023-10-11 17:36:15 +02:00

Iliya Katushenock deleted branch tmp_use_string_ref_in_socket_declarations

2023-10-11 17:36:20 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107911

No description provided.