Metal: Stencil texture view support #107971

Merged
Jeroen Bakker merged 3 commits from Jason-Fielder/blender:MetalStencilViewSupport_And_Refactor into main 2023-05-22 20:40:43 +02:00
Member

Adds stencil texture view support for Metal, allowing reading of
stencil component during texture sample/read.

Stencil view creation refactored to use additional parameter in
textureview creation function, due to deferred stencil parameter
causing double texture view creation in Metal, when this should
ideally be provided upfront.

Authored by Apple: Michael Parkin-White

Ref #96261

Adds stencil texture view support for Metal, allowing reading of stencil component during texture sample/read. Stencil view creation refactored to use additional parameter in textureview creation function, due to deferred stencil parameter causing double texture view creation in Metal, when this should ideally be provided upfront. Authored by Apple: Michael Parkin-White Ref #96261
Jason Fielder added 1 commit 2023-05-16 14:22:00 +02:00
4fa52738ce Metal: Stencil texture view support
Adds stencil texture view support for Metal, allowing reading of
stencil component during texture sample/read.

Stencil view creation refactored to use additional parameter in
textureview creation function, due to deferred stencil parameter
causing double texture view creation in Metal, when this should
ideally be provided upfront.

Authored by Apple: Michael Parkin-White

Ref #96261
Jason Fielder added 1 commit 2023-05-16 14:24:06 +02:00
First-time contributor

Please verify this patch works correctly with OpenGL, as stencil view creation refactored.

Please verify this patch works correctly with OpenGL, as stencil view creation refactored.
Jason Fielder requested review from Jeroen Bakker 2023-05-16 14:25:26 +02:00
Jason Fielder requested review from Clément Foucault 2023-05-16 14:25:26 +02:00
Jason Fielder requested review from Miguel Pozo 2023-05-16 14:25:26 +02:00
Miguel Pozo approved these changes 2023-05-16 20:16:24 +02:00
Member

Looks good to me.
And Workbench Next shadows (which AFAIK, are the only feature that currently uses stencil views) seem to work well in OpenGL.

Looks good to me. And Workbench Next shadows (which AFAIK, are the only feature that currently uses stencil views) seem to work well in OpenGL.
Clément Foucault approved these changes 2023-05-22 10:43:21 +02:00
Clément Foucault added 1 commit 2023-05-22 10:50:15 +02:00
Jeroen Bakker approved these changes 2023-05-22 20:39:48 +02:00
Jeroen Bakker merged commit ae405639e7 into main 2023-05-22 20:40:43 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:38 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107971
No description provided.