Cleanup: Move versioning file 2.8 to C++ #108100

Merged
Hans Goudey merged 5 commits from mod_moder/blender:tmp_move_one_verioning_file_to_cpp into main 2023-05-29 20:56:54 +02:00

Changes:

  1. NULL -> nullptr.
  2. Cast void * to T * by using static_cast.
  3. Using LISTBASE_FOREACH instead of manual for-loops.
  4. eNTreeDoVersionErrors now is enum class : int8_t.
  5. eNTreeDoVersionErrors declaration moved to global scope.
  6. ENUM_OPERATORS for eNTreeDoVersionErrors.

See: #103343

Changes: 1. `NULL` -> `nullptr`. 2. Cast `void *` to `T *` by using `static_cast`. 3. Using `LISTBASE_FOREACH` instead of manual for-loops. 4. `eNTreeDoVersionErrors` now is `enum class : int8_t`. 5. `eNTreeDoVersionErrors` declaration moved to global scope. 6. `ENUM_OPERATORS` for `eNTreeDoVersionErrors`. See: https://projects.blender.org/blender/blender/issues/103343
Iliya Katushenock added 1 commit 2023-05-20 13:51:37 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
c2acae6ace
init
Member

@blender-bot build

@blender-bot build
Iliya Katushenock added 1 commit 2023-05-20 21:42:39 +02:00
Iliya Katushenock requested review from Hans Goudey 2023-05-20 21:46:14 +02:00
Iliya Katushenock changed title from Move verioning 280 to C++ to Move versioning file 2.8 to C++ 2023-05-21 10:47:17 +02:00
Member

Looks good, thanks for doing this. I think it might be nicer to use LISTBASE_FOREACH in these loops though. The casting takes up a lot of space.

Looks good, thanks for doing this. I think it might be nicer to use `LISTBASE_FOREACH` in these loops though. The casting takes up a lot of space.
Author
Member

I wasn't sure if the List struct and the random struct for iteration matched, to be sure in a macro that has cast in the list...

I wasn't sure if the `List` struct and the random struct for iteration matched, to be sure in a macro that has cast in the list...
Iliya Katushenock added 2 commits 2023-05-28 14:09:41 +02:00
Hans Goudey approved these changes 2023-05-29 00:33:58 +02:00
Hans Goudey left a comment
Member

Thanks, looks good to me!

Thanks, looks good to me!
@ -0,0 +1777,4 @@
return true;
}
enum struct eNTreeDoVersionErrors : int8_t {
Member

Apparently enum struct and enum class are the same, but I've usually seen enum class. Might as well use that here for consistency.

Apparently `enum struct` and `enum class` are the same, but I've usually seen `enum class`. Might as well use that here for consistency.
mod_moder marked this conversation as resolved
Member

@blender-bot build

@blender-bot build
Iliya Katushenock added 1 commit 2023-05-29 08:08:57 +02:00
Hans Goudey merged commit 30a25a42e6 into main 2023-05-29 20:56:54 +02:00
Hans Goudey changed title from Move versioning file 2.8 to C++ to Cleanup: Move versioning file 2.8 to C++ 2023-05-29 20:57:08 +02:00
Iliya Katushenock deleted branch tmp_move_one_verioning_file_to_cpp 2023-05-29 20:57:42 +02:00
Member

Oops, missed adding thr Cleanup: prefix to the commit, sorry!

Oops, missed adding thr `Cleanup: ` prefix to the commit, sorry!

This change broke versionning of 2.80 or older files by generating an asert in versionning code (run e.g. blendfile_library_overrides...

Please test your changes!!!

This change broke versionning of 2.80 or older files by generating an asert in versionning code (run e.g. `blendfile_library_overrides`... **Please test your changes!!!**
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108100
No description provided.