Geometry Nodes: expose simulation bake path in UI #108220

Jacques Lucke · 2023-05-24T09:14:13+02:00

Jacques Lucke commented

2023-05-24 09:14:13 +02:00

Doing this is a bit tricky because it's functionality we planned to add for Blender 4.0 instead of 3.6. The long term solution is to have a proper global place where one can manage bake paths.

Doing this is a bit tricky because it's functionality we planned to add for Blender 4.0 instead of 3.6. The long term solution is to have a proper global place where one can manage bake paths. ![image](/attachments/3bad2f09-3d32-4dc7-9612-f724f6d9c8eb)

image.png

97 KiB

image.png

18 KiB

Jacques Lucke added 2 commits 2023-05-24 09:14:23 +02:00

5324a6f3be initial expose

779640406f improve ui a bit

Jacques Lucke requested review from Dalai Felinto 2023-05-24 09:15:20 +02:00

Jacques Lucke requested review from Simon Thommes 2023-05-24 09:15:21 +02:00

Jacques Lucke requested review from Hans Goudey 2023-05-24 09:15:21 +02:00

Simon Thommes commented

2023-05-24 11:14:26 +02:00

I talked about it with Jacques and Sergey just want to mention it here.
We came to the conclusion that this design would need more iteration and it's much lower threshold and straightforward to just expose the path on the modifier in the internal dependencies panel itself for now.

That is much less controversial to do for 3.6, or generally until there is the planned solution of listing all the paths in the scene in its own dedicated panel.

I talked about it with Jacques and Sergey just want to mention it here. We came to the conclusion that this design would need more iteration and it's much lower threshold and straightforward to just expose the path on the modifier in the internal dependencies panel itself for now. That is much less controversial to do for 3.6, or generally until there is the planned solution of listing all the paths in the scene in its own dedicated panel.

Jacques Lucke added 2 commits 2023-05-24 14:00:30 +02:00

1e043a8870 Merge branch 'blender-v3.6-release' into expose-bake-path

96cc7c804c move bake path to modifier panel

Jacques Lucke changed title from ~~WIP: Geometry Nodes: expose simulation bake path in UI~~ to Geometry Nodes: expose simulation bake path in UI

2023-05-24 14:02:04 +02:00

Simon Thommes reviewed 2023-05-24 15:07:32 +02:00

Simon Thommes left a comment

This solution feels a lot more straight forward for now. I'd be generally fine with how it is now.

Two things from testing though:

Just while testing this I noticed that every Geometry Nodes modifier on an object that contains a simulation somewhere will create a folder at the bake location regardless of whether it contains a simulation or not.
This is happening regardless of this patch, just something that I noticed and it's tangentially related to my second topic. Not sure if this can be considered a bug or is expected behavior for now.
There seems to be some inconsistency with when the bake path is generated and filled in and when a folder is actually necessary and being created:
-- Having no simulation on an object at all and pressing the bake button fills in the paths and creates no bake data
-- Having a simulation in one modifier and adding another geonodes modifier without node-group will generate a path and no folder for that second modifier.

Generally the paths should only be filled in whenever a folder is actually being created to avoid confusion. Additionally folders should only be created for modifiers that actually provide data that needs to be baked.

I'm not sure how much I am asking for with this, so feel free to evaluate this feedback under the circumstances in terms of feasability or treat them as individual issues.

This solution feels a lot more straight forward for now. I'd be generally fine with how it is now. Two things from testing though: - Just while testing this I noticed that every Geometry Nodes modifier on an object that contains a simulation somewhere will create a folder at the bake location regardless of whether it contains a simulation or not. This is happening regardless of this patch, just something that I noticed and it's tangentially related to my second topic. Not sure if this can be considered a bug or is expected behavior for now. - There seems to be some inconsistency with when the bake path is generated and filled in and when a folder is actually necessary and being created: -- Having no simulation on an object at all and pressing the bake button fills in the paths and creates no bake data -- Having a simulation in one modifier and adding another geonodes modifier without node-group will generate a path and no folder for that second modifier. Generally the paths should only be filled in whenever a folder is actually being created to avoid confusion. Additionally folders should only be created for modifiers that actually provide data that needs to be baked. I'm not sure how much I am asking for with this, so feel free to evaluate this feedback under the circumstances in terms of feasability or treat them as individual issues.

Jacques Lucke commented

2023-05-24 15:30:04 +02:00

The issues you mention can be fixed, but are independent of this patch.

Hans Goudey approved these changes 2023-05-24 17:33:37 +02:00

source/blender/modifiers/intern/MOD_nodes.cc Outdated

						
				@ -1913,6 +1913,8 @@ static void internal_dependencies_panel_draw(const bContext * /*C*/, Panel *pane

				  PointerRNA *ptr = modifier_panel_get_property_pointers(panel, nullptr);

				  NodesModifierData *nmd = static_cast<NodesModifierData *>(ptr->data);

				  uiItemR(layout, ptr, "simulation_bake_directory", 0, "Bake Path", ICON_NONE);

Hans Goudey commented

2023-05-24 17:33:29 +02:00

  uiLayout *col = uiLayoutColumn(layout, false);
  uiLayoutSetPropSep(col, true);
  uiLayoutSetPropDecorate(col, false);
  uiItemR(col, ptr, "simulation_bake_directory", 0, "Bake Path", ICON_NONE);

```cpp uiLayout *col = uiLayoutColumn(layout, false); uiLayoutSetPropSep(col, true); uiLayoutSetPropDecorate(col, false); uiItemR(col, ptr, "simulation_bake_directory", 0, "Bake Path", ICON_NONE); ```

Simon Thommes approved these changes 2023-05-24 17:51:32 +02:00

Simon Thommes left a comment

The issues you mention can be fixed, but are independent of this patch.

That means this is good to go from my end then. @JacquesLucke can you take over migrating the issues I mentioned in a way you want to tackle them then?

> The issues you mention can be fixed, but are independent of this patch. That means this is good to go from my end then. @JacquesLucke can you take over migrating the issues I mentioned in a way you want to tackle them then?

Dalai Felinto commented

2023-05-25 13:08:22 +02:00

I found a bug which is probably not related to this patch, just more "visible" now : If I try to bake to a folder that I have no access to it doesn't tell me that it failed to bake.

Dalai Felinto commented

2023-05-25 13:09:54 +02:00

I wonder if we could have the path disabled + "a disable toltip" for node-trees that have no simulation nodes. Or optionally not showing them at all.

Dalai Felinto commented

2023-05-25 14:32:07 +02:00

@JacquesLucke also what if we call it "Bake" only? I think path is redundant there.

Jacques Lucke added 2 commits 2023-05-25 14:45:14 +02:00

f54a261cfc Merge branch 'blender-v3.6-release' into expose-bake-path

5e15fe8889 change "Bake Path" to just "Bake"

Jacques Lucke commented

2023-05-25 14:47:06 +02:00

I wonder if we could have the path disabled + "a disable toltip" for node-trees that have no simulation nodes. Or optionally not showing them at all.

To me it feels like this might get more in the way than is useful. Maybe someone wants to set up bake paths before working in the node tree (and only then adding simulations). Feels unnecessary to forbid this.

> I wonder if we could have the path disabled + "a disable toltip" for node-trees that have no simulation nodes. Or optionally not showing them at all. To me it feels like this might get more in the way than is useful. Maybe someone wants to set up bake paths before working in the node tree (and only then adding simulations). Feels unnecessary to forbid this.

Pablo Vazquez commented

2023-05-25 15:23:52 +02:00

Maybe someone wants to set up bake paths before working in the node tree (and only then adding simulations). Feels unnecessary to forbid this.

We could use .active instead of .enabled, which only dims the field while still being able to edit it?

> Maybe someone wants to set up bake paths before working in the node tree (and only then adding simulations). Feels unnecessary to forbid this. We could use `.active` instead of `.enabled`, which only dims the field while still being able to edit it?

Jacques Lucke commented

2023-05-25 15:31:04 +02:00

Just talked with Hans, it doesn't seem like we can edit a disabled hint in either case, unless we are missing something. The disabled hint might only work for operator buttons currently.

I think graying the property out without any hint is more confusing than useful.

Just talked with Hans, it doesn't seem like we can edit a disabled hint in either case, unless we are missing something. The disabled hint might only work for operator buttons currently. I think graying the property out without any hint is more confusing than useful.

👍 1

Jacques Lucke merged commit dc33a8e974 into blender-v3.6-release

2023-05-25 18:56:06 +02:00

Jacques Lucke referenced this issue from a commit

2023-05-25 18:56:06 +02:00

Geometry Nodes: expose simulation bake path in UI

Jacques Lucke deleted branch expose-bake-path

2023-05-25 18:56:07 +02:00

Howard Trickey referenced this issue from a commit

2023-05-29 02:51:36 +02:00

Merge in orign/main:

Sign in to join this conversation.