UI: Fix and improve a few messages #108227
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#108227
Loading…
Reference in New Issue
No description provided.
Delete Branch "pioverfour/blender:dp_fix_messages"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
respective projects.
Plural, it is a collection of multiple points. Also do not use
contraction for "cannot".
Vertices mode in 2.90.
it's an old terminology.
not an effect for a factor.
used anywhere else in the UI (since Blender 2.50).
with space.
@ -1652,3 +1652,3 @@
split = col.split(factor=0.5, align=False)
split.alignment = 'RIGHT'
split.label(text="Samplerate")
split.label(text="Sample rate")
Should be two words
@ -756,3 +756,3 @@
RNA_def_property_enum_items(prop, rna_enum_proportional_falloff_curve_only_items);
RNA_def_property_enum_default(prop, PROP_INVSQUARE);
RNA_def_property_ui_text(prop, "Falloff", "Falloff type the feather");
RNA_def_property_ui_text(prop, "Falloff", "Falloff type of the feather");
Typo: forgotten "of"
@ -1136,3 +1136,3 @@
{SCOPES_WAVEFRM_YCC_601, "YCBCR601", ICON_COLOR, "YCbCr (ITU 601)", ""},
{SCOPES_WAVEFRM_YCC_709, "YCBCR709", ICON_COLOR, "YCbCr (ITU 709)", ""},
{SCOPES_WAVEFRM_YCC_JPEG, "YCBCRJPG", ICON_COLOR, "YCbCr (Jpeg)", ""},
{SCOPES_WAVEFRM_YCC_JPEG, "YCBCRJPG", ICON_COLOR, "YCbCr (JPEG)", ""},
JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.
@ -3969,3 +3969,3 @@
prop,
"Image Boundary Trimming",
"Trim all edges right at the boundary of image(including overscan region)");
"Trim all edges right at the boundary of image (including overscan region)");
Missing space.
@ -312,3 +312,3 @@
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE);
RNA_def_property_ui_text(
prop, "U", "Point in U direction (can't be changed when there are shape keys)");
prop, "U", "Points in U direction (cannot be changed when there are shape keys)");
Plural, it is a collection of multiple points. Also do not use contraction for "cannot".
@ -322,3 +322,3 @@
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE);
RNA_def_property_ui_text(
prop, "V", "Point in V direction (can't be changed when there are shape keys)");
prop, "V", "Points in V direction (cannot be changed when there are shape keys)");
Plural, it is a collection of multiple points. Also do not use contraction for "cannot".
@ -332,3 +332,3 @@
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE);
RNA_def_property_ui_text(
prop, "W", "Point in W direction (can't be changed when there are shape keys)");
prop, "W", "Points in W direction (cannot be changed when there are shape keys)");
Plural, it is a collection of multiple points. Also do not use contraction for "cannot".
@ -2793,3 +2793,3 @@
prop, "rna_MeshVertex_bevel_weight_get", "rna_MeshVertex_bevel_weight_set", NULL);
RNA_def_property_ui_text(
prop, "Bevel Weight", "Weight used by the Bevel modifier 'Only Vertices' option");
prop, "Bevel Weight", "Weight used by the Bevel modifier Vertices mode");
The Bevel modifier's "Only Vertices" option was replaced by a Vertices mode in 2.90.
@ -190,3 +190,3 @@
prop = RNA_def_property(srna, "type", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_items(prop, rna_enum_metaelem_type_items);
RNA_def_property_ui_text(prop, "Type", "Metaball types");
RNA_def_property_ui_text(prop, "Type", "Metaball type");
Affects one object, should be singular.
@ -320,3 +320,3 @@
srna = RNA_def_struct(brna, "MetaBall", "ID");
RNA_def_struct_ui_text(srna, "MetaBall", "Metaball data-block to defined blobby surfaces");
RNA_def_struct_ui_text(srna, "MetaBall", "Metaball data-block to define blobby surfaces");
Typo.
@ -341,3 +341,3 @@
RNA_def_property_range(prop, 0.005f, 10000.0f);
RNA_def_property_ui_range(prop, 0.05f, 1000.0f, 2.5f, 3);
RNA_def_property_ui_text(prop, "Wire Size", "Polygonization resolution in the 3D viewport");
RNA_def_property_ui_text(prop, "Viewport Size", "Polygonization resolution in the 3D viewport");
This option has nothing to do with wireframes, I suppose it's an old terminology.
@ -2432,3 +2432,3 @@
prop,
"Time Offset",
"Either the starting frame (for positive speed) or ending frame (for negative speed.)");
"Either the starting frame (for positive speed) or ending frame (for negative speed)");
Trailing period.
@ -2770,3 +2770,3 @@
"Index Based",
"Set the material on new faces based on the order of the material slot lists. If a "
"material doesn't exist on the modifier object, the face will use the same material slot "
"material doesn't exist on the modified object, the face will use the same material slot "
An object is either modified, or is affected by a modifier.
I think "modifier object" is a used as a noun meaning "the object that owns the modifier". It's probably used in a couple other places too. "modifier's object" would be reasonable too I guess. But I'm not sure this is worth changing TBH
Right, it’s probably clear enough as is. Reverting!
@ -3337,3 +3337,3 @@
RNA_def_property_range(prop, -FLT_MAX, FLT_MAX);
RNA_def_property_ui_range(prop, 0.0, 1.0, 5, 3);
RNA_def_property_ui_text(prop, "Lambda Factor", "Smooth factor effect");
RNA_def_property_ui_text(prop, "Lambda Factor", "Smooth effect factor");
The prop describes a factor for an effect, not an effect for a factor.
@ -3441,3 +3441,3 @@
RNA_def_property_range(prop, -FLT_MAX, FLT_MAX);
RNA_def_property_ui_range(prop, -1000.0, 1000.0, 5, 3);
RNA_def_property_ui_text(prop, "Lambda Factor", "Smooth factor effect");
RNA_def_property_ui_text(prop, "Lambda Factor", "Smooth effect factor");
The prop describes a factor for an effect, not an effect for a factor.
@ -4769,3 +4769,3 @@
RNA_def_property_ui_text(prop,
"Flat Faces",
"Make faces use the minimal vertex weight assigned to their vertices"
"Make faces use the minimal vertex weight assigned to their vertices "
Missing space.
@ -4743,3 +4743,3 @@
{0, "ITUBT601", 0, "ITU 601", ""},
{1, "ITUBT709", 0, "ITU 709", ""},
{2, "JFIF", 0, "Jpeg", ""},
{2, "JFIF", 0, "JPEG", ""},
JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.
@ -3642,3 +3642,3 @@
prop = RNA_def_property(srna, "color", PROP_FLOAT, PROP_COLOR);
RNA_def_property_ui_text(
prop, "Color", "Object color and alpha, used when faces have the ObColor mode enabled");
prop, "Color", "Object color and alpha, used when the Object Color mode is enabled");
ObColor is not used anywhere else in the UI (since Blender 2.50).
@ -2577,3 +2577,3 @@
prop = RNA_def_property(srna, "apply_effector_to_children", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "flag", PART_CHILD_EFFECT);
RNA_def_property_ui_text(prop, "Effect Children", "Apply effectors to children");
RNA_def_property_ui_text(prop, "Affect Children", "Apply effectors to children");
Misspelling.
@ -4248,3 +4248,3 @@
RNA_def_property_range(prop, -DEG2RADF(180.0f), DEG2RADF(180.0f));
RNA_def_property_ui_range(prop, -DEG2RADF(180.0f), DEG2RADF(180.0f), 10, 3);
RNA_def_property_ui_text(prop, "Distort Min", "Minimum angle to display");
RNA_def_property_ui_text(prop, "Sharpness Min", "Minimum angle to display");
Copy-pasted from another pair of properties.
@ -4256,3 +4256,3 @@
RNA_def_property_range(prop, -DEG2RADF(180.0f), DEG2RADF(180.0f));
RNA_def_property_ui_range(prop, -DEG2RADF(180.0f), DEG2RADF(180.0f), 10, 3);
RNA_def_property_ui_text(prop, "Distort Max", "Maximum angle to display");
RNA_def_property_ui_text(prop, "Sharpness Max", "Maximum angle to display");
Copy-pasted from another pair of properties.
@ -5918,3 +5918,3 @@
prop = RNA_def_property(srna, "use_jpeg2k_cinema_preset", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "jp2_flag", R_IMF_JP2_FLAG_CINE_PRESET);
RNA_def_property_ui_text(prop, "Cinema", "Use Openjpeg Cinema Preset");
RNA_def_property_ui_text(prop, "Cinema", "Use OpenJPEG Cinema Preset");
JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.
@ -5923,3 +5923,3 @@
prop = RNA_def_property(srna, "use_jpeg2k_cinema_48", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "jp2_flag", R_IMF_JP2_FLAG_CINE_48);
RNA_def_property_ui_text(prop, "Cinema (48)", "Use Openjpeg Cinema Preset (48fps)");
RNA_def_property_ui_text(prop, "Cinema (48)", "Use OpenJPEG Cinema Preset (48fps)");
JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.
@ -5929,3 +5929,3 @@
RNA_def_property_enum_sdna(prop, NULL, "jp2_codec");
RNA_def_property_enum_items(prop, jp2_codec_items);
RNA_def_property_ui_text(prop, "Codec", "Codec settings for Jpeg2000");
RNA_def_property_ui_text(prop, "Codec", "Codec settings for JPEG 2000");
JPEG, OpenJPEG and JPEG 2000 are the official spellings of the
respective projects.
@ -6258,3 +6258,3 @@
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE);
RNA_def_property_range(prop, 8000, 192000);
RNA_def_property_ui_text(prop, "Samplerate", "Audio samplerate(samples/s)");
RNA_def_property_ui_text(prop, "Sample rate", "Audio sample rate (samples/s)");
Sample rate: should be two words.
@ -90,3 +90,3 @@
RNA_def_property_int_sdna(prop, NULL, "samplerate");
RNA_def_property_clear_flag(prop, PROP_EDITABLE);
RNA_def_property_ui_text(prop, "Samplerate", "Samplerate of the audio in Hz");
RNA_def_property_ui_text(prop, "Sample rate", "Sample rate of the audio in Hz");
Sample rate: should be two words.
@ -4776,3 +4776,3 @@
RNA_def_property_ui_text(prop,
"Tap Key Timeout",
"Pie menu button held longer than this will dismiss menu on release."
"Pie menu button held longer than this will dismiss menu on release "
Replace period with space.
@ -40,3 +40,3 @@
.default_value({1.0f, 1.0f, 1.0f, 1.0f})
.compositor_domain_priority(0);
b.add_input<decl::Float>("Distort")
b.add_input<decl::Float>("Distortion")
Socket in the lens distortion node should be a noun, same as "Dispersion" just below.
Node socket identifiers generally can't be changed without versioning (see
version_node_socket_name
). Probably best to do this separately.I hadn’t thought of that, I’ll have a look at it.
@ -14,3 +14,3 @@
class ResolutionFieldInput final : public bke::CurvesFieldInput {
public:
ResolutionFieldInput() : bke::CurvesFieldInput(CPPType::get<int>(), "resolution")
ResolutionFieldInput() : bke::CurvesFieldInput(CPPType::get<int>(), "Resolution")
Field names should be capitalized.
9f5371a477
to91cf2c7091
Thanks! I added a few inline replies
@ -1652,3 +1652,3 @@
split = col.split(factor=0.5, align=False)
split.alignment = 'RIGHT'
split.label(text="Samplerate")
split.label(text="Sample rate")
Since this is a UI label, title case here-- "Sample Rate"
UI: improve a few messagesto UI: Fix and improve a few messages