Fix #108262: Create cache folder only for modifiers with used sim zones #108278

Lukas Tönne · 2023-05-25T16:01:35+02:00

Lukas Tönne commented

2023-05-25 16:01:35 +02:00

Baking simulations for an object with more than one geonodes modifier
creates cache folders for all modifiers, even if some of them do not
actually have simulation zones. The simulations zones also don't need to
be connected to the output to generate cache folders.

This patch restricts cache folder generation to modifiers which actually
have simulation zones and use them.

Extra cache folders were created because executed modifiers were only
checking if a simulation state exists and not whether it contains actual
zone data (sim_state->zone_states_.is_empty()). The modifiers are
always executed if the object is evaluated by the depsgraph, which
happens if any of the modifiers is time-dependent. Time dependency in
turn is enabled if a simulation zone exists in the tree, regardless of
whether it is used.

Checking for zone states in the cache output during baking lets us
decide if a cache folder is needed.

Baking simulations for an object with more than one geonodes modifier creates cache folders for _all_ modifiers, even if some of them do not actually have simulation zones. The simulations zones also don't need to be connected to the output to generate cache folders. This patch restricts cache folder generation to modifiers which actually have simulation zones and use them. Extra cache folders were created because executed modifiers were only checking if a simulation state exists and not whether it contains actual zone data (`sim_state->zone_states_.is_empty()`). The modifiers are always executed if the object is evaluated by the depsgraph, which happens if _any_ of the modifiers is time-dependent. Time dependency in turn is enabled if a simulation zone exists in the tree, regardless of whether it is used. Checking for zone states in the cache output during baking lets us decide if a cache folder is needed.

Lukas Tönne added 1 commit 2023-05-25 16:01:40 +02:00

4f799a4359 Fix #108262 : Create cache folder only for modifiers with used sim zones.

Lukas Tönne requested review from Jacques Lucke 2023-05-25 16:01:57 +02:00

Lukas Tönne added this to the Nodes & Physics project 2023-05-25 16:02:02 +02:00

Jacques Lucke approved these changes 2023-05-30 11:25:07 +02:00

Lukas Tönne merged commit 292baa2a1d into blender-v3.6-release

2023-05-30 12:25:28 +02:00

Lukas Tönne referenced this issue from a commit

2023-05-30 12:25:30 +02:00

Fix #108262: Create cache folder only for modifiers with used sim zones

Lukas Tönne deleted branch fix_unused_cache_folder_creation

2023-05-30 12:25:31 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #108262: Create cache folder only for modifiers with used sim zones #108278