Animation: Merge Push/Relax Rest Pose operators #108309

Merged
Christoph Lendenfeld merged 8 commits from ChrisLend/blender:pose_blend_to_default into main 2023-07-20 09:27:12 +02:00

This patch merges the two operators Push Pose from Rest Pose and Relax Pose from Rest Pose into one new operator Blend Pose with Rest Pose

The operator has a default range of -1/1 with a default of 0.
The functionality of Relax Pose from Rest Pose is on the positive axis and Push Pose from Rest Pose on the negative.
This is a breaking change so ideal for 4.0

This patch merges the two operators `Push Pose from Rest Pose` and `Relax Pose from Rest Pose` into one new operator `Blend Pose with Rest Pose` The operator has a default range of -1/1 with a default of 0. The functionality of `Relax Pose from Rest Pose` is on the positive axis and `Push Pose from Rest Pose` on the negative. This is a breaking change so ideal for 4.0
Christoph Lendenfeld added this to the 4.0 milestone 2023-05-26 12:51:37 +02:00
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2023-05-26 12:51:37 +02:00
Christoph Lendenfeld added 1 commit 2023-05-26 12:51:43 +02:00
Christoph Lendenfeld added 1 commit 2023-05-26 12:53:04 +02:00
to make consistent with blend_to_default
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-05-26 12:55:51 +02:00
Sybren A. Stüvel requested changes 2023-05-26 14:57:17 +02:00
Sybren A. Stüvel left a comment
Member

Good idea to merge these two, as they're two sides of the same coin. A few remarks:

  • The initial value is now at 50%, causing an immediate jump in the pose. I think 0% would be a better start, so that you can gradually dial in the desired amount.
  • IMO it would be better to have the 'negative' range (i.e. "push from rest pose") available immediately, without having to use the E key. Even though it's technically extrapolation, it also makes the feature less accessible.

From the change in naming, the extra key required to get the 'push from' behaviour, the change in name and description, those all appear to be hiding the 'push from' side of things. These used to be two equal operators (in terms of visibility, directness, etc.), and I think it's good to rethink some of the details to make sure that it doesn't appear like one of them got lost somehow.

Good idea to merge these two, as they're two sides of the same coin. A few remarks: - The initial value is now at 50%, causing an immediate jump in the pose. I think 0% would be a better start, so that you can gradually dial in the desired amount. - IMO it would be better to have the 'negative' range (i.e. "push from rest pose") available immediately, without having to use the `E` key. Even though it's technically extrapolation, it also makes the feature less accessible. From the change in naming, the extra key required to get the 'push from' behaviour, the change in name and description, those all appear to be hiding the 'push from' side of things. These used to be two equal operators (in terms of visibility, directness, etc.), and I think it's good to rethink some of the details to make sure that it doesn't appear like one of them got lost somehow.
@ -3739,3 +3737,4 @@
layout.operator("pose.relax")
layout.operator("pose.breakdown")
layout.operator("pose.blend_to_neighbor")
layout.operator("pose.blend_to_rest")

For findability it might be better to keep the position in the menu the same.

For findability it might be better to keep the position in the menu the same.
@ -1658,1 +1585,3 @@
ot->description = "Make the current pose more similar to the rest pose";
ot->name = "Blend Pose to Rest Pose";
ot->idname = "POSE_OT_blend_to_rest";
ot->description = "Blend the current pose to the rest pose";

I think the old description was better. As the wording is more different from the operator name, it is more explanatory for when you don't quite understand the operator name itself.

Also the current description only describes one half of the operator. How about something like this?

"Make the current pose more similar to, or further away from, the rest pose"

Same for the name, by the way. Maybe change it to "Blend Pose from/to Rest Pose"?

I think the old description was better. As the wording is more different from the operator name, it is more explanatory for when you don't quite understand the operator name itself. Also the current description only describes one half of the operator. How about something like this? "Make the current pose more similar to, or further away from, the rest pose" Same for the name, by the way. Maybe change it to "Blend Pose from/to Rest Pose"?
Christoph Lendenfeld added 2 commits 2023-06-01 12:05:32 +02:00
Author
Member

I've implemented the changes, except for the change to the operator name
This needs to be discussed in the meeting, but the name "Blend Pose from Rest Pose" is confusing to me.
Like it's not clear where it is going.

That's also the reason why I hid away the push functionality behind the overshoot at first. As an animator it is hard to predict where that is going, so it will always be less important than blending to the rest pose. But I see from a consistency point of view how it should stay the same.

I've implemented the changes, except for the change to the operator name This needs to be discussed in the meeting, but the name "Blend Pose from Rest Pose" is confusing to me. Like it's not clear where it is going. That's also the reason why I hid away the push functionality behind the overshoot at first. As an animator it is hard to predict where that is going, so it will always be less important than blending to the rest pose. But I see from a consistency point of view how it should stay the same.
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-06-01 12:10:43 +02:00
Christoph Lendenfeld added 2 commits 2023-06-09 18:48:30 +02:00
Author
Member

renamed operator to Blend Pose with Rest Pose as discussed yesterday in the A&R meeting

renamed operator to `Blend Pose with Rest Pose` as discussed yesterday in the A&R meeting
Christoph Lendenfeld added this to the Animation & Rigging project 2023-07-14 16:45:30 +02:00
Sybren A. Stüvel approved these changes 2023-07-17 18:12:35 +02:00
Sybren A. Stüvel left a comment
Member

LGTM!

As a follow-up refactor, do you think it's worth it to change

if (!ELEM(pso->mode, POSESLIDE_BLEND_REST)) {
  pose_slide_apply(C, pso);
}
else {
  pose_slide_rest_pose_apply(C, pso);
}

to

if (pso->mode == POSESLIDE_BLEND_REST) {
  pose_slide_rest_pose_apply(C, pso);
}
else {
  pose_slide_apply(C, pso);
}

?

LGTM! As a follow-up refactor, do you think it's worth it to change ```c if (!ELEM(pso->mode, POSESLIDE_BLEND_REST)) { pose_slide_apply(C, pso); } else { pose_slide_rest_pose_apply(C, pso); } ``` to ```c if (pso->mode == POSESLIDE_BLEND_REST) { pose_slide_rest_pose_apply(C, pso); } else { pose_slide_apply(C, pso); } ``` ?
Christoph Lendenfeld added 2 commits 2023-07-20 09:26:10 +02:00
Christoph Lendenfeld merged commit 44fb4fa46a into main 2023-07-20 09:27:12 +02:00
Christoph Lendenfeld deleted branch pose_blend_to_default 2023-07-20 09:27:14 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108309
No description provided.