blender/blender

Fix: UI: cannot copy-paste many array buttons in nodes #108349

Merged

Philipp Oeser merged 2 commits from lichtwerk/blender:108096_b into blender-v3.6-release

2023-06-06 14:24:52 +02:00

Philipp Oeser commented

2023-05-27 12:51:06 +02:00

Member

This came up in #108096

Reason this fails is the ui_but_has_array_value check [which depends
on a property subtype that supports arrays]. The default VectorBuilder
has a PropertySubType of PROP_NONE though, so one possibility
would be to change this to PROP_XYZ.

However, RNA should know much better which RNA property buttons
have arrays than the UI code, so use RNA_property_array_check now
(instead of checking particular UI property subtypes).

This came up in #108096 Reason this fails is the `ui_but_has_array_value` check [which depends on a property subtype that supports arrays]. The default `VectorBuilder` has a `PropertySubType` of `PROP_NONE` though, so one possibility would be to change this to `PROP_XYZ`. However, RNA should know much better which RNA property buttons have arrays than the UI code, so use RNA_property_array_check now (instead of checking particular UI property subtypes).

Philipp Oeser added 1 commit 2023-05-27 12:51:17 +02:00

Fix: UI: cannot copy-paste many array buttons in nodes b6460fc12f

This came up in #108096

Reason this fails is the `ui_but_has_array_value` check [which depends
on a property subtype that supports arrays]. The default `VectorBuilder`
has a `PropertySubType` of `PROP_NONE` though, now changed to `PROP_XYZ`
which does make sense for vectors and doesnt have other relevant
behavior changes (except for maybe the auto-coloring fcurves when
keyframing).

Philipp Oeser added this to the Module: Nodes & Physics project 2023-05-27 12:51:23 +02:00

Philipp Oeser added the

label 2023-05-27 12:51:35 +02:00

Philipp Oeser requested review from Hans Goudey 2023-05-27 12:51:59 +02:00

Philipp Oeser requested review from Harley Acheson 2023-05-27 12:52:19 +02:00

Harley Acheson commented

2023-05-28 20:23:22 +02:00

Member

It seems odd to me that ui_but_has_array_value uses a list of subtypes for this. Could it not use RNA_property_array_check(but->rnaprop) as part of its test?

It seems odd to me that `ui_but_has_array_value` uses a list of subtypes for this. Could it not use `RNA_property_array_check(but->rnaprop)` as part of its test?

Philipp Oeser commented

2023-05-30 13:46:00 +02:00

Author

Member

It seems odd to me that ui_but_has_array_value uses a list of subtypes for this. Could it not use RNA_property_array_check(but->rnaprop) as part of its test?

Was thinking the same initially, but went with the less disruptive fix first.
Still think RNA_property_array_check is probably better for this, would enable us to get rid of a function and save us from future issues like this afaict.

Still, I often find myself prefering to not mix fixes and such "cleanup".

> It seems odd to me that `ui_but_has_array_value` uses a list of subtypes for this. Could it not use `RNA_property_array_check(but->rnaprop)` as part of its test? Was thinking the same initially, but went with the less disruptive fix first. Still think RNA_property_array_check is probably better for this, would enable us to get rid of a function and save us from future issues like this afaict. Still, I often find myself prefering to not mix fixes and such "cleanup".

Hans Goudey commented

2023-06-05 21:23:02 +02:00

Member

TBH it seems like what Harley suggests is the way to go. RNA should know much better which RNA property buttons have arrays than the UI code. The way it is right now looks redundant.

TBH it seems like what Harley suggests is the way to go. RNA should know much better which RNA property buttons have arrays than the UI code. The way it is right now looks redundant.

Philipp Oeser added 1 commit 2023-06-06 12:31:32 +02:00

Use RNA_property_array_check instead of tweaking subtype 479a6a2fd3

this seems more future proof

Philipp Oeser commented

2023-06-06 12:34:42 +02:00

Author

Member

Yeah, lets do it that way then

Yeah, lets do it that way then

Hans Goudey approved these changes 2023-06-06 13:54:37 +02:00

Philipp Oeser merged commit 014825dd26 into blender-v3.6-release

2023-06-06 14:24:52 +02:00

Philipp Oeser deleted branch 108096_b

2023-06-06 14:24:53 +02:00

Philipp Oeser referenced this issue from a commit

2023-06-06 14:24:53 +02:00

Fix: UI: cannot copy-paste many array buttons in nodes

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108349

No description provided.